From patchwork Thu Aug 2 02:45:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: zhong jiang X-Patchwork-Id: 10553231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8015313B8 for ; Thu, 2 Aug 2018 02:56:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 733D52968C for ; Thu, 2 Aug 2018 02:56:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6598E29744; Thu, 2 Aug 2018 02:56:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 21B672968C for ; Thu, 2 Aug 2018 02:56:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbeHBEpo (ORCPT ); Thu, 2 Aug 2018 00:45:44 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:49183 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725931AbeHBEpo (ORCPT ); Thu, 2 Aug 2018 00:45:44 -0400 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 597821CD7E5E7; Thu, 2 Aug 2018 10:56:47 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.399.0; Thu, 2 Aug 2018 10:56:38 +0800 From: zhong jiang To: , , , , CC: , Subject: [PATCH 1/2] scsi:qla1280: remove unnessary same condition check Date: Thu, 2 Aug 2018 10:45:00 +0800 Message-ID: <1533177901-19514-2-git-send-email-zhongjiang@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1533177901-19514-1-git-send-email-zhongjiang@huawei.com> References: <1533177901-19514-1-git-send-email-zhongjiang@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP doulbe test in a expression is redundant. so just remove one of them. Signed-off-by: zhong jiang --- drivers/scsi/qla1280.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 390775d..8e6f156 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c @@ -1504,7 +1504,6 @@ static void qla1280_mailbox_timeout(struct timer_list *t) /* Issue SCSI reset, if we can't reset twice then bus is dead */ for (bus = 0; bus < ha->ports; bus++) { if (!ha->bus_settings[bus].disable_scsi_reset && - qla1280_bus_reset(ha, bus) && qla1280_bus_reset(ha, bus)) ha->bus_settings[bus].scsi_bus_dead = 1; }