From patchwork Tue Oct 16 20:39:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurence Oberman X-Patchwork-Id: 10644173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 67E7B109C for ; Tue, 16 Oct 2018 20:39:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 596EF2A8C7 for ; Tue, 16 Oct 2018 20:39:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D5EC2A8C9; Tue, 16 Oct 2018 20:39:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE6182A8C7 for ; Tue, 16 Oct 2018 20:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726325AbeJQEb1 (ORCPT ); Wed, 17 Oct 2018 00:31:27 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:33239 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726132AbeJQEb1 (ORCPT ); Wed, 17 Oct 2018 00:31:27 -0400 Received: by mail-qk1-f193.google.com with SMTP id 84-v6so15087366qkf.0 for ; Tue, 16 Oct 2018 13:39:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=PWBO057AnXAwXzSJ5fWcHf8jSvNdhHXIkikaIjTTT54=; b=hpiBoxx53DVPw1B3j1aXj4LQxOy3eEbSgF/FfAHj74GZoGYPX1PbJZn8Jmbv0jSI5c sOPvRWcDXpXr4wzEwTmRbP7BRFMoLCa981pxSVxhNc4uvRZA+hlDceIJp/SgRAEwEclq VUeE+ZvGCsHiOvwGpVjY/CiREfCiNhy/eROl049rSceAcQNYDTaKapG+WQgavVj+WRbm TRFx/1jl+uP2zYQ3g05w26e3VDpnoJZ9bXH4cGqOarEHnZMsc1LfNOkvYlO5wqQLk4S4 pbucqoPXaOmQq26iWqe77jpX2tlEbm1ntSkIWRBIFzMHFV37LI3xI9fpHN8PJGwSgvdf 0rGw== X-Gm-Message-State: ABuFfohc2JuT28RL3P34PNTI4UHWIKEJrFTMstoHi3646kyIrzW/FNa5 6rf6VXfXVcxAkKwjxKoxxhKfz8x8G3Q= X-Google-Smtp-Source: ACcGV63pUijQy6jilndedgo78VYzfjDg2nMv9PQRjZ3uLeKv9WbnMQyfB+V40bj1OzvC1c7vslpApw== X-Received: by 2002:a37:595:: with SMTP id 143-v6mr21298543qkf.271.1539722358141; Tue, 16 Oct 2018 13:39:18 -0700 (PDT) Received: from loberhel74 (174-083-000-020.dhcp.chtrptr.net. [174.83.0.20]) by smtp.gmail.com with ESMTPSA id n3-v6sm9553966qkc.48.2018.10.16.13.39.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Oct 2018 13:39:17 -0700 (PDT) Message-ID: <1539722356.20579.2.camel@redhat.com> Subject: [PATCH] scsi_error: Remove scsi_block_when_processing_errors: message From: Laurence Oberman To: linux-scsi Cc: Hannes Reinecke , Ewan Milne , Bart Van Assche , "Bottomley, James" Date: Tue, 16 Oct 2018 16:39:16 -0400 X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This message floods the log when enabling mask 0x7 for  /proc/sys/dev/scsi/logging_level  xxxxxxxx kernel: scsi_block_when_processing_errors: rtn: 1  Its not needed and makes tracing just scsi_eh* messages way too verbose so get rid of it Signed-off-by: Laurence Oberman Reviewed-by: Hannes Reinecke Reviewed-by: Chad Dupuis Signed-off-by: Laurence Oberman Reviewed-by: Ewan D. Milne ---  drivers/scsi/scsi_error.c | 3 ---  1 file changed, 3 deletions(-)  EXPORT_SYMBOL(scsi_block_when_processing_errors); --  1.8.3.1 diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index b7a8fdf..c736d61 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -338,9 +338,6 @@ int scsi_block_when_processing_errors(struct scsi_device *sdev)     online = scsi_device_online(sdev);   - SCSI_LOG_ERROR_RECOVERY(5, sdev_printk(KERN_INFO, sdev, - "%s: rtn: %d\n", __func__, online)); -   return online;  }