diff mbox series

[v2] mpt3sas: Display message on Configurable secure HBA

Message ID 1541756052-30535-1-git-send-email-sreekanth.reddy@broadcom.com (mailing list archive)
State Accepted
Headers show
Series [v2] mpt3sas: Display message on Configurable secure HBA | expand

Commit Message

Sreekanth Reddy Nov. 9, 2018, 9:34 a.m. UTC 
Display below warning message only up on detection of
Configurable secure type controllers.

"HBA is in Configurable Secure mode"

v2 change set:
Replaced dev_warn() with dev_info() function while
displaying above message.

Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
---
 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Martin K. Petersen Nov. 22, 2018, 3:17 a.m. UTC | #1 
Sreekanth,

> Display below warning message only up on detection of
> Configurable secure type controllers.
>
> "HBA is in Configurable Secure mode"
>

Please put a "---" separator before patch change log or any commentary
that shouldn't end up in the commit description. Fixed it up.

> v2 change set:
> Replaced dev_warn() with dev_info() function while
> displaying above message.

Applied to 4.21/scsi-queue. Thanks.
diff mbox series

Patch

diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 104413e..5b9806d 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -10366,6 +10366,10 @@  static void pcie_device_make_active(struct MPT3SAS_ADAPTER *ioc,
 		ioc->id = mpt3_ids++;
 		sprintf(ioc->driver_name, "%s", MPT3SAS_DRIVER_NAME);
 		switch (pdev->device) {
+		case MPI26_MFGPAGE_DEVID_CFG_SEC_3816:
+		case MPI26_MFGPAGE_DEVID_CFG_SEC_3916:
+			dev_info(&pdev->dev,
+			    "HBA is in Configurable Secure mode\n");
 		case MPI26_MFGPAGE_DEVID_SAS3508:
 		case MPI26_MFGPAGE_DEVID_SAS3508_1:
 		case MPI26_MFGPAGE_DEVID_SAS3408:
@@ -10373,9 +10377,6 @@  static void pcie_device_make_active(struct MPT3SAS_ADAPTER *ioc,
 		case MPI26_MFGPAGE_DEVID_SAS3516_1:
 		case MPI26_MFGPAGE_DEVID_SAS3416:
 		case MPI26_MFGPAGE_DEVID_SAS3616:
-		case MPI26_MFGPAGE_DEVID_CFG_SEC_3816:
-		case MPI26_MFGPAGE_DEVID_CFG_SEC_3916:
-			ioc_warn(ioc, "HBA is in Configurable Secure mode\n");
 		case MPI26_MFGPAGE_DEVID_HARD_SEC_3816:
 		case MPI26_MFGPAGE_DEVID_HARD_SEC_3916:
 			ioc->is_gen35_ioc = 1;