From patchwork Fri Dec 7 22:29:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Don Brace X-Patchwork-Id: 10718975 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4F2DE18B8 for ; Fri, 7 Dec 2018 22:29:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3ECCE2F2CF for ; Fri, 7 Dec 2018 22:29:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 31EF72F2E3; Fri, 7 Dec 2018 22:29:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BADF42F2CF for ; Fri, 7 Dec 2018 22:29:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726114AbeLGW3q (ORCPT ); Fri, 7 Dec 2018 17:29:46 -0500 Received: from mail-eopbgr730051.outbound.protection.outlook.com ([40.107.73.51]:63392 "EHLO NAM05-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726093AbeLGW3q (ORCPT ); Fri, 7 Dec 2018 17:29:46 -0500 Received: from CY4PR19CA0030.namprd19.prod.outlook.com (2603:10b6:903:103::16) by SN1PR19MB0414.namprd19.prod.outlook.com (2a01:111:e400:5964::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.19; Fri, 7 Dec 2018 22:29:42 +0000 Received: from BN1BFFO11FD024.protection.gbl (2a01:111:f400:7c10::1:191) by CY4PR19CA0030.outlook.office365.com (2603:10b6:903:103::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1404.19 via Frontend Transport; Fri, 7 Dec 2018 22:29:42 +0000 Authentication-Results: spf=pass (sender IP is 208.19.100.23) smtp.mailfrom=microsemi.com; linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=bestguesspass action=none header.from=microsemi.com; Received-SPF: Pass (protection.outlook.com: domain of microsemi.com designates 208.19.100.23 as permitted sender) receiver=protection.outlook.com; client-ip=208.19.100.23; helo=AVMBX3.microsemi.net; Received: from AVMBX3.microsemi.net (208.19.100.23) by BN1BFFO11FD024.mail.protection.outlook.com (10.58.144.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.1404.13 via Frontend Transport; Fri, 7 Dec 2018 22:29:40 +0000 Received: from AVMBX2.microsemi.net (10.100.34.32) by AVMBX3.microsemi.net (10.100.34.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1531.3; Fri, 7 Dec 2018 14:29:38 -0800 Received: from [127.0.1.1] (10.238.32.34) by avmbx2.microsemi.net (10.100.34.32) with Microsoft SMTP Server id 15.1.1531.3 via Frontend Transport; Fri, 7 Dec 2018 14:29:38 -0800 Subject: [PATCH 15/20] smartpqi: do not offline disks for transient did no connect conditions From: Don Brace To: , , , , , , , , , , , CC: Date: Fri, 7 Dec 2018 16:29:37 -0600 Message-ID: <154422177779.1218.7573258041248951917.stgit@brunhilda> In-Reply-To: <154422079293.1218.12539829857034151457.stgit@brunhilda> References: <154422079293.1218.12539829857034151457.stgit@brunhilda> User-Agent: StGit/0.19-dirty MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.23;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(346002)(396003)(376002)(39860400002)(136003)(2970300002)(199004)(189003)(76176011)(16576012)(81156014)(446003)(305945005)(106002)(23676004)(2486003)(2201001)(126002)(11346002)(110136005)(44832011)(4326008)(476003)(26005)(230700001)(97736004)(2906002)(86362001)(486006)(33716001)(58126008)(14444005)(8936002)(186003)(77096007)(9686003)(316002)(81166006)(53936002)(47776003)(356004)(478600001)(336012)(68736007)(5660300001)(103116003)(8676002)(33896004)(50466002)(106466001)(69596002)(921003)(2101003)(1121003)(83996005);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR19MB0414;H:AVMBX3.microsemi.net;FPR:;SPF:Pass;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:3; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD024;1:aa7JrBxPAOfSECOW1cETZHBUnE05K+H3jbgyNgsy10yiAzOz/+Zm8scSuA93RY/D9QAEN6GItQ1MBrS++1LFW9GskYg7bcwnzasOPWOLSZuGMksxu0Vqhs7sNpeqoJK9 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4863c316-3295-4e1d-0499-08d65c937a9d X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4608076)(2017052603328)(7153060);SRVR:SN1PR19MB0414; X-Microsoft-Exchange-Diagnostics: 1;SN1PR19MB0414;3:IGvkhmV4sjbfWTNAdCaFtxpJBL2gm/ZXqK+qlifRRT3XLvKfxJKvec+uuIGj0kVqZuaPU+YnV554ea8C8rc5c8pw3dw/QF1LVq6+O36Jus5X5muPp90rxs8ExQAXhCqq8dcQz17HQvKkxVdO6u8SqxJv1lDG+sgG3k5sp6wLCvM5fgBFWDHNbLU6/SkCw681JAAuFvXIRo2oPMWGgFyqf+Y3hOMz2XvDBQgQrmsCOLnTInjQV0v+qj37c69pt+BkVVUr+mgD7DOKIVa5M9X5/tjj4/nXmhPMDEshpr9eX9e+9i9QGtZQ9OJx3LKSMBwPO24e35E01capJDbh/x/2dlxFZS3qXC64Xwnb6f0zwJI=;25:2g54VgABJrhituMopHzcXgWgl0xX1/gWw369nooIplhd5rk+QAG5pb1H2W8/cNoIIfvXEds/vfrRXINMP9wC1khtI8EcfLg41oc8++6y73ihYIGi+38IYMZYa0WX9U7XRsa7KtkTTRnJThGeszEJav90U9LfUr+b0C5JqBg4QMj+TOqwh4lDjM/nc1rDQcrq5T37mO89UFrZaJo8AsxQwXaxW3o0LiL6vhFhMvloj0lGGomqd5/ZWyARbqM6AIDvF5fO//7tMNl5T3NDVxVrtLTp9r8SCbpvwveRJLLsOR2YrCSMWmQd2YLQe71154pBSD580Nf6IcDFNsyJbz5M/VhHRxedjkT68Kq89ZadfWI= X-MS-TrafficTypeDiagnostic: SN1PR19MB0414: X-Microsoft-Exchange-Diagnostics: 1;SN1PR19MB0414;31:2iyuo15p462LZIKrr6UpSKnAYvcf0EzvOUbXPV1JJPtGv12ou2cdgivj+GF1w6Vs++R4BriD+iW7K1ySMQcF5f/fMnV5cLrItNoVjEsXTlEQat36fTqgY49/bfYZmIx77q/hDGXCJ2b3qw3Ck5gvkcfLeQqJXwJ4NmUuBcQD/VTO7i5JDumGE41dnWcUInRa/Cqu1cjAIW4SqXAK42kHrqYfnr0WjHadJ6LrsmVsCfw=;20:SbgdQ7R3sYDEWV/tvfFj1lF2bK8iKBDt7xCy8QQ7lQjRb+heLPxGHkPIJ7ge80eTWuXF+IFHdq46lMptjx+OYYg2wp1B+Xv2K6kN5h6TB9qqPG1jVp0npnzjU+Ou4qxfCQ9+7YozXQ5tqq3n2eFk2aXK+o4MeJykSG1V8h6gWDUYoXuEhmQdO6DvifwHIm9rnrjsiDDqsn8StFYp1k546iKChExQ7ZzhFGXLT8LfDNg7jPFkBCDBCKaP/JQ7F19aS1mQfIZRnXgsA8s3GDFkswZSeia0TKGPngOqQd1FR6iD9glL0NH3RzhnNeEM8vgv54RJ3/0Lh3OIrI2mrdT4Np5bPJsuJR04YhPqEv/RYjV4zm87ItOJhQxmr+zqyBrik/xWlbo/OKikxYxhPSwmi6YhmyL3bLgo3KG3cT850VRlBpD0L37HBudO++NQrLyjE0H7HEeMmqeBE+mPybPc65Rcb745ysxcaxn8L2KU9Ev1rgdl+PnMHaLbQ/p+nqFEKpAnksaTZgCy91C8RVsRBpaH/M+MmA2K/ADzS66AiSOOKxGAnsLmbABGjuxdTVWxilpEeim6YQB3D9QvzR8oH7YWp2O8L+djKxBy8L7RNMs= X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231455)(999002)(944501520)(52105112)(3002001)(93006095)(93004095)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051)(76991095);SRVR:SN1PR19MB0414;BCL:0;PCL:0;RULEID:;SRVR:SN1PR19MB0414; X-Microsoft-Exchange-Diagnostics: 1;SN1PR19MB0414;4:NgNea1Y/rKMlV/5178DerO0kMwAXtsRFVkS94Xtp905gKtRptt7R2idgJT8Nnp1OYpkLrp8DBkcKCewqsxeFJAs7i9XR7+87bfQbBV94CPlWqUr4X0XPQD3kXD1F61yXUywWhiyqG5QUsapMQtxcsVMIkuvhyfbtaItyLl5uEAEmH04uGAaOUpOWBVCIAg5FxJb5XP8lq9yy1g4pQ4uapbOeKzsP5Q44PrqfpsiNeqOaiq2/Kh1t61TINwOdY+HP5PNuiIUsJm11CBd6sdvsyw== X-Forefront-PRVS: 0879599414 X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BSN1PR19MB0414=3B23=3AOK7hxi0?= =?utf-8?q?zEfKt4GZXpzJfwYtnrUiakjf73eF9V/UikQ1SWtXZ+zB/Xh2aCrtOvQ+lS+QWOegu?= =?utf-8?q?QyHKpnqDenZIhsC73BXGeIhMQcvTPhgsv8QA3p6Cu7zRNtYWX1RKxPsTCbRzrjPPj?= =?utf-8?q?DfmUZcDROaUUqZyg+AucgKhBtU2uOAhunyUvo6kbSzMuLScCCFUAFyEepWRXzZYjK?= =?utf-8?q?yfvUZNj6yjfo9G58ySTP4zNNXkpqBkyLhgFMfRrNOe/5gLPS4ZF+L0a6uKYfs/6IF?= =?utf-8?q?4QtpusHLh7f62jrVz/V2hbqXaAmwulZN+RXLVgHfNx4/HsAOgvLLGU0HV04d1XUrD?= =?utf-8?q?5zMQ8p77cX+QGBfq1i/uVCLRMFd8XAU+ynrJLtsQcow4tq9ycJObVTy6ipYK99jHE?= =?utf-8?q?w8M5uHiKn0not8rWQEiwxC5g2Ghk9APipsiHdGLCetuaNf7GXlq1l5J/SDQcaveyk?= =?utf-8?q?HZur0J2W9QKSWKPQxLIBlfpRR40XQm50wfXS00ubMo7adIzKz1sug7dGMmcu26ffP?= =?utf-8?q?FqenVS0kKb2sJr9C/N5LQoG0vm2839SvoAFT4uaayzDorqCcc93inq44g9gw4Kffu?= =?utf-8?q?mDZ2H++tlD+MjcwgnQ4FkeHEiGg9wyXhLxgzrKnzsyPvYCiNNaj6VBjcnOlMcFQ2W?= =?utf-8?q?G41WQV1zuwSEHwBP/I1nLiLqajHnRmTq+ifV84k1LTpZjrgosztlnkrwRviJR6m7e?= =?utf-8?q?UkXlEz4I+tLSZkoSl1H0w/VvENgK3GySNQs6ltdjxLElxc/9oqPG2m+TlSdkGVQkh?= =?utf-8?q?yq7MJSS2h7Lrk5ql+gSqVcmZLk7lIGS7XplsfG/fFGQ6L3FgOp0zytVVGsWTWbgtf?= =?utf-8?q?0gf11kHmrCnIZeqyChbA4+H2DiRlSUl8h+a+qoOsnHjkPVPg9ysiIxwj0DeXD8K9e?= =?utf-8?q?KasNiziZz9j59KOXGCRcN2J2jcgxmPfySkUIAv23mw0CyvevHcDXn5JluQSsw/BY9?= =?utf-8?q?2Z6AiKE883ZVknVSbkPOLooZe1Zt8NZ4WSPC8bFkSQ5Zs7NorLlp8ZmAOPPc4uZSq?= =?utf-8?q?/itfrleF3o47M9e+O04ng2Dxjrd+ZA/y3YlpHRe38jTQwXPfpbHK+uM1Kke7k4aJv?= =?utf-8?q?Z9Ha4KWox5RMS1cOmoYIIoKDiDq4XLxRZS8PUFDXIclxqYRv0vfw6gBFbaWhw7GpY?= =?utf-8?q?TiyGpMg266l109EW39/LTigWIH7fzreQGIxARJPnOInrjJPxuAxH2yLCtOTJQ=3D?= =?utf-8?q?=3D?= X-Microsoft-Antispam-Message-Info: hvsBeUKEltgrx06pdqq+UkTHo/Kx31y2PIPEsFpKYx0nNm1R4/GRNQFyjjH4GUdnYzWP5qGa0l5w1z4oc91Od7oRKSBQvUz/xr5++vsTr09jh271/NU1r01s/2RNHytnWIVG1CqOFgHrcLdRFCUza1QAjrAkKuetHfEaFMZAX30orGsar45EulhkbbLYJb+bl8aAUm5JaC9nILLV4ON+iu2a2d+C8JQCOD6IST5kNgC/GZR/tT8rsJVv1OOacmuraN11ShwclejXXrasBOeQjDyVLBtMhykTxIy30s26wlWEReZes5RrW5rZe3a9TB68KEG3WZXIG9Pb9c1BXHVC8jVvc4NuJVvVmUxzk8UR7pM= X-Microsoft-Exchange-Diagnostics: 1;SN1PR19MB0414;6:RgvOZyid9p/YLvGpkPcwyn/e6fDQRZb4TXCrvPfP90UAi/Dbj/mVl0k8/cVOF/r7o7w0V25oieouqhH+HjJBx5ZT+kXpnoh6AaQmxAQpxbFnKQe4CBzyZ8r5NJeD9vHw8zG+ob05pBct3FFZAJAn4ujDqxhU3zWG0JXpFYpdCV1MkUXVc5/iMM6Z47WZKYBymxmUHg6Wrx+aq6/im8Bu0q5l7UDEH3UNyhdcdztGHD0ZhjfHvrltXwnL3nhuhO+Ce8dqeNGuS9Ro4L3sU4s2cHYyOok0FNu54ezy8AHe5w8mVsHRtI9nFSBxmF+EjFscIKBeIh1TofvinggUEeniMFiJwsrtBYvYLp8nj5sDVUQ8Mln+QExjg416s8Zy7+fsOVwoqBQv183snvMznNimeCkO3p1E7CEio69riVbRdMco2AGhn8AzlIed0yPxpznBtNcMIVkBMj29qHceH6rGTg==;5:Y6HJOS9U3hVH9y7MVw8JiyELZYjlrsgrkez51CHQEsiluE6nKZD0BZ7WGfW51tYsRZ6TU4vdGL/FKSox/QLKNJmFMirll6v8gKmXI07l9vU31Pn/Wzpc7YxcEROExEblBAf8fuSf/qnQkTdNKB7hJjGvovO1+qLfNx9gDEnHGSA=;7:qHKw5djLj1uX8wLHiTe69n5UWLpkVERDvwVmHxw8yOBB1/DYiVBqfDQotCu90fAXBdTGA/imUcEohsUp0ZXh7UiEdXPRhhAmlixUdFivhSoxtD0+b62hRS1cNMzvqtKEh1RgF12y/KY5J3p69zYqEQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2018 22:29:40.5156 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4863c316-3295-4e1d-0499-08d65c937a9d X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad;Ip=[208.19.100.23];Helo=[AVMBX3.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR19MB0414 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dave Carroll Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 45c797bc1483..f146ebf3921f 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -1686,6 +1686,7 @@ static void pqi_scsi_update_device(struct pqi_scsi_dev *existing_device, new_device->raid_bypass_configured; existing_device->raid_bypass_enabled = new_device->raid_bypass_enabled; + existing_device->device_offline = false; /* To prevent this from being freed later. */ new_device->raid_map = NULL; @@ -2589,10 +2590,9 @@ static inline void pqi_take_device_offline(struct scsi_device *sdev, char *path) return; device->device_offline = true; - scsi_device_set_state(sdev, SDEV_OFFLINE); ctrl_info = shost_to_hba(sdev->host); pqi_schedule_rescan_worker(ctrl_info); - dev_err(&ctrl_info->pci_dev->dev, "offlined %s scsi %d:%d:%d:%d\n", + dev_err(&ctrl_info->pci_dev->dev, "re-scanning %s scsi %d:%d:%d:%d\n", path, ctrl_info->scsi_host->host_no, device->bus, device->target, device->lun); }