From patchwork Fri Dec 7 22:29:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Don Brace X-Patchwork-Id: 10718977 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B3E7C1750 for ; Fri, 7 Dec 2018 22:29:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A17632F2CF for ; Fri, 7 Dec 2018 22:29:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8F9342F2E3; Fri, 7 Dec 2018 22:29:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23E892F2CF for ; Fri, 7 Dec 2018 22:29:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726110AbeLGW3y (ORCPT ); Fri, 7 Dec 2018 17:29:54 -0500 Received: from mail-eopbgr760055.outbound.protection.outlook.com ([40.107.76.55]:36800 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726093AbeLGW3y (ORCPT ); Fri, 7 Dec 2018 17:29:54 -0500 Received: from MWHPR19CA0093.namprd19.prod.outlook.com (2603:10b6:320:1f::31) by BN6PR19MB1412.namprd19.prod.outlook.com (2603:10b6:404:126::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.20; Fri, 7 Dec 2018 22:29:50 +0000 Received: from BN1BFFO11FD016.protection.gbl (2a01:111:f400:7c10::1:192) by MWHPR19CA0093.outlook.office365.com (2603:10b6:320:1f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1404.18 via Frontend Transport; Fri, 7 Dec 2018 22:29:50 +0000 Authentication-Results: spf=pass (sender IP is 208.19.100.23) smtp.mailfrom=microsemi.com; linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=bestguesspass action=none header.from=microsemi.com; Received-SPF: Pass (protection.outlook.com: domain of microsemi.com designates 208.19.100.23 as permitted sender) receiver=protection.outlook.com; client-ip=208.19.100.23; helo=AVMBX3.microsemi.net; Received: from AVMBX3.microsemi.net (208.19.100.23) by BN1BFFO11FD016.mail.protection.outlook.com (10.58.144.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.1404.13 via Frontend Transport; Fri, 7 Dec 2018 22:29:49 +0000 Received: from AVMBX2.microsemi.net (10.100.34.32) by AVMBX3.microsemi.net (10.100.34.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1531.3; Fri, 7 Dec 2018 14:29:45 -0800 Received: from [127.0.1.1] (10.238.32.34) by avmbx2.microsemi.net (10.100.34.32) with Microsoft SMTP Server id 15.1.1531.3 via Frontend Transport; Fri, 7 Dec 2018 14:29:45 -0800 Subject: [PATCH 16/20] smartpqi: correct volume status From: Don Brace To: , , , , , , , , , , , CC: Date: Fri, 7 Dec 2018 16:29:45 -0600 Message-ID: <154422178499.1218.16408444752147164193.stgit@brunhilda> In-Reply-To: <154422079293.1218.12539829857034151457.stgit@brunhilda> References: <154422079293.1218.12539829857034151457.stgit@brunhilda> User-Agent: StGit/0.19-dirty MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.23;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(136003)(376002)(39860400002)(346002)(396003)(2980300002)(189003)(199004)(81166006)(2201001)(486006)(81156014)(58126008)(8936002)(16576012)(97736004)(44832011)(8676002)(336012)(230700001)(110136005)(446003)(106002)(33716001)(68736007)(86362001)(476003)(316002)(126002)(9686003)(77096007)(356004)(11346002)(186003)(76176011)(2906002)(26005)(4326008)(106466001)(33896004)(50466002)(305945005)(5660300001)(69596002)(478600001)(53936002)(47776003)(2486003)(103116003)(23676004)(921003)(2101003)(1121003)(83996005);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR19MB1412;H:AVMBX3.microsemi.net;FPR:;SPF:Pass;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD016;1:JMJB5ipaDtCe58tZ9lZIqC5+dP7c/irxq/awRdMeNQcFmA2Tzkc+UmER4fobzzcz5sweYagdAXHGCsJH/lQGvAmctDpplnz990shuThZLhDo7U409PdHstvskBnGCGFe X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a4d6b96a-21d9-4aa9-5dc6-08d65c937fcb X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4608076)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060);SRVR:BN6PR19MB1412; X-Microsoft-Exchange-Diagnostics: 1;BN6PR19MB1412;3:BmzvXf04qb/cdAkxKKPAJ3Y9FbcTpG+1q5zOiK1AKAdmGtVdBeNXKXbDC/UYolOxgt6mKASUle7rrshcRmjowB4uzJs4eXUUh6YmqSb+78o+pOddqo8ouJ4LO87EEx9VZuh7DMy4YUfTYC3jCrs6ncjLhT3pLyGOXfPdZAVpWtx8SwmLCd+KWvJjcUPKp1HsDN0OSNThZ1p31zi7xUZgCH0cDPqIT1axYE6QBxe8xP538WikEdL09QVkqWsOnNh8g6FlE/ePyWSLXhpsQXuF4gshukQp08rPpFtmkiyfvxskNHokjhDqJvIfxwOCNgTbmzT8lqtIgHQZsuF0OzGKG1ax6vALF94SkyeOkX9GF1Y=;25:u21hS05coUkwJ8L+Thk3yC1doHt+cyNGmrempNBy8gSNa+5mh2nLuM2HNDsoEabT+x54pC9CcSGs12N72v0RPryMyCwrv8l21iN17TZMUPhOYTg4FxaqQag9YL/7sGEDBYBgsP5HyBxzqXoUNm85TekyaQ9EP48ncSmb6DmLPq+e0mRCSZQTsP3MD7ntnbUVppCWr7AaZtpSk7mxqLKCtHVZWj5FO+G+36ezupHAmlmWJwMTV8wBA0dkyahJNYg2OXCT98zikWIHMt5BoGUT2KgHVP5ywFqM5BcrORxV4p0cpoKhuA49p9g+UL65CygUYYJA+I39wLbNnzuyOUXWhw== X-MS-TrafficTypeDiagnostic: BN6PR19MB1412: X-Microsoft-Exchange-Diagnostics: 1;BN6PR19MB1412;31:8eY2nN2SMJbONpQMMFO4wDHs2pmsfYY7Lj55HA9viwzgw4Vn0sSB4smgwqXjXrkym8vaYTu7mHTWHManeRUYc7tA7Ewhn0EPdkPYn7tRD3CWNzs7SFo78DcMNvUf2xQkmd/NQSDmoZ5ESWdyZeUg7r63mLG4KV3vjlJyAMfpTXZPzQyvZ5BO0Bfq4yI28a5KTO9chWJz/oevN9yJR74Ng8t+/dzpJHpr+GtdQSqnExo=;20:CZvxA1Pwci4PAMEYTKRbTRaGLT/kpmZGFo3YmeG4R9xEx3bO9RC4aswc3Y+ZUJtUuU9M7c6010zfNu41CIbBmkM91Fwtc8n8ylOexqPm+gOz5bbXA1R49czzqJGan5XbL5Y+OkDmQS5Rkxj7mLeXunD3OuwXU2FKHiJD9HsUa3XPI7O7gpT9f7CWV5gG0TZU9al/RNPpir8EcJ/km3cJzGVCYVsBdAD3A1kTFFLJF9eeAZ9M0sh4SrtFEsJjoO4JWeApXyKuEvSt+64c7sgE+OPM7mdXblh1Wcf2SZ994PV06aOu6h38PQZ5wjdYXFUMZMMqqZsCSovdlQFHUg3S5S4u12AyRgDW7sVLsSO7RV71HJbESnB/pTfJYe3VAZ6/ucdH8rEZqUjBhl1xOOVKQ6NgMultvTjaH+uJXCj1AaGTKtAvyKYPgxDnbkxcOaOF9pYk0kAIAVPWXulSTPtZ6Xe7ewOx4zRyDaQpQORQ6BwaXi1o73B5ucwXBaNZhYiMCcCJeGHeHxPQAgWjO2GJ0s9HUusK78sICz+ndQskSpLNR8ui6p+FdBoFCNrGIMv2Co+poHppqIj35CGkU+0nxRFtT/LlA19Wxqgtb/ss3yE= X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93004095)(3231455)(999002)(944501520)(52105112)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201708071742011)(7699051)(76991095);SRVR:BN6PR19MB1412;BCL:0;PCL:0;RULEID:;SRVR:BN6PR19MB1412; X-Microsoft-Exchange-Diagnostics: 1;BN6PR19MB1412;4:E5z6wujXSVYMF/pxAclkSoavFqic/iwV4bQ8ofE2b2udHPtPYNXCw2rhXuBgjmfBTR7IEvTMEueoHNooCBJMTJquOVDtyzRZM2b5jNIO4jcRVoU1O0Ahn/r0Eey5UHHDIaNYNiERb03plMlCrfrBHIoNw4QONho6SDEI10XFOhD90UGJ17FafDTxxdx1qe01Rv5RSa1W//esAJ3rrckbu5a6JBphdctQLi6xFd1gdmnWBsjFhU3sFef5wdKvNrWl2vf06/FTVF7simPGfzsauA== X-Forefront-PRVS: 0879599414 X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BBN6PR19MB1412=3B23=3Arin0aJC?= =?utf-8?q?/Yc3UfBLaS9hzj1jUNsXn/A3iDuZVlkBBRKMTCZPSwW93LBgYRAB/MtpxqbjYoQHo?= =?utf-8?q?pVz88eBnX/0QYNb311uGblTF7kf9BymwD9l1KRlB2UTJ4eKc6M/Pp9dPvtPB4LGg7?= =?utf-8?q?HzBEEDnJGo3NgzoNVitVjK7TULTeG2MiHu5Sb3Slv7JTqfn+L3GTBUi9oyDbFt+d1?= =?utf-8?q?XSMBlfBZxY/HZQVULZwW2vxsAVW5eIud0pn3c82ruUFdrxIW7HyXftdwyHMCiFq1D?= =?utf-8?q?Y40PN6ukqHTRRRvgFH5Uueycnp4Rok1CCMLVcNhJJrq7OUT+xCY+TG8AWg+jV7f1U?= =?utf-8?q?Mas0eEqFmEAUbhXLUSRhVNqab84+HXKXsyKYqbZftsYJ3BrIihpdpLNFs9utgV3Fv?= =?utf-8?q?A0Z4Gihz+NKpOpb0xyCP2H4Xk5GVOUq4vtdQQ5jqIdcECY5fY+eCptL8p54Cw+bFm?= =?utf-8?q?WXJOO1rx9UvtiqcyETdMqXiVJQGNR+P7TKJNvmjDIoY0lg6IKObubtrbcJ1jE+NEG?= =?utf-8?q?RU8lO+aq7Tn+ZOnsKs+TLTnw8qaEO5YSSZXcPpeHjExBIT14IBJBI9+3Izt7fovRc?= =?utf-8?q?U8oqBa1RK2DgynzYCpCksh38y1KHu8Jig8eAFEmdDTH6ufuGFkqs5vMQVEDUlatkC?= =?utf-8?q?X1kVLqr6TaDdFg9sZkry8aXyFYScSMgkiIz36dzu5JlZyxZPCVHCmfpUYbKZqTAjj?= =?utf-8?q?Y3T7655NJKEmzQg8urty//2xIGdIj3emXo/0etMw9ciOK1t2P0WH80Da87d0933lh?= =?utf-8?q?uDeOsCdkl9/Ptv5MMborNT4eAcUyhayU0Kzg6DABnOvdGmgKkmV8OQkm3wJMf1Qbo?= =?utf-8?q?e9K/6JbdRpfexjiT2SnOwvLTjJcohxW9DKrQasq/29kQ/4SA2HhTtpMVnxF7fsHnn?= =?utf-8?q?/lJomdnJJlmdGHPYU0YTELQk47sZJwoTt17og4cz2zG8bA27cCWpB8LR2yVsR2NBA?= =?utf-8?q?HmU40JDOtr44ynlhdo6oYItWHdkoYONLo+hPTiyFdOeF6wJach+l7vqA+bBV+DWkF?= =?utf-8?q?fIPiis6X/+X4w1N/X1P7oTe/UpxcvcNxh6AwLUaV3oH88dcjUgHiPweBaywgcMZae?= =?utf-8?q?LxwtX0jgKw2TjMXBbryX0zmwzt/vTJNAOyC/muKMjwnIaAtlvE7Ncg419qkPa7gSB?= =?utf-8?q?p24osWJi20VZRSpw7CSi2BIBfP54CE/TGRzxtXX?= X-Microsoft-Antispam-Message-Info: rmpkpTgrimkPMYuaYldioZn/SMuEa3SX9PNBplBIRtBMhCKiIR6pr1aJaPGZCGaFEhjPEhes+VyxBxifuURlixUgSvLILCiutoNq4uJ9L3pf4kr87AaH7phdfbwBtizAivQdn3fTXnaDIDtxJI+05DoKife70pApks6i46eCeUybpN5N+lGyQLeTDh+hbjfzSNfskkjhfS42oElszTnmxBpRazRNar1D5G7kMTGag6dM185Yu7QEmyjTKR8Li2aIbZS0U6eGqCZsOheqsKF41nqE4r560rSTTMtdwBGZeVUk8ik+D1FcaZp6epcEIWniKsZzWyV/x8HD5AQVKO3wXbqHrhvuvB8ua5RAKhnf9rk= X-Microsoft-Exchange-Diagnostics: 1;BN6PR19MB1412;6:k1rlIwVRjk/cQ2HYjxCuArYafP6ayMEFYb7Q1S+k2YbX9er5HseLXMzQJ7XGw7qaKpDHZX5HobhRbnc76BVUhUuQ4BpOatIKHCAEcDobB2E/gPqQa5vEMyRLCOpeOxaWPEdAZYLsLsYGCe6cBBB9uiKO16ZJm2zLhe3irBzqFgY84lyxZLiQktWSogx+9wxzTsMdEmHHj4YFx1k7uXwA3Ow2/XStV9WnM60VXQ/wh3J3LtikKQ90VTL0My0dIfhXV/w53jTqyBUais2raer1uG42G5iLT302PBa3wahnUzOz0GfEoRNlT5vHC+Hc1iVsWlo+iPFNCa+fFAvV9dLphBPorCsAUwWPe2qKT6pCfbuDqbWXJW0Iv4jJ4J1cscHrLGWYi2Xk9IZXs7vlM7kCnKaSHKRww383IITBHXKK9McInkjbb5zQcPtJeUCl38JuLpuWmyaDlhVuk9hC9o+fkQ==;5:hYL1Venh3mRL5W9ECt0uUs4F6GBga7MKK6eZUhDUB4tv9z+0x7pyrn8s0VrlrMTgzI7rJk+fBNSG9X7VtUtkDtK0ydtscpeClaPZNEANPF7IPhbTYDQB8LEYUvwdIpItMLadqEmideq7knaEjPrRJHaBNJni26hkyzKKh/kyNWA=;7:Zu4S1PnxppWQjt5S8561wS7WciO3CVuwMBgZynMa5tP/C2x4/8fGMtD+RZYe6TQi9xIazqugw9fHf7HLI3WgSFyD1ShAqXNQR//Jei3f5R6YEYb6bcBmL1a4rmpVXLEdPCsCq6//f/eH5NCsHS32qQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2018 22:29:49.2079 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a4d6b96a-21d9-4aa9-5dc6-08d65c937fcb X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad;Ip=[208.19.100.23];Helo=[AVMBX3.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR19MB1412 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dave Carroll - fix race condition when a unit is deleted after an RLL, and before we have gotten the LV_STATUS page of the unit. - In this case we will get a standard inquiry, rather than the desired page. This will result in a unit presented which no longer exists. - If we ask for LV_STATUS, insure we get LV_STATUS Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index f146ebf3921f..bee14fc8a35e 100644 --- a/drivers/scsi/smartpqi/smartpqi_init.c +++ b/drivers/scsi/smartpqi/smartpqi_init.c @@ -1270,6 +1270,9 @@ static void pqi_get_volume_status(struct pqi_ctrl_info *ctrl_info, if (rc) goto out; + if (vpd->page_code != CISS_VPD_LV_STATUS) + goto out; + page_length = offsetof(struct ciss_vpd_logical_volume_status, volume_status) + vpd->page_length; if (page_length < sizeof(*vpd))