diff mbox series

scsi: ufs: Fix geometry descriptor size

Message ID 1547119886-7972-1-git-send-email-avri.altman@wdc.com (mailing list archive)
State Mainlined
Commit 9be9db9f78f52ef03ee90063730cb9d730e7032b
Headers show
Series scsi: ufs: Fix geometry descriptor size | expand

Commit Message

Avri Altman Jan. 10, 2019, 11:31 a.m. UTC
Albeit we no longer rely on those hard-coded descriptor sizes, we still
use them as our defaults, so better get it right. While adding its sysfs
entries, we forgot to update the geometry descriptor size. It is 0x48
according to UFS2.1, and wasn't change in UFS3.0.

fixes: c720c091222e (scsi: ufs: sysfs: geometry descriptor)

Signed-off-by: Avri Altman <avri.altman@wdc.com>
---
 drivers/scsi/ufs/ufs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen Jan. 12, 2019, 3:30 a.m. UTC | #1
Avri,

> Albeit we no longer rely on those hard-coded descriptor sizes, we still
> use them as our defaults, so better get it right. While adding its sysfs
> entries, we forgot to update the geometry descriptor size. It is 0x48
> according to UFS2.1, and wasn't change in UFS3.0.

Applied to 5.0/scsi-fixes, thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h
index dd65fea..6d17681 100644
--- a/drivers/scsi/ufs/ufs.h
+++ b/drivers/scsi/ufs/ufs.h
@@ -195,7 +195,7 @@  enum ufs_desc_def_size {
 	QUERY_DESC_CONFIGURATION_DEF_SIZE	= 0x90,
 	QUERY_DESC_UNIT_DEF_SIZE		= 0x23,
 	QUERY_DESC_INTERCONNECT_DEF_SIZE	= 0x06,
-	QUERY_DESC_GEOMETRY_DEF_SIZE		= 0x44,
+	QUERY_DESC_GEOMETRY_DEF_SIZE		= 0x48,
 	QUERY_DESC_POWER_DEF_SIZE		= 0x62,
 	QUERY_DESC_HEALTH_DEF_SIZE		= 0x25,
 };