diff mbox series

scsi: libcxgbi: add a check for NULL pointer in cxgbi_check_route()

Message ID 1558536055-5974-1-git-send-email-varun@chelsio.com (mailing list archive)
State Mainlined
Commit cc555759117e8349088e0c5d19f2f2a500bafdbd
Headers show
Series scsi: libcxgbi: add a check for NULL pointer in cxgbi_check_route() | expand

Commit Message

Varun Prakash May 22, 2019, 2:40 p.m. UTC
ip_dev_find() can return NULL so add a check for
NULL pointer.

Signed-off-by: Varun Prakash <varun@chelsio.com>
---
 drivers/scsi/cxgbi/libcxgbi.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Martin K. Petersen May 30, 2019, 1:49 a.m. UTC | #1
Varun,

> ip_dev_find() can return NULL so add a check for NULL pointer.

Applied to 5.2/scsi-fixes. Thanks!
diff mbox series

Patch

diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index 8b915d4..7d43e01 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -639,6 +639,10 @@  cxgbi_check_route(struct sockaddr *dst_addr, int ifindex)
 
 	if (ndev->flags & IFF_LOOPBACK) {
 		ndev = ip_dev_find(&init_net, daddr->sin_addr.s_addr);
+		if (!ndev) {
+			err = -ENETUNREACH;
+			goto rel_neigh;
+		}
 		mtu = ndev->mtu;
 		pr_info("rt dev %s, loopback -> %s, mtu %u.\n",
 			n->dev->name, ndev->name, mtu);