diff mbox series

[3/3] scsi: qla4xxx: remove set but not used variables 'sess','dst_addr','db_base','db_len','ha'

Message ID 1566481681-92765-4-git-send-email-zhengbin13@huawei.com (mailing list archive)
State Deferred
Headers show
Series scsi: qla4xxx: remove some set but not used variables | expand

Commit Message

Zheng Bin Aug. 22, 2019, 1:48 p.m. UTC 
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/qla4xxx/ql4_os.c: In function qla4xxx_eh_cmd_timed_out:
drivers/scsi/qla4xxx/ql4_os.c:1848:24: warning: variable sess set but not used [-Wunused-but-set-variable]
drivers/scsi/qla4xxx/ql4_os.c: In function qla4xxx_session_create:
drivers/scsi/qla4xxx/ql4_os.c:3062:19: warning: variable dst_addr set but not used [-Wunused-but-set-variable]
drivers/scsi/qla4xxx/ql4_os.c: In function qla4_8xxx_iospace_config:
drivers/scsi/qla4xxx/ql4_os.c:5496:44: warning: variable db_len set but not used [-Wunused-but-set-variable]
drivers/scsi/qla4xxx/ql4_os.c: In function qla4_8xxx_iospace_config:
drivers/scsi/qla4xxx/ql4_os.c:5496:35: warning: variable db_base set but not used [-Wunused-but-set-variable]
drivers/scsi/qla4xxx/ql4_os.c: In function qla4xxx_get_param_ddb:
drivers/scsi/qla4xxx/ql4_os.c:6253:24: warning: variable ha set but not used [-Wunused-but-set-variable]

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 drivers/scsi/qla4xxx/ql4_os.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

--
2.7.4
diff mbox series

Patch

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 8c674ec..49c87b0 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -1845,12 +1845,10 @@  static void qla4xxx_conn_get_stats(struct iscsi_cls_conn *cls_conn,
 static enum blk_eh_timer_return qla4xxx_eh_cmd_timed_out(struct scsi_cmnd *sc)
 {
 	struct iscsi_cls_session *session;
-	struct iscsi_session *sess;
 	unsigned long flags;
 	enum blk_eh_timer_return ret = BLK_EH_DONE;

 	session = starget_to_session(scsi_target(sc->device));
-	sess = session->dd_data;

 	spin_lock_irqsave(&session->lock, flags);
 	if (session->state == ISCSI_SESSION_FAILED)
@@ -3059,7 +3057,6 @@  qla4xxx_session_create(struct iscsi_endpoint *ep,
 	struct ddb_entry *ddb_entry;
 	uint16_t ddb_index;
 	struct iscsi_session *sess;
-	struct sockaddr *dst_addr;
 	int ret;

 	if (!ep) {
@@ -3068,7 +3065,6 @@  qla4xxx_session_create(struct iscsi_endpoint *ep,
 	}

 	qla_ep = ep->dd_data;
-	dst_addr = (struct sockaddr *)&qla_ep->dst_addr;
 	ha = to_qla_host(qla_ep->host);
 	DEBUG2(ql4_printk(KERN_INFO, ha, "%s: host: %ld\n", __func__,
 			  ha->host_no));
@@ -5493,7 +5489,7 @@  static void qla4xxx_free_adapter(struct scsi_qla_host *ha)
 int qla4_8xxx_iospace_config(struct scsi_qla_host *ha)
 {
 	int status = 0;
-	unsigned long mem_base, mem_len, db_base, db_len;
+	unsigned long mem_base, mem_len;
 	struct pci_dev *pdev = ha->pdev;

 	status = pci_request_regions(pdev, DRIVER_NAME);
@@ -5537,9 +5533,6 @@  int qla4_8xxx_iospace_config(struct scsi_qla_host *ha)
 				    ((uint8_t *)ha->nx_pcibase);
 	}

-	db_base = pci_resource_start(pdev, 4);  /* doorbell is on bar 4 */
-	db_len = pci_resource_len(pdev, 4);
-
 	return 0;
 iospace_error_exit:
 	return -ENOMEM;
@@ -6250,14 +6243,12 @@  static int qla4xxx_setup_boot_info(struct scsi_qla_host *ha)
 static void qla4xxx_get_param_ddb(struct ddb_entry *ddb_entry,
 				  struct ql4_tuple_ddb *tddb)
 {
-	struct scsi_qla_host *ha;
 	struct iscsi_cls_session *cls_sess;
 	struct iscsi_cls_conn *cls_conn;
 	struct iscsi_session *sess;
 	struct iscsi_conn *conn;

 	DEBUG2(printk(KERN_INFO "Func: %s\n", __func__));
-	ha = ddb_entry->ha;
 	cls_sess = ddb_entry->sess;
 	sess = cls_sess->dd_data;
 	cls_conn = ddb_entry->conn;