| Message ID | 1570183477-137273-1-git-send-email-zhengbin13@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | f7cb0d0945ebc9879aff72cf7b3342fd1040ffaa |
| Headers | show |
| Series | scsi: lpfc: Make function lpfc_defer_pt2pt_acc static | expand |
On 10/4/2019 5:46 AM, Dick Kennedy wrote: > Looks Good. > ACK > > On Fri, Oct 4, 2019 at 5:58 AM zhengbin <zhengbin13@huawei.com > <mailto:zhengbin13@huawei.com>> wrote: > > Fix sparse warnings: > > drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: symbol > 'lpfc_defer_pt2pt_acc' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com <mailto:hulkci@huawei.com>> > Signed-off-by: zhengbin <zhengbin13@huawei.com > <mailto:zhengbin13@huawei.com>> > --- > drivers/scsi/lpfc/lpfc_nportdisc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dick Kennedy <dick.kennedy@broadcom.com> Reviewed-by: James Smart <james.smart@broadcom.com> Thanks! -- james
zhengbin,
> drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: symbol 'lpfc_defer_pt2pt_acc' was not declared. Should it be static?
Applied to 5.5/scsi-queue, thanks!
diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c index 4e96d28..cc6b1b0 100644 --- a/drivers/scsi/lpfc/lpfc_nportdisc.c +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c @@ -286,7 +286,7 @@ lpfc_els_abort(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp) * This routine is only called if we are SLI3, direct connect pt2pt * mode and the remote NPort issues the PLOGI after link up. */ -void +static void lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox) { LPFC_MBOXQ_t *login_mbox;
Fix sparse warnings: drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: symbol 'lpfc_defer_pt2pt_acc' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: zhengbin <zhengbin13@huawei.com> --- drivers/scsi/lpfc/lpfc_nportdisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4