From patchwork Tue Oct 15 06:21:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: balsundar.p@microsemi.com X-Patchwork-Id: 11189727 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5F81314DB for ; Tue, 15 Oct 2019 06:18:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4AF4021925 for ; Tue, 15 Oct 2019 06:18:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbfJOGSa (ORCPT ); Tue, 15 Oct 2019 02:18:30 -0400 Received: from esa1.microchip.iphmx.com ([68.232.147.91]:42666 "EHLO esa1.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbfJOGSa (ORCPT ); Tue, 15 Oct 2019 02:18:30 -0400 Authentication-Results: esa1.microchip.iphmx.com; dkim=none (message not signed) header.i=none; spf=Pass smtp.mailfrom=balsundar.p@microsemi.com; spf=None smtp.helo=postmaster@smtp.microsemi.com Received-SPF: Pass (esa1.microchip.iphmx.com: domain of balsundar.p@microsemi.com designates 208.19.100.22 as permitted sender) identity=mailfrom; client-ip=208.19.100.22; receiver=esa1.microchip.iphmx.com; envelope-from="balsundar.p@microsemi.com"; x-sender="balsundar.p@microsemi.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:208.19.100.20 ip4:208.19.100.21 ip4:208.19.100.22 ip4:208.19.100.23 ip4:208.19.99.221 ip4:208.19.99.222 ip4:208.19.99.223 ip4:208.19.99.225 -all" Received-SPF: None (esa1.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@smtp.microsemi.com) identity=helo; client-ip=208.19.100.22; receiver=esa1.microchip.iphmx.com; envelope-from="balsundar.p@microsemi.com"; x-sender="postmaster@smtp.microsemi.com"; x-conformance=spf_only X-Ironport-Dmarc-Check-Result: validskip IronPort-SDR: PEQaHNyur5+xm1EjZJgPjMEYsL19g3ZVy6HhQGVFkpc767C3txaxrYreXu8rEaTerPj7jLxPSe kE7w+1o6MIdFf50zhgT45MsJDnbo8qAigNqYrK7ZGiSm2A31uFtkfosvSy4nCv2tYlt590iOy9 LLFCLa7bms5btWCmh0B7QDJa9jbul3sPPEnM34872Xf/mUWuuWAnt0xI17/dAOA7JqP4pZ9isP 1CP14OX4BmMT33cUwbu+4pI/BBlq+bvGaWDBmwupkA5ZMuUZrUV8WbeRdDASqU+q9rC01gEm38 KMM= X-IronPort-AV: E=Sophos;i="5.67,298,1566889200"; d="scan'208";a="54210866" Received: from unknown (HELO smtp.microsemi.com) ([208.19.100.22]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 Oct 2019 23:18:24 -0700 Received: from AVMBX3.microsemi.net (10.100.34.33) by AVMBX2.microsemi.net (10.100.34.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Oct 2019 23:18:15 -0700 Received: from localhost (10.41.130.77) by avmbx3.microsemi.net (10.100.34.33) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Mon, 14 Oct 2019 23:18:14 -0700 From: To: , CC: Subject: [PATCH 2/7] scsi: aacraid: fixed IO reporting error Date: Tue, 15 Oct 2019 11:51:59 +0530 Message-ID: <1571120524-6037-3-git-send-email-balsundar.p@microsemi.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1571120524-6037-1-git-send-email-balsundar.p@microsemi.com> References: <1571120524-6037-1-git-send-email-balsundar.p@microsemi.com> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org From: Balsundar P The problem is the driver detects FastResponse bit set and saves it to Fib's flags for not to check IO response status, but it never clear it for next IO. Hence the next IO will pick up FastResponse bit and not to check the IO response status and fail to report any type IO error to kernel Signed-off-by: Balsundar P --- drivers/scsi/aacraid/commsup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c index 2142a649e865..3f268f669cc3 100644 --- a/drivers/scsi/aacraid/commsup.c +++ b/drivers/scsi/aacraid/commsup.c @@ -232,6 +232,7 @@ struct fib *aac_fib_alloc_tag(struct aac_dev *dev, struct scsi_cmnd *scmd) fibptr->type = FSAFS_NTC_FIB_CONTEXT; fibptr->callback_data = NULL; fibptr->callback = NULL; + fibptr->flags = 0; return fibptr; }