diff mbox series

scsi:pmcraid:Replace dma_pool_malloc with dma_pool_zalloc

Message ID 1587197241-274646-1-git-send-email-wubo40@huawei.com (mailing list archive)
State Mainlined
Commit f8f794a15adcea250c85cfa51716d09b03507375
Headers show
Series scsi:pmcraid:Replace dma_pool_malloc with dma_pool_zalloc | expand

Commit Message

Wu Bo April 18, 2020, 8:07 a.m. UTC
Replace dma_pool_malloc with dma_pool_zalloc to make the code more concise
in pmcraid_allocate_control_blocks() function.

Signed-off-by: Wu Bo <wubo40@huawei.com>
---
 drivers/scsi/pmcraid.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Wu Bo April 22, 2020, 6:15 a.m. UTC | #1
friendly ping...

On 2020/4/18 16:07, Wu Bo wrote:
> Replace dma_pool_malloc with dma_pool_zalloc to make the code more concise
> in pmcraid_allocate_control_blocks() function.
> 
> Signed-off-by: Wu Bo <wubo40@huawei.com>
> ---
>   drivers/scsi/pmcraid.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index 7eb88fe..aa9ae2a 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4652,7 +4652,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
>   
>   	for (i = 0; i < PMCRAID_MAX_CMD; i++) {
>   		pinstance->cmd_list[i]->ioa_cb =
> -			dma_pool_alloc(
> +			dma_pool_zalloc(
>   				pinstance->control_pool,
>   				GFP_KERNEL,
>   				&(pinstance->cmd_list[i]->ioa_cb_bus_addr));
> @@ -4661,8 +4661,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
>   			pmcraid_release_control_blocks(pinstance, i);
>   			return -ENOMEM;
>   		}
> -		memset(pinstance->cmd_list[i]->ioa_cb, 0,
> -			sizeof(struct pmcraid_control_block));
>   	}
>   	return 0;
>   }
>
Martin K. Petersen April 27, 2020, 8:21 p.m. UTC | #2
On Sat, 18 Apr 2020 16:07:21 +0800, Wu Bo wrote:

> Replace dma_pool_malloc with dma_pool_zalloc to make the code more concise
> in pmcraid_allocate_control_blocks() function.

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: pmcraid: Replace dma_pool_malloc with dma_pool_zalloc
      https://git.kernel.org/mkp/scsi/c/f8f794a15adc
diff mbox series

Patch

diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 7eb88fe..aa9ae2a 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4652,7 +4652,7 @@  static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
 
 	for (i = 0; i < PMCRAID_MAX_CMD; i++) {
 		pinstance->cmd_list[i]->ioa_cb =
-			dma_pool_alloc(
+			dma_pool_zalloc(
 				pinstance->control_pool,
 				GFP_KERNEL,
 				&(pinstance->cmd_list[i]->ioa_cb_bus_addr));
@@ -4661,8 +4661,6 @@  static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
 			pmcraid_release_control_blocks(pinstance, i);
 			return -ENOMEM;
 		}
-		memset(pinstance->cmd_list[i]->ioa_cb, 0,
-			sizeof(struct pmcraid_control_block));
 	}
 	return 0;
 }