diff mbox series

[-next,v2] scsi: aacraid: Use memdup_user() as a cleanup

Message ID 1587868964-75969-1-git-send-email-zou_wei@huawei.com (mailing list archive)
State Mainlined
Commit 8d925b1f00e6894e4c601cb1d395dab3bd66c374
Headers show
Series [-next,v2] scsi: aacraid: Use memdup_user() as a cleanup | expand

Commit Message

Zou Wei April 26, 2020, 2:42 a.m. UTC
Fix coccicheck warning which recommends to use memdup_user().

This patch fixes the following coccicheck warning:

drivers/scsi/aacraid/commctrl.c:516:15-22: WARNING opportunity for memdup_user

Fixes: 4645df1035b3 ("[PATCH] aacraid: swapped kmalloc args.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/scsi/aacraid/commctrl.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

Comments

Martin K. Petersen May 12, 2020, 3:28 a.m. UTC | #1
On Sun, 26 Apr 2020 10:42:44 +0800, Zou Wei wrote:

> Fix coccicheck warning which recommends to use memdup_user().
> 
> This patch fixes the following coccicheck warning:
> 
> drivers/scsi/aacraid/commctrl.c:516:15-22: WARNING opportunity for memdup_user

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: aacraid: Use memdup_user() as a cleanup
      https://git.kernel.org/mkp/scsi/c/8d925b1f00e6
diff mbox series

Patch

diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
index ffe41bc..102658b 100644
--- a/drivers/scsi/aacraid/commctrl.c
+++ b/drivers/scsi/aacraid/commctrl.c
@@ -513,15 +513,9 @@  static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg)
 		goto cleanup;
 	}
 
-	user_srbcmd = kmalloc(fibsize, GFP_KERNEL);
-	if (!user_srbcmd) {
-		dprintk((KERN_DEBUG"aacraid: Could not make a copy of the srb\n"));
-		rcode = -ENOMEM;
-		goto cleanup;
-	}
-	if(copy_from_user(user_srbcmd, user_srb,fibsize)){
-		dprintk((KERN_DEBUG"aacraid: Could not copy srb from user\n"));
-		rcode = -EFAULT;
+	user_srbcmd = memdup_user(user_srb, fibsize);
+	if (IS_ERR(user_srbcmd)) {
+		rcode = PTR_ERR(user_srbcmd);
 		goto cleanup;
 	}