scsi: fnic: use eth_broadcast_addr() to assign broadcast address

Commit Message

Miaohe Lin July 20, 2020, 8:24 a.m. UTC

From: Miaohe Lin <[e-mail]>

Use eth_broadcast_addr() to assign broadcast address insetad of memset().

Signed-off-by: Miaohe Lin <[e-mail]>
---
 drivers/scsi/fnic/fnic_scsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Martin K. Petersen July 25, 2020, 2:50 a.m. UTC | #1

On Mon, 20 Jul 2020 16:24:58 +0800, linmiaohe wrote:

> Use eth_broadcast_addr() to assign broadcast address insetad of memset().

Applied to 5.9/scsi-queue, thanks!

[1/1] scsi: fnic: Use eth_broadcast_addr() to assign broadcast address
      https://git.kernel.org/mkp/scsi/c/51d263cbdd76

Patch

diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index 27535c90b248..03b1805b106c 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -23,6 +23,7 @@ 
 #include <linux/scatterlist.h>
 #include <linux/skbuff.h>
 #include <linux/spinlock.h>
+#include <linux/etherdevice.h>
 #include <linux/if_ether.h>
 #include <linux/if_vlan.h>
 #include <linux/delay.h>
@@ -275,7 +276,7 @@  int fnic_flogi_reg_handler(struct fnic *fnic, u32 fc_id)
 	}
 
 	if (fnic->ctlr.map_dest) {
-		memset(gw_mac, 0xff, ETH_ALEN);
+		eth_broadcast_addr(gw_mac);
 		format = FCPIO_FLOGI_REG_DEF_DEST;
 	} else {
 		memcpy(gw_mac, fnic->ctlr.dest_addr, ETH_ALEN);