| Message ID | 1595816749-108744-1-git-send-email-kwmad.kim@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v1] ufs: fix a bug of wrong usage of test_and_set_bit | expand |
> > Just a number should have been used, not a shifted value. > > Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com> Reviewed-by: Avri Altman <avri.altman@wdc.com> Sorry for not catching this earlier. Thanks, Avri > --- > drivers/scsi/ufs/ufs-exynos.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h > index a91656c..032bb50 100644 > --- a/drivers/scsi/ufs/ufs-exynos.h > +++ b/drivers/scsi/ufs/ufs-exynos.h > @@ -216,7 +216,7 @@ struct exynos_ufs { > > struct ufs_exynos_handle handle; > unsigned long dbg_flag; > -#define EXYNOS_UFS_DBG_DUMP_CXT BIT(0) > +#define EXYNOS_UFS_DBG_DUMP_CXT 0 > }; > > #define for_each_ufs_rx_lane(ufs, i) \ > -- > 2.7.4
diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h index a91656c..032bb50 100644 --- a/drivers/scsi/ufs/ufs-exynos.h +++ b/drivers/scsi/ufs/ufs-exynos.h @@ -216,7 +216,7 @@ struct exynos_ufs { struct ufs_exynos_handle handle; unsigned long dbg_flag; -#define EXYNOS_UFS_DBG_DUMP_CXT BIT(0) +#define EXYNOS_UFS_DBG_DUMP_CXT 0 }; #define for_each_ufs_rx_lane(ufs, i) \
Just a number should have been used, not a shifted value. Signed-off-by: Kiwoong Kim <kwmad.kim@samsung.com> --- drivers/scsi/ufs/ufs-exynos.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)