diff mbox series

scsi: mpt3sas: style: Simplify bool comparison

Message ID 1610355253-25960-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive)
State Accepted
Headers show
Series scsi: mpt3sas: style: Simplify bool comparison | expand

Commit Message

Abaci Team Jan. 11, 2021, 8:54 a.m. UTC
Fix the following coccicheck warning:
./drivers/scsi/mpt3sas/mpt3sas_base.c:2424:5-20: WARNING: Comparison of
0/1 to bool variable

Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Reported-by: Abaci Robot<abaci@linux.alibaba.com>
---
 drivers/scsi/mpt3sas/mpt3sas_base.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Martin K. Petersen Jan. 23, 2021, 2:55 a.m. UTC | #1
Yang,

> Fix the following coccicheck warning:
> ./drivers/scsi/mpt3sas/mpt3sas_base.c:2424:5-20: WARNING: Comparison of
> 0/1 to bool variable

Applied to 5.12/scsi-staging, thanks!
Martin K. Petersen Jan. 27, 2021, 4:54 a.m. UTC | #2
On Mon, 11 Jan 2021 16:54:13 +0800, YANG LI wrote:

> Fix the following coccicheck warning:
> ./drivers/scsi/mpt3sas/mpt3sas_base.c:2424:5-20: WARNING: Comparison of
> 0/1 to bool variable

Applied to 5.12/scsi-queue, thanks!

[1/1] scsi: mpt3sas: style: Simplify bool comparison
      https://git.kernel.org/mkp/scsi/c/bfb3f00c0613
diff mbox series

Patch

diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 6e23dc3..f5582c8 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -2505,8 +2505,8 @@  static u32 base_mod64(u64 dividend, u32 divisor)
 	}
 
 	/* Check if we need to build a native SG list. */
-	if (base_is_prp_possible(ioc, pcie_device,
-				scmd, sges_left) == 0) {
+	if (!base_is_prp_possible(ioc, pcie_device,
+				scmd, sges_left)) {
 		/* We built a native SG list, just return. */
 		goto out;
 	}