| Message ID | 1610439893-64872-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: lpfc: style: Simplify bool comparison | expand |
On 1/12/2021 12:24 AM, YANG LI wrote: > Fix the following coccicheck warning: > ./drivers/scsi/lpfc/lpfc_bsg.c:5392:5-29: WARNING: Comparison to bool > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com> > --- > drivers/scsi/lpfc/lpfc_bsg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: James Smart <james.smart@broadcom.com> -- james
On Tue, 12 Jan 2021 16:24:53 +0800, YANG LI wrote: > Fix the following coccicheck warning: > ./drivers/scsi/lpfc/lpfc_bsg.c:5392:5-29: WARNING: Comparison to bool Applied to 5.12/scsi-queue, thanks! [1/1] scsi: lpfc: style: Simplify bool comparison https://git.kernel.org/mkp/scsi/c/af0c94afc0c4
diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c index eed6ea5..b974d39 100644 --- a/drivers/scsi/lpfc/lpfc_bsg.c +++ b/drivers/scsi/lpfc/lpfc_bsg.c @@ -5376,9 +5376,9 @@ static int lpfc_bsg_check_cmd_access(struct lpfc_hba *phba, ras_fwlog = &phba->ras_fwlog; - if (ras_fwlog->ras_hwsupport == false) + if (!ras_fwlog->ras_hwsupport) return -EACCES; - else if (ras_fwlog->ras_enabled == false) + else if (!ras_fwlog->ras_enabled) return -EPERM; else return 0;
Fix the following coccicheck warning: ./drivers/scsi/lpfc/lpfc_bsg.c:5392:5-29: WARNING: Comparison to bool Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com> --- drivers/scsi/lpfc/lpfc_bsg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)