@@ -101,8 +101,7 @@ void qedf_capture_grc_dump(struct qedf_ctx *qedf)
size_t count)
{
ssize_t ret = 0;
- struct fc_lport *lport = shost_priv(dev_to_shost(container_of(kobj,
- struct device, kobj)));
+ struct fc_lport *lport = shost_priv(dev_to_shost(kobj_to_dev(kobj)));
struct qedf_ctx *qedf = lport_priv(lport);
if (test_bit(QEDF_GRCDUMP_CAPTURE, &qedf->flags)) {
@@ -130,8 +129,7 @@ void qedf_capture_grc_dump(struct qedf_ctx *qedf)
return ret;
- lport = shost_priv(dev_to_shost(container_of(kobj,
- struct device, kobj)));
+ lport = shost_priv(dev_to_shost(kobj_to_dev(kobj)));
qedf = lport_priv(lport);
buf[1] = 0;
fixed the following coccicheck: ./drivers/scsi/qedf/qedf_attr.c:105:26-27: WARNING opportunity for kobj_to_dev() ./drivers/scsi/qedf/qedf_attr.c:134:24-25: WARNING opportunity for kobj_to_dev() Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/scsi/qedf/qedf_attr.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)