| Message ID | 1623929522-4389-1-git-send-email-zou_wei@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] scsi: ufs-mediatek: Add missing of_node_put() in ufs_mtk_probe() | expand |
Hi Zou, On Thu, 2021-06-17 at 19:32 +0800, Zou Wei wrote: > The function is missing a of_node_put on node, fix this by adding the call > before returning. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/scsi/ufs/ufs-mediatek.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > index 1a517c9..d2c2516 100644 > --- a/drivers/scsi/ufs/ufs-mediatek.c > +++ b/drivers/scsi/ufs/ufs-mediatek.c > @@ -1120,6 +1120,7 @@ static int ufs_mtk_probe(struct platform_device *pdev) > if (err) > dev_info(dev, "probe failed %d\n", err); > > + of_node_put(reset_node); > return err; > } > Thanks for this fix. Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Zou, > The function is missing a of_node_put on node, fix this by adding the > call before returning. Applied to 5.14/scsi-staging, thanks!
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c index 1a517c9..d2c2516 100644 --- a/drivers/scsi/ufs/ufs-mediatek.c +++ b/drivers/scsi/ufs/ufs-mediatek.c @@ -1120,6 +1120,7 @@ static int ufs_mtk_probe(struct platform_device *pdev) if (err) dev_info(dev, "probe failed %d\n", err); + of_node_put(reset_node); return err; }
The function is missing a of_node_put on node, fix this by adding the call before returning. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zou Wei <zou_wei@huawei.com> --- drivers/scsi/ufs/ufs-mediatek.c | 1 + 1 file changed, 1 insertion(+)