diff mbox series

[02/15] Revert "scsi: hisi_sas: Filter out new PHY up events during suspend"

Message ID 1637117108-230103-3-git-send-email-chenxiang66@hisilicon.com (mailing list archive)
State Changes Requested
Headers show
Series Add runtime PM support for libsas | expand

Commit Message

chenxiang Nov. 17, 2021, 2:44 a.m. UTC 
From: John Garry <john.garry@huawei.com>

This reverts commit b14a37e011d829404c29a5ae17849d7efb034893.

In that commit, we had to filter out phy-up events during suspend, as it
work cause a deadlock between processing the phyup event and the resume
HA function try to drain the HA event workqueue to complete the resume
process.

Now that we no longer try to drain the HA event queue during the HA
resume processor, the deadlock would not occur, so remove the special
handling for it.

Signed-off-by: John Garry <john.garry@huawei.com>
---
 drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

John Garry Dec. 13, 2021, 10:31 a.m. UTC | #1 
On 17/11/2021 02:44, chenxiang wrote:
> From: John Garry<john.garry@huawei.com>
> 
> This reverts commit b14a37e011d829404c29a5ae17849d7efb034893.
> 
> In that commit, we had to filter out phy-up events during suspend, as it
> work cause a deadlock between processing the phyup event and the resume
> HA function try to drain the HA event workqueue to complete the resume
> process.
> 
> Now that we no longer try to drain the HA event queue during the HA
> resume processor, the deadlock would not occur, so remove the special
> handling for it.
> 
> Signed-off-by: John Garry<john.garry@huawei.com>

This is missing your Signed-off-by

Thanks,
John
chenxiang Dec. 15, 2021, 7:20 a.m. UTC | #2 
在 2021/12/13 18:31, John Garry 写道:
> On 17/11/2021 02:44, chenxiang wrote:
>> From: John Garry<john.garry@huawei.com>
>>
>> This reverts commit b14a37e011d829404c29a5ae17849d7efb034893.
>>
>> In that commit, we had to filter out phy-up events during suspend, as it
>> work cause a deadlock between processing the phyup event and the resume
>> HA function try to drain the HA event workqueue to complete the resume
>> process.
>>
>> Now that we no longer try to drain the HA event queue during the HA
>> resume processor, the deadlock would not occur, so remove the special
>> handling for it.
>>
>> Signed-off-by: John Garry<john.garry@huawei.com>
>
> This is missing your Signed-off-by

Ok, i will add it in next version.

>
> Thanks,
> John
>
> .
>
diff mbox series

Patch

diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index f206c433de32..305d6282845a 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -619,12 +619,6 @@  static void hisi_sas_bytes_dmaed(struct hisi_hba *hisi_hba, int phy_no,
 	if (!phy->phy_attached)
 		return;
 
-	if (test_bit(HISI_SAS_PM_BIT, &hisi_hba->flags) &&
-	    !sas_phy->suspended) {
-		dev_warn(hisi_hba->dev, "phy%d during suspend filtered out\n", phy_no);
-		return;
-	}
-
 	sas_notify_phy_event(sas_phy, PHYE_OOB_DONE, gfp_flags);
 
 	if (sas_phy->phy) {