| Message ID | 1700629624-23571-1-git-send-email-quic_ziqichen@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] dt-bindings: ufs: Add msi-parent for UFS MCQ | expand |
On 22/11/2023 06:06, Ziqi Chen wrote: > The Message Signaled Interrupts (MSI) support has been > introduced in UFSHCI version 4.0 (JESD223E). The MSI is > the recommended interrupt approach for MCQ. If choose to > use MSI, In UFS DT, we need to provide msi-parent property > that point to the hardware entity which serves as the MSI > controller for this UFS controller. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 11/21/23 21:06, Ziqi Chen wrote: > diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml > index 985ea8f..31fe7f3 100644 > --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml > +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml > @@ -87,6 +87,8 @@ properties: > description: > Specifies max. load that can be drawn from VCCQ2 supply. > > + msi-parent: true > + > dependencies: > freq-table-hz: [ clocks ] > operating-points-v2: [ clocks, clock-names ] Does this patch break support for UFSHCI 4.0 controllers that do not support MSI? Thanks, Bart.
On 11/23/2023 1:53 AM, Bart Van Assche wrote: > On 11/21/23 21:06, Ziqi Chen wrote: >> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml >> b/Documentation/devicetree/bindings/ufs/ufs-common.yaml >> index 985ea8f..31fe7f3 100644 >> --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml >> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml >> @@ -87,6 +87,8 @@ properties: >> description: >> Specifies max. load that can be drawn from VCCQ2 supply. >> + msi-parent: true >> + >> dependencies: >> freq-table-hz: [ clocks ] >> operating-points-v2: [ clocks, clock-names ] > > Does this patch break support for UFSHCI 4.0 controllers that do not > support MSI? No, the controllers that do not support MSI would NOT be impacted by this patch. -Ziqi > > Thanks, > > Bart.
Thank you , will re-wrap commit message. -Ziqi On 11/22/2023 3:39 PM, Krzysztof Kozlowski wrote: > On 22/11/2023 06:06, Ziqi Chen wrote: >> The Message Signaled Interrupts (MSI) support has been >> introduced in UFSHCI version 4.0 (JESD223E). The MSI is >> the recommended interrupt approach for MCQ. If choose to >> use MSI, In UFS DT, we need to provide msi-parent property >> that point to the hardware entity which serves as the MSI >> controller for this UFS controller. > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml index 985ea8f..31fe7f3 100644 --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml @@ -87,6 +87,8 @@ properties: description: Specifies max. load that can be drawn from VCCQ2 supply. + msi-parent: true + dependencies: freq-table-hz: [ clocks ] operating-points-v2: [ clocks, clock-names ]
The Message Signaled Interrupts (MSI) support has been introduced in UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt approach for MCQ. If choose to use MSI, In UFS DT, we need to provide msi-parent property that point to the hardware entity which serves as the MSI controller for this UFS controller. Signed-off-by: Ziqi Chen <quic_ziqichen@quicinc.com> Changes to v1: - Rebased on Linux 6.7-rc1. - Updated the commit message to incorporate the details about when MCQ/MSI got introduced. --- Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++ 1 file changed, 2 insertions(+)