scsi:ufs:core: update compl_time_stamp_local_clock after complete a cqe

Commit Message

liuderong Dec. 4, 2024, 11:50 a.m. UTC

From: liuderong <[e-mail]>

For now, lrbp->compl_time_stamp_local_clock is set to zero
after send a sqe, but it is not updated after complete a cqe,
the printed information in ufshcd_print_tr will always be zero.
So update lrbp->cmpl_time_stamp_local_clock after complete a cqe.

Log sample:
ufshcd-qcom 1d84000.ufshc: UPIU[8] - issue time 8750227249 us
ufshcd-qcom 1d84000.ufshc: UPIU[8] - complete time 0 us

Signed-off-by: liuderong <[e-mail]>
---
 drivers/ufs/core/ufshcd.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Bean Huo Dec. 4, 2024, 12:50 p.m. UTC | #1

On Wed, 2024-12-04 at 19:50 +0800, [e-mail] wrote:
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 6a26853..bd70fe1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5519,6 +5519,7 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,
> int task_tag,
>  
>         lrbp = &hba->lrb[task_tag];
>         lrbp->compl_time_stamp = ktime_get();
> +       lrbp->compl_time_stamp_local_clock = local_clock();

probably, we should change lrbp->compl_time_stamp = ktime_get(); to
lrbp->compl_time_stamp = local_clock(); also, the name of
compl_time_stamp_local_clock, is so long, should be shorter. 


but the patch is ok to me:

Reviewed-by: Bean Huo <[e-mail]>

Patch

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 6a26853..bd70fe1 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -5519,6 +5519,7 @@  void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
 
 	lrbp = &hba->lrb[task_tag];
 	lrbp->compl_time_stamp = ktime_get();
+	lrbp->compl_time_stamp_local_clock = local_clock();
 	cmd = lrbp->cmd;
 	if (cmd) {
 		if (unlikely(ufshcd_should_inform_monitor(hba, lrbp)))