diff mbox series

[-next] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value

Message ID 1740552733-182527-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive)
State Accepted
Headers show
Series [-next] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value | expand

Commit Message

Shawn Lin Feb. 26, 2025, 6:52 a.m. UTC
A positive value is for the number of clocks obtained if assigned.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/ufs/host/ufs-rockchip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin K. Petersen March 4, 2025, 2:12 a.m. UTC | #1
Shawn,

> A positive value is for the number of clocks obtained if assigned.

Applied to 6.15/scsi-staging, thanks!
Martin K. Petersen March 11, 2025, 1:19 a.m. UTC | #2
On Wed, 26 Feb 2025 14:52:13 +0800, Shawn Lin wrote:

> A positive value is for the number of clocks obtained if assigned.
> 
> 

Applied to 6.15/scsi-queue, thanks!

[1/1] scsi: ufs: rockchip: Fix devm_clk_bulk_get_all_enabled return value
      https://git.kernel.org/mkp/scsi/c/4fffffd3b134
diff mbox series

Patch

diff --git a/drivers/ufs/host/ufs-rockchip.c b/drivers/ufs/host/ufs-rockchip.c
index 5b0ea98..c4d561f 100644
--- a/drivers/ufs/host/ufs-rockchip.c
+++ b/drivers/ufs/host/ufs-rockchip.c
@@ -171,7 +171,7 @@  static int ufs_rockchip_common_init(struct ufs_hba *hba)
 				"failed to get reset gpio\n");
 
 	err = devm_clk_bulk_get_all_enabled(dev, &host->clks);
-	if (err)
+	if (err < 0)
 		return dev_err_probe(dev, err, "failed to enable clocks\n");
 
 	host->hba = hba;