diff mbox

[1/2] libata-scsi: do not call blk_queue_max_hw_sectors()

Message ID 1dc8fff2418744a7c4bf824f789017228ac15624.1470738284.git.tom.ty89@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Tom Yan Aug. 9, 2016, 10:31 a.m. UTC
From: Tom Yan <tom.ty89@gmail.com>

We should just let the scsi driver (hosts.c) call the function. It
has better heuristic anyway (i.e. use SCSI_DEFAULT_MAX_SECTORS as
fallback when max_sectors is not set).

Comments

Tom Yan Aug. 9, 2016, 11:02 a.m. UTC | #1
Withdrawn. blk_queue_max_hw_sectors() is not called in hosts.c but in
scsi_lib.c. However, it does not check the dev->max_sectors set in
libata-core.c. So everything of this patch is wrong. Will rewrite and
resend the second patch.

On 9 August 2016 at 18:31,  <tom.ty89@gmail.com> wrote:
> From: Tom Yan <tom.ty89@gmail.com>
>
> We should just let the scsi driver (hosts.c) call the function. It
> has better heuristic anyway (i.e. use SCSI_DEFAULT_MAX_SECTORS as
> fallback when max_sectors is not set).
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 2bdb5da..495d916 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -1204,9 +1204,6 @@ static int ata_scsi_dev_config(struct scsi_device *sdev,
>         if (!ata_id_has_unload(dev->id))
>                 dev->flags |= ATA_DFLAG_NO_UNLOAD;
>
> -       /* configure max sectors */
> -       blk_queue_max_hw_sectors(q, dev->max_sectors);
> -
>         if (dev->class == ATA_DEV_ATAPI) {
>                 void *buf;
>
> --
> 2.9.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 2bdb5da..495d916 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -1204,9 +1204,6 @@  static int ata_scsi_dev_config(struct scsi_device *sdev,
 	if (!ata_id_has_unload(dev->id))
 		dev->flags |= ATA_DFLAG_NO_UNLOAD;
 
-	/* configure max sectors */
-	blk_queue_max_hw_sectors(q, dev->max_sectors);
-
 	if (dev->class == ATA_DEV_ATAPI) {
 		void *buf;