| Message ID | 201504201238.t3KCc8GM016945@palmhbs0.lsi.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/20/2015 02:35 PM, Sumit.Saxena@avagotech.com wrote: > drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static? > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > index 2424ab2..0381833 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -1695,7 +1695,7 @@ static int megasas_slave_alloc(struct scsi_device *sdev) > * @instance: Adapter soft state > * > */ > -void megasas_complete_outstanding_ioctls(struct megasas_instance *instance) > +static void megasas_complete_outstanding_ioctls(struct megasas_instance *instance) > { > int i; > struct megasas_cmd *cmd_mfi; > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
On 04/20/2015 02:35 PM, Sumit.Saxena@avagotech.com wrote: > drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static? > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Reviewed-by: Tomas Henzl <thenzl@redhat.com> Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 2424ab2..0381833 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -1695,7 +1695,7 @@ static int megasas_slave_alloc(struct scsi_device *sdev) * @instance: Adapter soft state * */ -void megasas_complete_outstanding_ioctls(struct megasas_instance *instance) +static void megasas_complete_outstanding_ioctls(struct megasas_instance *instance) { int i; struct megasas_cmd *cmd_mfi;
drivers/scsi/megaraid/megaraid_sas_base.c:1701:6: sparse: symbol 'megasas_complete_outstanding_ioctls' was not declared. Should it be static? Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)