From patchwork Thu May 21 17:03:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 6457751 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 88E199F318 for ; Thu, 21 May 2015 17:03:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 97F46204FF for ; Thu, 21 May 2015 17:03:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B33F204EC for ; Thu, 21 May 2015 17:03:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932377AbbEURDM (ORCPT ); Thu, 21 May 2015 13:03:12 -0400 Received: from verein.lst.de ([213.95.11.211]:58046 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754940AbbEURDL (ORCPT ); Thu, 21 May 2015 13:03:11 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 99B916916F; Thu, 21 May 2015 19:03:09 +0200 (CEST) Date: Thu, 21 May 2015 19:03:09 +0200 From: Christoph Hellwig To: "Nicholas A. Bellinger" Cc: Christoph Hellwig , "Nicholas A. Bellinger" , target-devel , linux-scsi , linux-kernel , Hannes Reinecke , Sagi Grimberg Subject: Re: [PATCH 01/12] target: Convert se_node_acl->device_list[] to RCU hlist Message-ID: <20150521170309.GA1172@lst.de> References: <1431422736-29125-1-git-send-email-nab@daterainc.com> <1431422736-29125-2-git-send-email-nab@daterainc.com> <20150513063555.GA21770@lst.de> <1431506771.26897.78.camel@haakon3.risingtidesystems.com> <20150517165142.GA17217@lst.de> <1431933444.24645.7.camel@haakon3.risingtidesystems.com> <20150518074102.GA6157@lst.de> <20150518080155.GA6451@lst.de> <1432015547.9093.76.camel@haakon3.risingtidesystems.com> <20150519062231.GB29468@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150519062231.GB29468@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 19, 2015 at 08:22:31AM +0200, Christoph Hellwig wrote: > On Mon, May 18, 2015 at 11:05:47PM -0700, Nicholas A. Bellinger wrote: > > > [ 12.830576] kernel BUG at ../drivers/target/target_core_device.c:337! > > > > > > > How did you hit this..? > > tcm_node --block iblock_0/array /dev/sda > > line=$(tcm_loop --createnexus=0) > wwn=$(echo $line | awk '{print $15}') > tcm_loop --addlun=$wwn 0 0 iblock_0/array And here is the fix. Seems like anything using dynamic node ACLs was broken the same way (I could reproduce it with vhost as well). I don't really like how HBA_FLAGS_INTERNAL_USE means this is a virtual lun0, so I'll send another patch to replace it with a per-device flag eventually. --- From 9fd0e75cffde876b84b08952cc7f026d4e08d77a Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Thu, 21 May 2015 18:58:21 +0200 Subject: target: don't add lun0 to tpg_lun_hlist We never want to find the virtual lun0 when looking up a lun on the TPG, otherwise the core code gets really confused. Signed-off-by: Christoph Hellwig --- drivers/target/target_core_tpg.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_tpg.c b/drivers/target/target_core_tpg.c index b8c2a32..ced1dd6 100644 --- a/drivers/target/target_core_tpg.c +++ b/drivers/target/target_core_tpg.c @@ -647,7 +647,8 @@ int core_tpg_add_lun( lun->lun_access = lun_access; lun->lun_status = TRANSPORT_LUN_STATUS_ACTIVE; - hlist_add_head_rcu(&lun->link, &tpg->tpg_lun_hlist); + if (!(dev->se_hba->hba_flags & HBA_FLAGS_INTERNAL_USE)) + hlist_add_head_rcu(&lun->link, &tpg->tpg_lun_hlist); mutex_unlock(&tpg->tpg_lun_mutex); @@ -687,7 +688,8 @@ void core_tpg_remove_lun( } lun->lun_status = TRANSPORT_LUN_STATUS_FREE; - hlist_del_rcu(&lun->link); + if (!(dev->se_hba->hba_flags & HBA_FLAGS_INTERNAL_USE)) + hlist_del_rcu(&lun->link); mutex_unlock(&tpg->tpg_lun_mutex); percpu_ref_exit(&lun->lun_ref);