| Message ID | 20150718161249.31955.25688.stgit@brunhilda (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 18.7.2015 18:12, Don Brace wrote: > showing that tables have been updated unnecessarily. > > Reviewed-by: Kevin Barnett <kevin.barnett@pmcs.com> > Reviewed-by: Scott Teel <scott.teel@pmcs.com> > Signed-off-by: Don Brace <don.brace@pmcs.com> Reviewed-by: Tomas Henzl <thenzl@redhat.com> Tomas > --- > drivers/scsi/hpsa.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index f64a2c7..f34978d 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -1379,8 +1379,9 @@ static inline int device_updated(struct hpsa_scsi_dev_t *dev1, > return 1; > if (dev1->offload_enabled != dev2->offload_enabled) > return 1; > - if (dev1->queue_depth != dev2->queue_depth) > - return 1; > + if (!is_logical_dev_addr_mode(dev1->scsi3addr)) > + if (dev1->queue_depth != dev2->queue_depth) > + return 1; > return 0; > } > > @@ -3889,7 +3890,6 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h, int hostno) > else if (!(h->transMethod & CFGTBL_Trans_io_accel1 || > h->transMethod & CFGTBL_Trans_io_accel2)) > break; > - > hpsa_get_ioaccel_drive_info(h, this_device, > lunaddrbytes, id_phys); > hpsa_get_path_info(this_device, lunaddrbytes, id_phys); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index f64a2c7..f34978d 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -1379,8 +1379,9 @@ static inline int device_updated(struct hpsa_scsi_dev_t *dev1, return 1; if (dev1->offload_enabled != dev2->offload_enabled) return 1; - if (dev1->queue_depth != dev2->queue_depth) - return 1; + if (!is_logical_dev_addr_mode(dev1->scsi3addr)) + if (dev1->queue_depth != dev2->queue_depth) + return 1; return 0; } @@ -3889,7 +3890,6 @@ static void hpsa_update_scsi_devices(struct ctlr_info *h, int hostno) else if (!(h->transMethod & CFGTBL_Trans_io_accel1 || h->transMethod & CFGTBL_Trans_io_accel2)) break; - hpsa_get_ioaccel_drive_info(h, this_device, lunaddrbytes, id_phys); hpsa_get_path_info(this_device, lunaddrbytes, id_phys);