diff mbox

lpfc: Use && instead of & for boolean expression

Message ID 20150722105322.00004f4b@localhost (mailing list archive)
State New, archived
Headers show

Commit Message

Sebastian Herbszt July 22, 2015, 8:53 a.m. UTC 
Use logical instead of bitwise AND.

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
---

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

James Smart July 22, 2015, 3:47 p.m. UTC | #1 
Reviewed-by: James Smart <james.smart@avagotech.com>

Thanks

-- james


On 7/22/2015 4:53 AM, Sebastian Herbszt wrote:
> Use logical instead of bitwise AND.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
> ---
>
> diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
> --- a/drivers/scsi/lpfc/lpfc_hbadisc.c	2015-07-05 22:18:43.933739150 +0200
> +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c	2015-07-22 10:31:14.240209475 +0200
> @@ -701,7 +701,7 @@ lpfc_work_done(struct lpfc_hba *phba)
>   								HA_RXMASK));
>   			}
>   		}
> -		if ((phba->sli_rev == LPFC_SLI_REV4) &
> +		if ((phba->sli_rev == LPFC_SLI_REV4) &&
>   				 (!list_empty(&pring->txq)))
>   			lpfc_drain_txq(phba);
>   		/*

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c	2015-07-05 22:18:43.933739150 +0200
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c	2015-07-22 10:31:14.240209475 +0200
@@ -701,7 +701,7 @@  lpfc_work_done(struct lpfc_hba *phba)
 								HA_RXMASK));
 			}
 		}
-		if ((phba->sli_rev == LPFC_SLI_REV4) &
+		if ((phba->sli_rev == LPFC_SLI_REV4) &&
 				 (!list_empty(&pring->txq)))
 			lpfc_drain_txq(phba);
 		/*