From patchwork Wed Aug 19 05:55:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaishali Thakkar X-Patchwork-Id: 7035541 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4C7479F372 for ; Wed, 19 Aug 2015 05:55:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7FE92207F6 for ; Wed, 19 Aug 2015 05:55:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA34A207CF for ; Wed, 19 Aug 2015 05:55:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751524AbbHSFzR (ORCPT ); Wed, 19 Aug 2015 01:55:17 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33418 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016AbbHSFzQ (ORCPT ); Wed, 19 Aug 2015 01:55:16 -0400 Received: by pabyb7 with SMTP id yb7so149715397pab.0; Tue, 18 Aug 2015 22:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=fd+e0cOK5oxxbK8v46m3qShFW2KUwk516NQwQepESv0=; b=mUZdfrlOeu5TIr+DnPv1+159rlkC+2ELlzuZYjRFRE8lfc8G5k6LwjZpDFbT/apBzU K+FKPPIpNkL+5zDnY+qGZFgsmpVN5r3zuYehBDZslVBgvpOP/G/IbNnFSgMAedsizFcq WepBaxwbtCqTh/xRsbP5y0PF3xx9j9J1+xRCH+b488oCPUTGmY7n3ZStjJrPdup8letO 56HnD5UjC7QlUVFdhB21LNSWSxwxPS6vowZ2DuPh//dLQnevx6bmngFG4u4N6aZ/0UmG L7PbAdeQiSavCl+th3yPNHR9qsq4IDwLrvUQN4x9vgI/ETrczXQ0xfUS2TFo3q0EbZuH FWLQ== X-Received: by 10.67.8.40 with SMTP id dh8mr20712422pad.129.1439963716306; Tue, 18 Aug 2015 22:55:16 -0700 (PDT) Received: from vaishali-Ideapad-Z570 ([150.107.241.60]) by smtp.gmail.com with ESMTPSA id qp5sm20086078pbc.0.2015.08.18.22.55.15 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Aug 2015 22:55:15 -0700 (PDT) Date: Wed, 19 Aug 2015 11:25:11 +0530 From: Vaishali Thakkar To: QLogic-Storage-Upstream@qlogic.com Cc: "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [SCSI] bnx2fc: Convert use of __constant_htons to htons Message-ID: <20150819055511.GA26504@localhost> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In little endian cases, the macro htons unfolds to __swab16 which provides special case for constants. In big endian cases, __constant_htons and htons expand directly to the same expression. So, replace __constant_htons with htons with the goal of getting rid of the definition of __constant_htons completely. The semantic patch that performs this transformation is as follows: @@expression x;@@ - __constant_htons(x) + htons(x) Signed-off-by: Vaishali Thakkar --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index d5cdc47..99f801c 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c @@ -1201,7 +1201,7 @@ static int bnx2fc_interface_setup(struct bnx2fc_interface *interface) dev_add_pack(&interface->fip_packet_type); interface->fcoe_packet_type.func = bnx2fc_rcv; - interface->fcoe_packet_type.type = __constant_htons(ETH_P_FCOE); + interface->fcoe_packet_type.type = htons(ETH_P_FCOE); interface->fcoe_packet_type.dev = netdev; dev_add_pack(&interface->fcoe_packet_type);