From patchwork Tue Feb 2 10:18:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A. Shutemov" X-Patchwork-Id: 8188271 Return-Path: X-Original-To: patchwork-linux-scsi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 574BC9FBE9 for ; Tue, 2 Feb 2016 10:18:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7DA442021F for ; Tue, 2 Feb 2016 10:18:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6526520211 for ; Tue, 2 Feb 2016 10:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754336AbcBBKSf (ORCPT ); Tue, 2 Feb 2016 05:18:35 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33919 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754207AbcBBKSd (ORCPT ); Tue, 2 Feb 2016 05:18:33 -0500 Received: by mail-wm0-f67.google.com with SMTP id p63so1677336wmp.1 for ; Tue, 02 Feb 2016 02:18:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=r4OUzKcMjMlUHMbHzhe16Y4s5xXUNq7CKnOVHLkOZ1k=; b=eK3q9+rSTIu30iGm0W/LqbpnsNHbQMaLQ8JecE/FsNZUcKczF1E99A2VUVTR5tb+fR Zyrtmnl05e8kmA+2VJcImMZIMGi4oFSIBVPJGBPFKzs5epPq8zaQA70PO+4pUwL/GN7t MdqifbTBSqx/8Kal+Qlt+s8pJzEixmInwqyF97XbGYujnnpbcxQaNJgH942lZbR2CbWm HMSDZ6rrwMDYDoRg4S4BQ/L3yKncR2JFjAMsX/hjkEBmE7C6HJ/3EEivj8BHGOWKVVFs B1dUGF6acaKCEU1p6HUixCjWOBzCPXIkQq06eLAhnf5FInJJ70bgIFkAvfRE3fjUu4ZX m3og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=r4OUzKcMjMlUHMbHzhe16Y4s5xXUNq7CKnOVHLkOZ1k=; b=HgG0G+Um4l2nYUY5jTUeO6wOLvxTvAOna4+X8LwBuiN+Bi169n7q7lxS8nTFdjeS7S STGeGtxhXG9T9J9hMZWndMC+ZsouprpL6xMG5wkbBboiFzCpinZvhvD/JYJ5W6BWV/nI /cfo+sr7QTRMhWUWm/Qh6QJgxLBUhZv32+XhK76iIUyffZUp6Ez1FzjrO4BKzOPUk6xE Q3B6FiBrfFAiYTXz4YB6sXOlkhcEf3Ieacbt6BIl4AlwviEJqk45M22+TO0DCIfYFhrj 7EzXPi2g0WTTm0UOU4xN0fegMw7xEL1Fqmc8eBf4enUUnTaNuRo0X4vv0Mx/jtnfUPVC H4tQ== X-Gm-Message-State: AG10YOTrp33Czl3Cj59DZ2ZMcHCimR6PFP6YHOnmOu3PuRBaRxqnYfLuI1SULeBMFccZQg== X-Received: by 10.28.183.69 with SMTP id h66mr9101189wmf.6.1454408312250; Tue, 02 Feb 2016 02:18:32 -0800 (PST) Received: from node.shutemov.name ([93.85.46.173]) by smtp.gmail.com with ESMTPSA id i5sm735026wja.23.2016.02.02.02.18.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Feb 2016 02:18:31 -0800 (PST) Received: by node.shutemov.name (Postfix, from userid 1000) id 47DB864DF2C7; Tue, 2 Feb 2016 12:18:30 +0200 (EET) Date: Tue, 2 Feb 2016 12:18:30 +0200 From: "Kirill A. Shutemov" To: Alexander Duyck Cc: jbottomley@odin.com, hare@suse.de, linux-scsi@vger.kernel.org, alexander.duyck@gmail.com, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, shane.seymour@hpe.com, jthumshirn@suse.de Subject: Re: [PATCH 0/2] scsi: Fix endless loop of ATA hard resets due to VPD reads Message-ID: <20160202101830.GA3786@node.shutemov.name> References: <20160121063039.3803.66.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160121063039.3803.66.stgit@localhost.localdomain> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Jan 20, 2016 at 10:35:15PM -0800, Alexander Duyck wrote: > Ultimately neither of these bugs were my root cause. It turns out the > Marvel Console SCSI device in my system needed to have a flag set to > disable VPD access in order to keep things from looping through the error > repeatedly. In order to resolve it I had to add the kernel parameter > "scsi_mod.dev_flags=Marvell:Console:0x4000000". This allowed my system to > boot without any errors, however the first two issues described above are > still relevent so I thought I would provide the patches since I had already > written them up. I have the same problem. Shouldn't we put quirk for that? From d5ad5e1ee4128c454f39d7f3ccaa0b202e0e8534 Mon Sep 17 00:00:00 2001 From: "Kirill A. Shutemov" Date: Tue, 2 Feb 2016 12:44:04 +0300 Subject: [PATCH] scsi: add Marvell Console to the ignore VPD pages blacklist With current upstream, I see these messages in loop. ata14: SATA link up 1.5 Gbps (SStatus 113 SControl 300) ata14.00: configured for UDMA/66 ata14: EH complete ata14.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 ata14.00: irq_stat 0x40000001 ata14.00: cmd a0/01:00:00:00:01/00:00:00:00:00/a0 tag 22 dma 16640 in Inquiry 12 01 00 00 ff 00res 00/00:00:00:00:00/00:00:00:00:00/00 Emask 0x3 (HSM violation) ata14: hard resetting link Looks like we should blacklist the device to stop it. Signed-off-by: Kirill A. Shutemov --- drivers/scsi/scsi_devinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index 47b9d13f97b8..da2e068ee47d 100644 --- a/drivers/scsi/scsi_devinfo.c +++ b/drivers/scsi/scsi_devinfo.c @@ -205,6 +205,7 @@ static struct { {"Intel", "Multi-Flex", NULL, BLIST_NO_RSOC}, {"iRiver", "iFP Mass Driver", NULL, BLIST_NOT_LOCKABLE | BLIST_INQUIRY_36}, {"LASOUND", "CDX7405", "3.10", BLIST_MAX5LUN | BLIST_SINGLELUN}, + {"Marvell", "Console", NULL, BLIST_SKIP_VPD_PAGES}, {"MATSHITA", "PD-1", NULL, BLIST_FORCELUN | BLIST_SINGLELUN}, {"MATSHITA", "DMC-LC5", NULL, BLIST_NOT_LOCKABLE | BLIST_INQUIRY_36}, {"MATSHITA", "DMC-LC40", NULL, BLIST_NOT_LOCKABLE | BLIST_INQUIRY_36},