| Message ID | 20160215185301.27731.20754.stgit@localhost.localdomain (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Mon, 2016-02-15 at 18:53 +0000, Alan wrote: > We were setting the queue depth correctly, then setting it back to > two. If you hit this as a bisection point then please send me an > email as it would imply we've been hiding other bugs with this one. > > Signed-off-by: Alan Cox <alan@linux.intel.com> > --- > drivers/scsi/aic7xxx/aic7xxx_osm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c > b/drivers/scsi/aic7xxx/aic7xxx_osm.c > index b846a46..fc6a831 100644 > --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c > +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c > @@ -1336,6 +1336,7 @@ ahc_platform_set_tags(struct ahc_softc *ahc, > struct scsi_device *sdev, > case AHC_DEV_Q_TAGGED: > scsi_change_queue_depth(sdev, > dev->openings + dev->active); > + break; > default: > Heh, that's a bit of an oopsie. I'll add a cc to stable to see what happens with older kernels. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 02/15/2016 07:53 PM, Alan wrote: > We were setting the queue depth correctly, then setting it back to two. If > you hit this as a bisection point then please send me an email as it would > imply we've been hiding other bugs with this one. > > Signed-off-by: Alan Cox <alan@linux.intel.com> > --- > drivers/scsi/aic7xxx/aic7xxx_osm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c > index b846a46..fc6a831 100644 > --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c > +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c > @@ -1336,6 +1336,7 @@ ahc_platform_set_tags(struct ahc_softc *ahc, struct scsi_device *sdev, > case AHC_DEV_Q_TAGGED: > scsi_change_queue_depth(sdev, > dev->openings + dev->active); > + break; > default: > /* > * We allow the OS to queue 2 untagged transactions to > > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
>>>>> "Alan" == Alan <gnomes@lxorguk.ukuu.org.uk> writes:
Alan> We were setting the queue depth correctly, then setting it back to
Alan> two. If you hit this as a bisection point then please send me an
Alan> email as it would imply we've been hiding other bugs with this
Alan> one.
Applied to 4.6/scsi-queue, CC:stable@.
diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index b846a46..fc6a831 100644 --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c @@ -1336,6 +1336,7 @@ ahc_platform_set_tags(struct ahc_softc *ahc, struct scsi_device *sdev, case AHC_DEV_Q_TAGGED: scsi_change_queue_depth(sdev, dev->openings + dev->active); + break; default: /* * We allow the OS to queue 2 untagged transactions to
We were setting the queue depth correctly, then setting it back to two. If you hit this as a bisection point then please send me an email as it would imply we've been hiding other bugs with this one. Signed-off-by: Alan Cox <alan@linux.intel.com> --- drivers/scsi/aic7xxx/aic7xxx_osm.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html