| Message ID | 20160417132727.000026f3@localhost (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Sonntag, 17. April 2016 13:27:27 CEST Sebastian Herbszt wrote: > Remove incorrect lockdep assertion from lpfc_sli_hbqbuf_find() which acquires > the hbalock itself. Fix the comment which resulted in this mistake. > > Fixes: 1c2ba475eb0e ("lpfc: Add lockdep assertions") > Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> > Good catch, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>>>>> "Sebastian" == Sebastian Herbszt <herbszt@gmx.de> writes:
Sebastian> Remove incorrect lockdep assertion from
Sebastian> lpfc_sli_hbqbuf_find() which acquires the hbalock itself. Fix
Sebastian> the comment which resulted in this mistake.
Applied to 4.7/scsi-queue.
diff -uNr -U 5 a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c --- a/drivers/scsi/lpfc/lpfc_sli.c 2016-03-15 03:25:44.324554218 +0100 +++ b/drivers/scsi/lpfc/lpfc_sli.c 2016-04-17 13:01:59.700182669 +0200 @@ -1998,24 +1998,21 @@ /** * lpfc_sli_hbqbuf_find - Find the hbq buffer associated with a tag * @phba: Pointer to HBA context object. * @tag: Tag of the hbq buffer. * - * This function is called with hbalock held. This function searches - * for the hbq buffer associated with the given tag in the hbq buffer - * list. If it finds the hbq buffer, it returns the hbq_buffer other wise - * it returns NULL. + * This function searches for the hbq buffer associated with the given tag in + * the hbq buffer list. If it finds the hbq buffer, it returns the hbq_buffer + * otherwise it returns NULL. **/ static struct hbq_dmabuf * lpfc_sli_hbqbuf_find(struct lpfc_hba *phba, uint32_t tag) { struct lpfc_dmabuf *d_buf; struct hbq_dmabuf *hbq_buf; uint32_t hbqno; - lockdep_assert_held(&phba->hbalock); - hbqno = tag >> 16; if (hbqno >= LPFC_MAX_HBQS) return NULL; spin_lock_irq(&phba->hbalock);
Remove incorrect lockdep assertion from lpfc_sli_hbqbuf_find() which acquires the hbalock itself. Fix the comment which resulted in this mistake. Fixes: 1c2ba475eb0e ("lpfc: Add lockdep assertions") Signed-off-by: Sebastian Herbszt <herbszt@gmx.de> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html