| Message ID | 20160912124212.32132-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
>-----Original Message----- >From: Colin King [mailto:colin.king@canonical.com] >Sent: Monday, September 12, 2016 6:12 PM >To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E . J . Bottomley; >Martin K >. Petersen; megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org >Cc: linux-kernel@vger.kernel.org >Subject: [PATCH] scsi: megaraid_sas: add in missing white space in error >message >text > >From: Colin Ian King <colin.king@canonical.com> > >A dev_printk message spans two lines and the literal string is missing a >white >space between words. Add the white space. > >Signed-off-by: Colin Ian King <colin.king@canonical.com> >--- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c >b/drivers/scsi/megaraid/megaraid_sas_base.c >index 2d62d71..c236c4d 100644 >--- a/drivers/scsi/megaraid/megaraid_sas_base.c >+++ b/drivers/scsi/megaraid/megaraid_sas_base.c >@@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev, > &instance->consumer_h); > > if (!instance->producer || !instance->consumer) { >- dev_printk(KERN_DEBUG, &pdev->dev, "Failed to >allocate" >+ dev_printk(KERN_DEBUG, &pdev->dev, "Failed to >allocate " > "memory for producer, consumer\n"); > goto fail_alloc_dma_buf; > } Acked-by: Sumit Saxena <sumit.saxena@broadcom.com> >-- >2.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/12/2016 02:42 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > A dev_printk message spans two lines and the literal string is missing > a white space between words. Add the white space. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > index 2d62d71..c236c4d 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev, > &instance->consumer_h); > > if (!instance->producer || !instance->consumer) { > - dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate" > + dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate " > "memory for producer, consumer\n"); > goto fail_alloc_dma_buf; > } > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:
Colin> From: Colin Ian King <colin.king@canonical.com> A dev_printk
Colin> message spans two lines and the literal string is missing a white
Colin> space between words. Add the white space.
Applied to 4.9/scsi-queue.
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 2d62d71..c236c4d 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -5782,7 +5782,7 @@ static int megasas_probe_one(struct pci_dev *pdev, &instance->consumer_h); if (!instance->producer || !instance->consumer) { - dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate" + dev_printk(KERN_DEBUG, &pdev->dev, "Failed to allocate " "memory for producer, consumer\n"); goto fail_alloc_dma_buf; }