From patchwork Sat Nov 19 17:42:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Lambert X-Patchwork-Id: 9438299 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DD0C760469 for ; Sat, 19 Nov 2016 17:45:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D243728D9B for ; Sat, 19 Nov 2016 17:45:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C57D328EC1; Sat, 19 Nov 2016 17:45:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82B8728D9B for ; Sat, 19 Nov 2016 17:45:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753187AbcKSRpj (ORCPT ); Sat, 19 Nov 2016 12:45:39 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35065 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752730AbcKSRph (ORCPT ); Sat, 19 Nov 2016 12:45:37 -0500 Received: by mail-wm0-f65.google.com with SMTP id a20so14693375wme.2; Sat, 19 Nov 2016 09:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=OAnwI2hfg4gcsBI2LuVj+704oOgEBKgMLr1hIxjafAw=; b=g5JEjzuQwg3+8Os8Ur6epc4MApmrVRKFGqF9PcN1AWMb3z3VFR8SX5TBJvXjTAahTj mNOJBIHxNZElUoc8o+gSLY2pQh05hOnbtyRjP6eYwOEbc8lma7OwMRZA/LUHoPhKIKx2 rGvNr++YQiQ/oiQFFSQq3+xO99igTZCya5OSDJMtWOx+bujBiuHj11v1pi2/IUY9/QOG o+wpjz0rar25S0RtNesAR9e7TLSLgdmCa48zSpBL71jYspca4FLr6gwZHUMdzOR73+8D 5gmp4B8wXuKs9A0hB592xLz3wEHUy16J+qiNNIDLQdfDiIL92Lftp6Xbl+Ni42vd64SQ /mMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OAnwI2hfg4gcsBI2LuVj+704oOgEBKgMLr1hIxjafAw=; b=NwI7ywSZc5fHHfv4tboocyAHX/pAOlZx4hJdexpzro/15Yx3Or7v5PCvBTEjN18st9 Uo85g4loEckVIs6iqGGPRwGjohrkv8U1NAriccbD7ZApdmkkrUL6e/RbOYPs7lew2npt X/aToHqteX/LgulFC1bbvgv81Q3JOx5WK6/zZlfg9Ug1TAgZK0jCnba7KH+XbEkinEj0 sxLN9yMdcrie9bhzVheZIziGfy/TWpB8ta8DyxgC1I8LmAZppComN4hLnf/IBVFNKC5R FsEvRpy5IdPr43DuHwjSt6hdAgEzeo1AOkxSnk9h5HQSoteHPE7kObqO7/QMQrkM3H5L Ioeg== X-Gm-Message-State: AKaTC02kEO9DGk24LfS4/HGVi62GisZgLNFgaD9DlXEB5t2hYHOFEQCui9ucaj7YddFjYQ== X-Received: by 10.28.41.5 with SMTP id p5mr5244187wmp.38.1479577536022; Sat, 19 Nov 2016 09:45:36 -0800 (PST) Received: from localhost.localdomain ([2a01:e35:8a86:9030:c685:8ff:fe2a:cb32]) by smtp.gmail.com with ESMTPSA id l67sm10500082wmf.0.2016.11.19.09.45.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Nov 2016 09:45:35 -0800 (PST) From: Quentin Lambert To: Karen Xie , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Cc: Quentin Lambert Subject: [PATCH] cxgb4i: Add a missing call to neigh_release Date: Sat, 19 Nov 2016 18:42:14 +0100 Message-Id: <20161119174214.20241-1-lambert.quentin@gmail.com> X-Mailer: git-send-email 2.10.2 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Most error branches following the call to dst_neigh_lookup contain a call to neigh_release. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert Acked-by: Varun Prakash --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c @@ -1410,7 +1410,7 @@ static int init_act_open(struct cxgbi_so csk->atid = cxgb4_alloc_atid(lldi->tids, csk); if (csk->atid < 0) { pr_err("%s, NO atid available.\n", ndev->name); - return -EINVAL; + goto rel_resource_without_clip; } cxgbi_sock_set_flag(csk, CTPF_HAS_ATID); cxgbi_sock_get(csk);