diff mbox

isci: Add a missing call to pci_unmap_biosrom

Message ID 20161119174340.20447-1-lambert.quentin@gmail.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Quentin Lambert Nov. 19, 2016, 5:43 p.m. UTC 
Most error branches following the call to pci_map_biosrom contain
a call to pci_unmap_biosrom. This patch add these calls where
they are missing.

This issue was found with Hector.

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>

---
 drivers/scsi/isci/probe_roms.c |    1 +
 1 file changed, 1 insertion(+)

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Martin K. Petersen Nov. 29, 2016, 4:50 p.m. UTC | #1 
>>>>> "Quentin" == Quentin Lambert <lambert.quentin@gmail.com> writes:

Quentin> Most error branches following the call to pci_map_biosrom
Quentin> contain a call to pci_unmap_biosrom. This patch add these calls
Quentin> where they are missing.

Applied to 4.10/scsi-queue.
diff mbox

Patch

--- a/drivers/scsi/isci/probe_roms.c
+++ b/drivers/scsi/isci/probe_roms.c
@@ -54,6 +54,7 @@  struct isci_orom *isci_request_oprom(str
 	len = pci_biosrom_size(pdev);
 	rom = devm_kzalloc(&pdev->dev, sizeof(*rom), GFP_KERNEL);
 	if (!rom) {
+		pci_unmap_biosrom(oprom);
 		dev_warn(&pdev->dev,
 			 "Unable to allocate memory for orom\n");
 		return NULL;