| Message ID | 20161124105238.GB17225@mwanda (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Thu, Nov 24, 2016 at 01:52:38PM +0300, Dan Carpenter wrote: > We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't need > to check again here. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Looks good, Acked-by: Johannes Thumshirn <jth@kernel.org>
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't
Dan> need to check again here.
Applied to 4.10/scsi-queue.
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 110a707..c991f3b 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -1196,7 +1196,6 @@ static void fc_rport_prli_resp(struct fc_seq *sp, struct fc_frame *fp, * Check if the image pair could be established */ if (rdata->spp_type != FC_TYPE_FCP || - resp_code != FC_SPP_RESP_ACK || !(pp->spp.spp_flags & FC_SPP_EST_IMG_PAIR)) { /* * Nope; we can't use this port as a target.
We verified that resp_code is FC_SPP_RESP_ACK earlier so we don't need to check again here. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html