From patchwork Wed Dec 28 11:00:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ojab // X-Patchwork-Id: 9490163 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7619062AB0 for ; Wed, 28 Dec 2016 11:01:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FCE91FE82 for ; Wed, 28 Dec 2016 11:01:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 546362623D; Wed, 28 Dec 2016 11:01:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 550971FE82 for ; Wed, 28 Dec 2016 11:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751348AbcL1LB3 (ORCPT ); Wed, 28 Dec 2016 06:01:29 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33933 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbcL1LB2 (ORCPT ); Wed, 28 Dec 2016 06:01:28 -0500 Received: by mail-lf0-f68.google.com with SMTP id d16so17340782lfb.1 for ; Wed, 28 Dec 2016 03:01:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ojab.ru; s=google; h=from:to:cc:subject:date:message-id; bh=zcO6J3l4lbGos4tVMY2IudRfyq7HFzbM6GvdYSmNz9M=; b=ZAycebdhJ/lh31XYoe7zukppGqFiV6PtPUxTaLHLNVJ32DcnutIOnYddBBNkvssDQt GGvDCv3enPvrITR5U1G2KR8XojAHBP/OafUhy0EoYj2jQbfhjapiRA3Nti4BqAGSkJ4y TJsv6P9B/9vMAoHS4dO71c3nBeuSgOcKj+xUQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zcO6J3l4lbGos4tVMY2IudRfyq7HFzbM6GvdYSmNz9M=; b=kqHsa1fSq8/P0b+HZue6iDysz9RXEij/R1jQdK+5L+LhptHKozIsfYxnsBY2ZRULPw quli+CyG7tHsNPRzbUkRkJB7j9ltO4xBH8zPojE8VGn756j6kyP7sDg/EGgp5DJbUH6L 5XKD5KSbnpHCTpPlSpNStEmuMHcU2xSw/2YpTqWrSQXCGKUhNoZhZzPwRUv2WP8gDagO HoH8nYLBztlF3pojYmBE7P1uu/NnvHBQuTM5/9R+hIH9W65S2+DHjldqIFGWgxE7ocWA kkBu7GMVFitUc3Wgf7LKYLiNxIaR0IXZ2VuNqd8w4HOnUv907i3ViXSFz+nrIvEZXm5Q Oz0Q== X-Gm-Message-State: AIkVDXI9bI3uGAJElg0TGgnxhS5BnZ9bWwWUU1ahtzeCR0Xfm/1Yzsd8r8VFX/OuRW2p6A== X-Received: by 10.46.78.2 with SMTP id c2mr12988560ljb.62.1482922885722; Wed, 28 Dec 2016 03:01:25 -0800 (PST) Received: from ojab.ru.ru ([195.91.239.8]) by smtp.googlemail.com with ESMTPSA id l138sm4383086lfl.44.2016.12.28.03.01.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Dec 2016 03:01:25 -0800 (PST) From: ojab To: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, ojab Subject: [PATCH] mpt3sas: disable ASPM for MPI2 controllers Date: Wed, 28 Dec 2016 11:00:56 +0000 Message-Id: <20161228110056.6250-1-ojab@ojab.ru> X-Mailer: git-send-email 2.10.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP MPI2 controllers sometimes got lost (i. e. disappears from /sys/bus/pci/devices) if ASMP is enabled. Signed-off-by: ojab Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=60644 --- Not sure if it's a complete fix, but at least I can't reproduce the issue locally with it applied. Also it's my first patch, so I've surely screwed up some formatting etc. drivers/scsi/mpt3sas/mpt3sas_scsih.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.10.0 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index b5c966e..203651a 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c @@ -51,6 +51,7 @@ #include #include #include +#include #include #include #include @@ -8734,6 +8735,8 @@ _scsih_probe(struct pci_dev *pdev, const struct pci_device_id *id) switch (hba_mpi_version) { case MPI2_VERSION: + pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S | + PCIE_LINK_STATE_L1 | PCIE_LINK_STATE_CLKPM); /* Use mpt2sas driver host template for SAS 2.0 HBA's */ shost = scsi_host_alloc(&mpt2sas_driver_template, sizeof(struct MPT3SAS_ADAPTER));