diff mbox

scsi: ufs: fix wrong/ambiguous fall through comments

Message ID 20170323104904.47040-1-tkusumi@tuxera.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Tomohiro Kusumi March 23, 2017, 10:49 a.m. UTC 
From: Tomohiro Kusumi <tkusumi@tuxera.com>

These aren't really falling through to anywhere meaningful.

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
 drivers/scsi/ufs/ufshcd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

subhashj@codeaurora.org March 24, 2017, 11:21 p.m. UTC | #1 
On 2017-03-23 03:49, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
> 
> These aren't really falling through to anywhere meaningful.
> 
> Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index dc6efbd..b7e5128 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -553,15 +553,14 @@ static inline u32 ufshcd_get_intr_mask(struct
> ufs_hba *hba)
>  	case UFSHCI_VERSION_10:
>  		intr_mask = INTERRUPT_MASK_ALL_VER_10;
>  		break;
> -	/* allow fall through */
>  	case UFSHCI_VERSION_11:
>  	case UFSHCI_VERSION_20:
>  		intr_mask = INTERRUPT_MASK_ALL_VER_11;
>  		break;
> -	/* allow fall through */
>  	case UFSHCI_VERSION_21:
>  	default:
>  		intr_mask = INTERRUPT_MASK_ALL_VER_21;
> +		break;
>  	}
> 
>  	return intr_mask;

Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
Martin K. Petersen March 28, 2017, 1:56 a.m. UTC | #2 
kusumi.tomohiro@gmail.com writes:

> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> These aren't really falling through to anywhere meaningful.
>
> Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>

Applied to 4.12/scsi-queue.

Thanks!
diff mbox

Patch

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dc6efbd..b7e5128 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -553,15 +553,14 @@  static inline u32 ufshcd_get_intr_mask(struct ufs_hba *hba)
 	case UFSHCI_VERSION_10:
 		intr_mask = INTERRUPT_MASK_ALL_VER_10;
 		break;
-	/* allow fall through */
 	case UFSHCI_VERSION_11:
 	case UFSHCI_VERSION_20:
 		intr_mask = INTERRUPT_MASK_ALL_VER_11;
 		break;
-	/* allow fall through */
 	case UFSHCI_VERSION_21:
 	default:
 		intr_mask = INTERRUPT_MASK_ALL_VER_21;
+		break;
 	}
 
 	return intr_mask;