From patchwork Thu Mar 23 13:58:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dupuis, Chad" X-Patchwork-Id: 9641137 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 56F6D6020B for ; Thu, 23 Mar 2017 13:58:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4638F284F1 for ; Thu, 23 Mar 2017 13:58:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3A8AC284F5; Thu, 23 Mar 2017 13:58:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55C04284F1 for ; Thu, 23 Mar 2017 13:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935185AbdCWN66 (ORCPT ); Thu, 23 Mar 2017 09:58:58 -0400 Received: from mail-co1nam03on0080.outbound.protection.outlook.com ([104.47.40.80]:50688 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933432AbdCWN6z (ORCPT ); Thu, 23 Mar 2017 09:58:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=93dPrGB4N+bNexrcMs6ypTqDueYD/nCZorMbtcHi+bY=; b=cMFswGN/9caNZJTv0b4lcNkAmb73JUR7hH8B0RFfENXheSdPnH7o1IByNYx9tdcl3rMs39r1yXxk2xBDm/jnaZ8TvGQJ69wVLG4qDz/kn8VZerEAKPOXW3PUg5HAazXv8JJOl+rSHOT/Q3gkr1nsFRUbcLbmvWvi01WmTpYnY0o= Received: from BLUPR07CA0102.namprd07.prod.outlook.com (10.255.223.173) by BLUPR07MB467.namprd07.prod.outlook.com (10.141.202.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Thu, 23 Mar 2017 13:58:49 +0000 Received: from BN1BFFO11FD001.protection.gbl (2a01:111:f400:7c10::1:147) by BLUPR07CA0102.outlook.office365.com (2a01:111:e400:841::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11 via Frontend Transport; Thu, 23 Mar 2017 13:58:49 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; oracle.com; dkim=none (message not signed) header.d=none; oracle.com; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1BFFO11FD001.mail.protection.outlook.com (10.58.144.64) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.977.7 via Frontend Transport; Thu, 23 Mar 2017 13:58:49 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.309.2; Thu, 23 Mar 2017 06:58:47 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v2NDwlam021110; Thu, 23 Mar 2017 06:58:47 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v2NDwlwv021109; Thu, 23 Mar 2017 06:58:47 -0700 From: "Dupuis, Chad" To: CC: , , Subject: [PATCH] qedf: Fix crash due to unsolicited FIP VLAN response. Date: Thu, 23 Mar 2017 06:58:47 -0700 Message-ID: <20170323135847.21074-1-chad.dupuis@cavium.com> X-Mailer: git-send-email 2.12.0 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39830400002)(39450400003)(2980300002)(428002)(189002)(199003)(9170700003)(80596001)(81166006)(8676002)(4326008)(33646002)(189998001)(2906002)(50466002)(50986999)(5660300001)(54906002)(86362001)(575784001)(2351001)(356003)(36756003)(110136004)(305945005)(87636002)(38730400002)(107886003)(6916009)(8936002)(48376002)(50226002)(101416001)(106466001)(42186005)(105586002)(1076002)(47776003)(5003940100001)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR07MB467; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD001; 1:CptrryBbTkL53sKMFzuqZz/emRx3qCNBtME8R4l6R1+Wo3jEcyUZ8zQP2GfD44Gy8wEHKC1LqV78WUdhGFIr3dp09fIf32Ce6O73N2LZtNKVaQXSqZRGYm0OFlbFkFJFc8P9ofx68aSXCxneNSajlV3LkVK9uDO2Q9sCL/ntDcfLSA/bEQ2tgMC5gd1F6QmIvsGe0joZ/lBPIVpF7Dp3yaUuDHrmkZaDsY6VqMwqWGINI+0tEJVLc5XD2VVfa9WlsAPztnu2Odhb1/U2q6Y5K7PjWC/Nmgr9KpfrscO+vkxwq5yqtrJNuFqoSnBd+hmqvvOS9QFs5mUuHJPHRoPLbalGZbTZwr/tEAji731KbUMMRIlA8JkbRo+2F6f9NDd/2WKqIE5Kphf/SfYsOjvBNgYacPyCh90oVdu5jCQuIszXBzXuKK8XkAiS08zgjZhiBwNORfm33vM+mbjyNNJlzHU9C1EYm1WO50xIr4jm0o6Lphad+amzSOYkl4/Ta+E6 X-MS-Office365-Filtering-Correlation-Id: 20d63422-3ef2-4f01-4c29-08d471f4bb70 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075); SRVR:BLUPR07MB467; X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB467; 3:s35rXFgW8cLJVetmBBTQB0n0EIoa2m7WzM+V8+ZKEIxqBl75rcRE5rc9GrGPsSSlznqdhJXT3xdfgRbh47WOuLBZ1lCMEuE6VQGwaaXYcecBwn4DqG7gUmuaydGJOTzTXkKXzF7Yu85PVADOXdl8XiNdzPrkV69yAU6Rsj1eRhBaYF4K1JULvN2uJx/h9ifLoFcwA7awVTpFcvnd+lLag6r0TulM1CmIBKXDErzK9JmMCORoAWGpmf/Cmni37rUBvBP/VKXwgli/BKHvlySnVTW/ucXMZXG+9GAM7OvNmzIlZOTl/y8fgZFwH7BPnpTaXS/zLdoOSgUor6DZTg9strEBrkwHv1N57lP38b1E8aXPXN8c4If9QG7muGKEHgQa9lWfqAziq1mX8M2qhDCrZQ==; 25:EJPtOjDE1w4cO23hwxpVhrsw8SMG5ENEAObcBafWp1Qh5oTkqC2m9l8Q5CvorEf61lf/5a8alQ928UIsRPbXmKwVwjU3k84UuxnG+hgz5EA8HwoOELaOBBbc31sIc+6nvBod+4thawN2+XTuqcsCvGGwyLP0Dva0Nzm259hz4FqehMqRPN2G8SDW8am10iZCDwET3NH8G2TpbDDttLYiKmFH8+UjsUm2HdYjdTkk+n/Xj4dfzOE0QrNstTGbdZ0ugKcSNnbShXSTLHGn51jiV7vyHaUtUipdsbUuh2zfp+XEh6xxPUzGYD7Fa8ZKkxnSZWp4ZesxJ0Z8e11Y6szcXYVXRzURJIGNT+0IVFyovRJf3NBZfihWooZFHfZaIUs3BpxhkRU+EHwRer19cLLMQFTLy4l2cj2YR1YatpeZIiSepG9cOpGryaR9ZZx9JxQTzkI55TMT7vTlPKXq0kQXOg== X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB467; 31:7MOUl6fHCqMq1r2o9AzC+PdWswyFEx6SwgvO69nU0mWW/+WzM/RGAI7daABQiYbuysxfIDCS5fILRk3dg3DdjEAk/rrwlOBehJ/nYgplgoY1FvrxirMiqUPOE3lFG96ZVvPQENox5LHz3xk2gZoeOEmI/U1YKvk84J5TLU9o8pHKNAUvACo0pvpCe0NmNQIaYk0CElsFKF4LoAz4crCGxIHb5HhxEdMCKLPDmNcA0I806H6L1ql+GXZfbpa5EQG4OBkHsbntJK8N9ey32b1w34ROBBZK3VQp3mKUthEpVLE=; 20:8Lmi3vZgjjd5Q8w9AEhMUt2LFPHxwtxmastT5Z0iA65WjRFMw87GpznD9qMd4u2ABIp2WHpJjsq05gYp4jhaUXPArEVZXiVNngoMDp8HWMNPDrVe26Oe1REPpM+9wiAnH07ZcbMJ43AIPswpitex/kLE9m7CHm0FDc6D4xV9inVEQsOPkd5mhIeqEL6T+tNdWG72o8kmh5t6RusIeidDcyA2zzw5kzQHGoOmNKQvFMfv6K+hOL7OXyElpBFQJn6BXT8tXy25oNxnRCVYCcv7bHK3tJiNjNGnMYXSEdMsd8xk0b6KA2f4ovisSDMF/yhVygDH4yRRGY8k/y5ELRuc5jHiX7kyrVyiFxSs6DxykmYb/xg/zcyiu/1rx3qff1S41ibLLOqeB+5Fqm8lg7tnubeg4/yHV657r32LzJ8uqvROwSr9JfH3dp5OkileNR4G0P6oFNxlJmnonPjYsaRv0AFHABUc1fKvuzZ1TPDz2Ef/szlYAveWA4Wjl2FSjsFl X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(209352067349851); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13018025)(8121501046)(13015025)(13017025)(13024025)(13023025)(5005006)(10201501046)(3002001)(6041248)(20161123558025)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148); SRVR:BLUPR07MB467; BCL:0; PCL:0; RULEID:; SRVR:BLUPR07MB467; X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB467; 4:8Z2sLi0xH0mS24JEVluKMWyFASPyXsPvDvWWiERNBInaHyOFB2d96/UKISSal1uzlol9i48gLujGI/2FsxUuobVNm5pDsNuo/KfGG7khQtXUy05cDCuavVn6Mc9ym4udTxu9VuCinUGLc4KETJHogBfzmWBrukC1hVbl3CDXEMkG/lQENNOOeawkeKESS4tzGNQIt9PT0yM601UD96sxT4pTOxhDd3WUsxMdo8oetXba11R8CtiKvFgCjNvvqEOBPiYc4pWzNwa4QjeMTE87B3N+bYf6wFV+BonZU+zO4UY828ZA7Vo+0H/ELKhGEwyhtsRvkCpGjPKUQSPwLLcKG8WQxN+nOAhuOwj3Tv3sBRvjmABfRkyFBosyrz7fB9YJ+NzcKSkcJ3du2V+xKz/B12MaObDH1kKFJ4j2iDI3U4KnELk32cNaLH9T0omAp2PM4uzzPor5/1oiYtwDMBJ/s95KOrzqVvy0K6vr/qmqxt5m+OLy3s2MtgfDke5iy9D2+S3wt04Vgi1kID1dya+4ebbILoezN/9w/AeC36P/kZE+G0bjS1DjsoGHl3IWvEJOo7LGm5hjrzE2ayZnc0avzyk6e3ZZ4HOIJSA3zLDupbvf+NFEOjRnRXjdNZ9BK90n3rmdeNru14k/jPq2mkFI0+F9y4E9D6ViJtATFQV5hSElD9LhRNR+voaiVMBJwKCK3pJA1UrhdVDEY2R51UTEKAujuAVeIE1biypl0K6cti318TY8+mD8tPb4rU5o4rK5 X-Forefront-PRVS: 0255DF69B9 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR07MB467; 23:YfjhMe8XrhyC7LDVIf3NK/IftvNmv/lOje556lit3Z?= =?us-ascii?Q?3pLTXXMmHDwNw3HwQh3Sn81SuwrQfOJXodampGy+79FRALZO0LQCLSolNhEC?= =?us-ascii?Q?JdPWdNEKm6ksf5GXCjYgH35lJZX4WG/SbthOF0vMdgFvvF/DlxYKMmTD3j3o?= =?us-ascii?Q?T7O5rzoBClSkbdzU/wlN9zc6qwTqBKwVIyjd4c0jq3I+cuGbhMZxAL3Xn109?= =?us-ascii?Q?rlRDVFPSH8mcK79ZV2FTfTIg+vY7ZBqNKdC607h0QXVWGFor35AehzkwgJoh?= =?us-ascii?Q?NGbc5FdFY9RVru8jzmzSDPqRvgV/D04/URgpooOrCjxz+J3dCIvUVNDnD+MU?= =?us-ascii?Q?IA5w24W2GT6VHwCn5mi2RRgw5dI3PxfzbWXwyl7YUcFYuvRiBewR4nUobXVT?= =?us-ascii?Q?Nk+mzFHNkM6aEkgI3dcEmTLj7R+oWsUc8zZF6kSsRc9eWRylktzpDZOiXoN1?= =?us-ascii?Q?DyKoQlUpRxlP/9ABWxUe3BErz9Ee9vgOEx82uhdfGFMxByetoVgRKEM0ILPj?= =?us-ascii?Q?xgMCWh/YyMpxl/GUKVPVZD9K0AzSiGHtSjROUoEI0DVyksvSq/0nfmjXD14b?= =?us-ascii?Q?rczEQq+VeCAqPqdB3Y4apAx5dVPt0/KLjnP43Ed8ztbbm8kjFaoJW/5utR2z?= =?us-ascii?Q?PmhlU7BGnYzG8JVGYutoCQjwtwCkVn3ljmnHxVyh4N3ntNfFrx0nE5XgbiIB?= =?us-ascii?Q?MCEe2aR8COt7lUr0PnEPXIXy6NJjEzG4Re5dJRrFrDycHXq34lojzszA6Iib?= =?us-ascii?Q?1JrldaPKMqPg0KU6usoKILsQi0BpotgQUM2PmC30f4OKV1AA9QWz6miUcVQL?= =?us-ascii?Q?NK7F4bLc7fSCSeQUjT5icWF2Jax8AlnmQr1K9qbWdsZRXEs/sBP213O9UxEk?= =?us-ascii?Q?zjeQQcTvj8+0a2xypooaK5LNq6SUG9rAOpvfpS6PWbbGVO/3XeV74bFbt1OC?= =?us-ascii?Q?CKD89/84O3ieH8jypDEHaB75dreRkS6bRc9ZuwWbj4/AgR30GmcwL36HVAKs?= =?us-ascii?Q?BKkONvi+2Sg7D/QR73I80y9vIogp07M0zfMPOiWrxk4Vi91DniaN6GWtlicn?= =?us-ascii?Q?+9Txw=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB467; 6:UoVzMEj0UipFEkmVW6QLIvWD7M+0m/onGhsDzxD11AU/mJeVhItvKRo190B4VquGWIO+Hdey//fw1cNPWwZhPqfL302mohkC9IZ6vBiegyp2pEMr8NQwE4l40suRhx8euy8A9q2msJh2Uj79x7sPF/HYIJM6nDr6YISV8fMj4AD9f9Dkz4uC4Diw7arDl1LU3Cv9tpBVidktjQlLyqPLVJjjuTGbAXoIwlEYbcSRqsUgsOMenEqXmm0GHBy+jgeplke7pvTVkJjGM1eRXG4QYN0w72NANVLpxFV5m8rBAvcZyY+h2kx0Fr5Gn5dT44ckWFNF/6tLLXd88xtBW0IGzboEGxsBKGXpaXhD/0UHWExay2kE4hp1o/9g4EuGlLWwjTG8jkgR+YdzerzEaxGNiw==; 5:3D4Um4qGRLrfAnq2zq9PQB2P77KzLPgzgyovsTSfTv3vefF701MOX/ePPWrujPit6IdD6q2Aqh3WFUe2Je9Jw5XAPvZACAl8ZvwN5RPQ+zcz8wJgBCo9ZbR8mF2fhlZlq029wLCs7d6qyaaq6UYTTA==; 24:SZFSi6n+ifqHBHLe2v2+HxKk4Ikg1NSfvWTF5rh0im49epH0q7zkn8fJh8dG4q6kWgJkCSK9aEA9UfTl1Lft7yfB5c5o1o56rSYumKUBHVY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB467; 7:deFCDhpkDHTRhZS29flarAqFOXjQoTG1WclBoV5pVISzf2udODrDPj+WSoJ5IsG6rpI/YXuH/3uQHdoZ6je4YNG3bxxhdfh+H7z6jA7hCJb/yIAmwCY0tMyLrqrJG6F2XtHgDOX/gxvGWF6JWdyTd6YzqigXzpfLm3Qhpcy++um6No5lDo7JI8/MpTJrTc2Zx3gSF3scBRi4FFuqqF8W8s78w1C4gJbxo9Ai5+udeRuhJiX5oqWW92FsFJ7j3MPKO2iGUeNTDPcqmMOO91TnvezwCA434OzEYTPQyu1JGXmGq4fhBNWyGXoFUIzScpsDW/RRB0LCs22RQnGLRnLgHg== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2017 13:58:49.2372 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR07MB467 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Chad Dupuis We need to initialize qedf->fipvlan_compl in __qedf_probe so that if we receive an unsolicited FIP VLAN response, the system doesn't crash due to trying to complete an uninitialized completion. Also add a check to see if there are any waiters on the completion so we don't inadvertantly kick start the discovery process due to the unsolicited frame. Fixed the crash: <1>BUG: unable to handle kernel NULL pointer dereference at (null) <1>IP: [] __wake_up_common+0x31/0x90 <4>PGD 0 <4>Oops: 0000 [#1] SMP <4>last sysfs file: /sys/devices/system/cpu/online <4>CPU 7 <4>Modules linked in: autofs4 nfs lockd fscache auth_rpcgss nfs_acl sunrpc target_core_iblock target_core_file target_core_pscsi target_core_mod configfs bnx2fc cnic fcoe 8021q garp stp llc ipt_REJECT nf_conntrack_ipv4 nf_defrag_ipv4 iptable_filter ip_tables ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables ipv6 vfat fat uinput ipmi_devintf microcode power_meter acpi_ipmi ipmi_si ipmi_msghandler iTCO_wdt iTCO_vendor_support dcdbas sg joydev sb_edac edac_core lpc_ich mfd_core shpchp tg3 ptp pps_core ext4 jbd2 mbcache sr_mod cdrom sd_mod crc_t10dif qedi(U) iscsi_boot_sysfs libiscsi scsi_transport_iscsi uio qedf(U) libfcoe libfc scsi_transport_fc scsi_tgt qede(U) qed(U) ahci megaraid_sas wmi dm_mirror dm_region_hash dm_log dm_mod [last unloaded: speedstep_lib] <4> <4>Pid: 1485, comm: qedf_11_ll2 Not tainted 2.6.32-642.el6.x86_64 #1 Dell Inc. PowerEdge R730/0599V5 <4>RIP: 0010:[] [] __wake_up_common+0x31/0x90 <4>RSP: 0018:ffff881068a83d50 EFLAGS: 00010086 <4>RAX: ffffffffffffffe8 RBX: ffff88106bf42de0 RCX: 0000000000000000 <4>RDX: 0000000000000000 RSI: 0000000000000003 RDI: ffff88106bf42de0 <4>RBP: ffff881068a83d90 R08: 0000000000000000 R09: 00000000fffffffe <4>R10: 0000000000000000 R11: 000000000000000b R12: 0000000000000286 <4>R13: ffff88106bf42de8 R14: 0000000000000000 R15: 0000000000000000 <4>FS: 0000000000000000(0000) GS:ffff88089c460000(0000) knlGS:0000000000000000 <4>CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b <4>CR2: 0000000000000000 CR3: 0000000001a8d000 CR4: 00000000001407e0 <4>DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 <4>DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 <4>Process qedf_11_ll2 (pid: 1485, threadinfo ffff881068a80000, task ffff881068a70040) <4>Stack: <4> ffff88106ef00090 0000000300000001 ffff881068a83d90 ffff88106bf42de0 <4> 0000000000000286 ffff88106bf42dd8 ffff88106bf40a50 0000000000000002 <4> ffff881068a83dc0 ffffffff810634c7 ffff881000000003 000000000000000b <4>Call Trace: <4> [] complete+0x47/0x60 <4> [] qedf_fip_recv+0x1c7/0x450 [qedf] <4> [] qedf_ll2_recv_thread+0x33b/0x510 [qedf] <4> [] ? qedf_ll2_recv_thread+0x0/0x510 [qedf] <4> [] kthread+0x9e/0xc0 <4> [] child_rip+0xa/0x20 <4> [] ? kthread+0x0/0xc0 <4> [] ? child_rip+0x0/0x20 <4>Code: 41 56 41 55 41 54 53 48 83 ec 18 0f 1f 44 00 00 89 75 cc 89 55 c8 4c 8d 6f 08 48 8b 57 08 41 89 cf 4d 89 c6 48 8d 42 e8 49 39 d5 <48> 8b 58 18 74 3f 48 83 eb 18 eb 0a 0f 1f 00 48 89 d8 48 8d 5a <1>RIP [] __wake_up_common+0x31/0x90 <4> RSP <4>CR2: 0000000000000000 Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_fip.c | 3 ++- drivers/scsi/qedf/qedf_main.c | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_fip.c b/drivers/scsi/qedf/qedf_fip.c index ed58b91..e10b91c 100644 --- a/drivers/scsi/qedf/qedf_fip.c +++ b/drivers/scsi/qedf/qedf_fip.c @@ -99,7 +99,8 @@ static void qedf_fcoe_process_vlan_resp(struct qedf_ctx *qedf, qedf_set_vlan_id(qedf, vid); /* Inform waiter that it's ok to call fcoe_ctlr_link up() */ - complete(&qedf->fipvlan_compl); + if (!completion_done(&qedf->fipvlan_compl)) + complete(&qedf->fipvlan_compl); } } diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 8e2a160..cceddd9 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -2803,6 +2803,7 @@ static int __qedf_probe(struct pci_dev *pdev, int mode) atomic_set(&qedf->num_offloads, 0); qedf->stop_io_on_error = false; pci_set_drvdata(pdev, qedf); + init_completion(&qedf->fipvlan_compl); QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_INFO, "QLogic FastLinQ FCoE Module qedf %s, "