From patchwork Tue Mar 28 13:49:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomohiro Kusumi X-Patchwork-Id: 9649647 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 81629602C8 for ; Tue, 28 Mar 2017 13:50:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75734283E1 for ; Tue, 28 Mar 2017 13:50:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A2C62840B; Tue, 28 Mar 2017 13:50:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BC4AF283E1 for ; Tue, 28 Mar 2017 13:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932762AbdC1NuG (ORCPT ); Tue, 28 Mar 2017 09:50:06 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33411 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932103AbdC1NuE (ORCPT ); Tue, 28 Mar 2017 09:50:04 -0400 Received: by mail-lf0-f65.google.com with SMTP id r36so10601333lfi.0 for ; Tue, 28 Mar 2017 06:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=P6lkq0H/yOhenYYrnMkASEbMGPCNYjxgXZefqkQDbq8=; b=SVZmhOqPaOswh2Su07POHrfFDLBTUbcOaBjlt0KognITCgHg+FXNRxteTdR7LghkIQ ZETv/pQP93zQEnMdA65WqMrfCX0Wj0+AKaz60ok9TOslUPTQf41vz1XSrWhVkzzphNUo NMv83BBCN7VhslMchDNMB08NhvS3E1z1gtatjdrwQjdd4av+sZpMPvjw2rl2AtYD2EGb 0S/GVZpOmZV69dHq/JTHvCIyDCduL6xyCL1YlqRt/9RdhxbQ3bGiu7lqBKy24CNPD0R5 zf/esuuW6wsBdSqYhRcbsi/UzkJV6Ge1q8IqhvX1d46wgmHMtL7/5TfiP+SbSMyOI874 G7Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=P6lkq0H/yOhenYYrnMkASEbMGPCNYjxgXZefqkQDbq8=; b=C4qI5AUVnyV7TGcKa1XSg9+MRnJFxl+gGzkV3gAZEFbplDPppRy94KfmIbyVBAGuHw lRXdmRaljKv9d3f2DT0kOIk0WNAGq83w11JK4YHQhhQIUgB+rqRVmrvDI+X9DfmiCRMG YTnKnx+2cEXJOQbouOEF/NG6lKWejO2wkV24mjL+NIVUsWZf0yHFwpb/5LBk6pZxRosN 4e80i3mGV2L0Abinp+dDbXM6RO94ShkSyC1IiR6tFe4phCOl5JGpakZJgglYn7sJbiw3 TbHmuBSfcw5MfvEZKwiHfm2V7fy0wvV993T/P2FuKYnGD3gI8Pr06WElsXfQLx+vHn8L zucQ== X-Gm-Message-State: AFeK/H1icgC+XJA0d9KvgFWdbR45GCWBdlG3WbbzpxDvAj5HkbOpUnhbTJIquQPY3cYEXw== X-Received: by 10.25.212.144 with SMTP id l138mr11507989lfg.26.1490708987061; Tue, 28 Mar 2017 06:49:47 -0700 (PDT) Received: from localhost.localdomain ([194.100.106.190]) by smtp.gmail.com with ESMTPSA id q71sm690563lfe.40.2017.03.28.06.49.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Mar 2017 06:49:46 -0700 (PDT) From: kusumi.tomohiro@gmail.com X-Google-Original-From: tkusumi@tuxera.com To: martin.petersen@oracle.com, vinholikatti@gmail.com, linux-scsi@vger.kernel.org Cc: Tomohiro Kusumi Subject: [PATCH 1/6] scsi: ufs: make ufshcd_is_{device_present, hba_active}() return bool Date: Tue, 28 Mar 2017 16:49:24 +0300 Message-Id: <20170328134929.25599-1-tkusumi@tuxera.com> X-Mailer: git-send-email 2.9.3 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tomohiro Kusumi ufshcd driver generally uses bool for is_xxx type things instead of int, so conform to its style. Signed-off-by: Tomohiro Kusumi Reviewed-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index b7e5128..b006f1e 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -585,12 +585,12 @@ static inline u32 ufshcd_get_ufs_version(struct ufs_hba *hba) * the host controller * @hba: pointer to adapter instance * - * Returns 1 if device present, 0 if no device detected + * Returns true if device present, false if no device detected */ -static inline int ufshcd_is_device_present(struct ufs_hba *hba) +static inline bool ufshcd_is_device_present(struct ufs_hba *hba) { return (ufshcd_readl(hba, REG_CONTROLLER_STATUS) & - DEVICE_PRESENT) ? 1 : 0; + DEVICE_PRESENT) ? true : false; } /** @@ -832,11 +832,11 @@ static inline void ufshcd_hba_start(struct ufs_hba *hba) * ufshcd_is_hba_active - Get controller state * @hba: per adapter instance * - * Returns zero if controller is active, 1 otherwise + * Returns false if controller is active, true otherwise */ -static inline int ufshcd_is_hba_active(struct ufs_hba *hba) +static inline bool ufshcd_is_hba_active(struct ufs_hba *hba) { - return (ufshcd_readl(hba, REG_CONTROLLER_ENABLE) & 0x1) ? 0 : 1; + return (ufshcd_readl(hba, REG_CONTROLLER_ENABLE) & 0x1) ? false : true; } static const char *ufschd_uic_link_state_to_string(