From patchwork Tue Mar 28 13:49:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomohiro Kusumi X-Patchwork-Id: 9649661 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E14DF602C8 for ; Tue, 28 Mar 2017 13:50:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D55532837F for ; Tue, 28 Mar 2017 13:50:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA47C28387; Tue, 28 Mar 2017 13:50:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 576D3283E8 for ; Tue, 28 Mar 2017 13:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753006AbdC1Nub (ORCPT ); Tue, 28 Mar 2017 09:50:31 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36498 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbdC1Nu3 (ORCPT ); Tue, 28 Mar 2017 09:50:29 -0400 Received: by mail-lf0-f65.google.com with SMTP id n78so10570838lfi.3 for ; Tue, 28 Mar 2017 06:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MuzZFnz0YO8liW2/cF3IoRhS0VMunDfKW+ZjpQBSfAA=; b=YLD17XIApCKILgLIFWdBQka0r3tVZsnKvtmdV0BKAEKiDrb82GQTOH/RyjBUqAlXtx 3qrCAOm9HQHIgpJtemHLt4JiwYQEBOY/g9XJpy9bi/Tto0WVySCCY++z9cDIningQzyW OzFOCX+6gsECOtjTKKhBYqYyp1KBi7Pyf/vrvn93M3nSCwXUwfowJFlsjyvd0i7VBCpt hZsz1IhhH5cqU1RuCIe7ZIb3CiPtgjHZQvP1uIAVxsRt3zMBHtcwOSQP6Z5mcVBSerQt xyJ4QW+lbf5JecqzxuSsiPwLfeAiV/xCF4e101n0QqGVRdy4/zs7ZP6AJ3e5fyIbVcQS IgzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MuzZFnz0YO8liW2/cF3IoRhS0VMunDfKW+ZjpQBSfAA=; b=DKx/d8uJUG/HWohL6h4Dya696BzzUKTWXUOvC0zewsTOVhoupbFpuDJGnXuucw9DRh hYiwSzDyXK7nW4MVEJJNRtRjB1IstGOy/0fUDi7vChJRIw9FItPS4f6rM9d/ADnap/Nn 6YBsLhiX1/ETAEalTCZ5+VRMwTwmBhcPcWuJBx1lLH1DcLG8OOs0t+Bvgl3WvakLuc9N 57ewCVNbwGtIbDFtcdOR45pLsZHqq5ptoPAaDyPVjWHPTTRXzfBT9ieMRvx/R18EtHmg zNPZjnKxfzEDYxdRXgPO96t6FcVtkN9trCzluVe5Ev1RMR85siV2acq9S0Al1LSN115W r1Hw== X-Gm-Message-State: AFeK/H1VK3QN8cITbXNhr9H8ZmpKzvucL/oiomwGPW9Aty2Tx/KmRiA646QMVW5J6krkZw== X-Received: by 10.25.221.132 with SMTP id w4mr11330191lfi.59.1490708988927; Tue, 28 Mar 2017 06:49:48 -0700 (PDT) Received: from localhost.localdomain ([194.100.106.190]) by smtp.gmail.com with ESMTPSA id q71sm690563lfe.40.2017.03.28.06.49.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Mar 2017 06:49:48 -0700 (PDT) From: kusumi.tomohiro@gmail.com X-Google-Original-From: tkusumi@tuxera.com To: martin.petersen@oracle.com, vinholikatti@gmail.com, linux-scsi@vger.kernel.org Cc: Tomohiro Kusumi Subject: [PATCH 3/6] scsi: ufs: non functional macro fix Date: Tue, 28 Mar 2017 16:49:26 +0300 Message-Id: <20170328134929.25599-3-tkusumi@tuxera.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170328134929.25599-1-tkusumi@tuxera.com> References: <20170328134929.25599-1-tkusumi@tuxera.com> Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tomohiro Kusumi Not having () isn't likely to do any harm in this case, but all the other macros below do have it. Also add "are" in a comment. Signed-off-by: Tomohiro Kusumi Reviewed-by: Subhash Jadavani --- drivers/scsi/ufs/ufshcd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index dd46259..089b76f 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -151,11 +151,11 @@ enum { }; #define ufshcd_set_eh_in_progress(h) \ - (h->eh_flags |= UFSHCD_EH_IN_PROGRESS) + ((h)->eh_flags |= UFSHCD_EH_IN_PROGRESS) #define ufshcd_eh_in_progress(h) \ - (h->eh_flags & UFSHCD_EH_IN_PROGRESS) + ((h)->eh_flags & UFSHCD_EH_IN_PROGRESS) #define ufshcd_clear_eh_in_progress(h) \ - (h->eh_flags &= ~UFSHCD_EH_IN_PROGRESS) + ((h)->eh_flags &= ~UFSHCD_EH_IN_PROGRESS) #define ufshcd_set_ufs_dev_active(h) \ ((h)->curr_dev_pwr_mode = UFS_ACTIVE_PWR_MODE) @@ -1491,7 +1491,7 @@ int ufshcd_hold(struct ufs_hba *hba, bool async) break; } /* - * If we here, it means gating work is either done or + * If we are here, it means gating work is either done or * currently running. Hence, fall through to cancel gating * work and to enable clocks. */