Message ID | 20170418155229.5977-22-hch@bombadil.infradead.org (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers | show |
On Tue, 2017-04-18 at 08:52 -0700, Christoph Hellwig wrote: > The driver never sets req->errors Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>
diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c index 82c6d02193ae..3b0ab214fe74 100644 --- a/drivers/block/paride/pd.c +++ b/drivers/block/paride/pd.c @@ -739,7 +739,6 @@ static int pd_special_command(struct pd_unit *disk, enum action (*func)(struct pd_unit *disk)) { struct request *rq; - int err = 0; rq = blk_get_request(disk->gd->queue, REQ_OP_DRV_IN, __GFP_RECLAIM); if (IS_ERR(rq)) @@ -748,10 +747,9 @@ static int pd_special_command(struct pd_unit *disk, rq->special = func; blk_execute_rq(disk->gd->queue, disk->gd, rq, 0); - err = req->errors ? -EIO : 0; blk_put_request(rq); - return err; + return 0; } /* kernel glue structures */
From: Christoph Hellwig <hch@lst.de> The driver never sets req->errors --- drivers/block/paride/pd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)