From patchwork Tue Apr 18 15:52:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9685711 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 57D1B602C9 for ; Tue, 18 Apr 2017 15:53:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AA642832D for ; Tue, 18 Apr 2017 15:53:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3FB612838E; Tue, 18 Apr 2017 15:53:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 07A312832D for ; Tue, 18 Apr 2017 15:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757500AbdDRPxn (ORCPT ); Tue, 18 Apr 2017 11:53:43 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:42938 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754025AbdDRPwt (ORCPT ); Tue, 18 Apr 2017 11:52:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Sender:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1XeNYIoqHtDkCsE2kT+oxs8Yw2NVhUMnFqZ4w65JSKU=; b=CAOdEGLayk6tRF1dFYSVAfzja uszIpxwzu6MRdVYWNCfAVoE87ZZLKQUlhJ5Ogg8t9VSNNndExQh2GddN4cVMxrfCc9x2uUI/Uf1TW KED1/GMjh33WWcXuBj4r2dtvE/tp2FoACJYCRPcJJX6wa2nB/5fDkVXE/Q56G5q03Vbg4mE5DhMaQ J68AketcObZf8rlUE6Euq8+H1sgidVwWzP1tgQQu2knCXBjfroEs7u7bJs4iTcxIEHLlYjthkJEAf gBHoK3F+F3zR+Y2+jEwIO0iBnryDmc9tRSV7udZNOya0qZl515YKxwtAKbOVKKZdpsMErgGdlqEl2 E8Pf6uNug==; Received: from hch by bombadil.infradead.org with local (Exim 4.87 #1 (Red Hat Linux)) id 1d0VQf-0001aj-MA; Tue, 18 Apr 2017 15:52:33 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Josef Bacik , James Smart , Konrad Rzeszutek Wilk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, dm-devel@redhat.com, Christoph Hellwig Subject: pd: remove bogus check for req->errors Date: Tue, 18 Apr 2017 08:52:27 -0700 Message-Id: <20170418155229.5977-22-hch@bombadil.infradead.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170418155229.5977-1-hch@bombadil.infradead.org> References: <20170418155229.5977-1-hch@bombadil.infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Christoph Hellwig The driver never sets req->errors Reviewed-by: Bart Van Assche --- drivers/block/paride/pd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c index 82c6d02193ae..3b0ab214fe74 100644 --- a/drivers/block/paride/pd.c +++ b/drivers/block/paride/pd.c @@ -739,7 +739,6 @@ static int pd_special_command(struct pd_unit *disk, enum action (*func)(struct pd_unit *disk)) { struct request *rq; - int err = 0; rq = blk_get_request(disk->gd->queue, REQ_OP_DRV_IN, __GFP_RECLAIM); if (IS_ERR(rq)) @@ -748,10 +747,9 @@ static int pd_special_command(struct pd_unit *disk, rq->special = func; blk_execute_rq(disk->gd->queue, disk->gd, rq, 0); - err = req->errors ? -EIO : 0; blk_put_request(rq); - return err; + return 0; } /* kernel glue structures */