From patchwork Mon Apr 24 07:51:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Damien Le Moal X-Patchwork-Id: 9695773 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8D202601E9 for ; Mon, 24 Apr 2017 07:51:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7997A2654B for ; Mon, 24 Apr 2017 07:51:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E62326CFF; Mon, 24 Apr 2017 07:51:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F20AE2654B for ; Mon, 24 Apr 2017 07:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1166248AbdDXHvf (ORCPT ); Mon, 24 Apr 2017 03:51:35 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:21848 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1166246AbdDXHvc (ORCPT ); Mon, 24 Apr 2017 03:51:32 -0400 X-IronPort-AV: E=Sophos;i="5.37,243,1488816000"; d="scan'208";a="13405408" Received: from mail-dm3nam03lp0021.outbound.protection.outlook.com (HELO NAM03-DM3-obe.outbound.protection.outlook.com) ([207.46.163.21]) by ob1.hgst.iphmx.com with ESMTP; 24 Apr 2017 15:51:31 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AIwFo66IpeQWYwWj1qQ//2QTjLI6RerB3kvpWwOFlmg=; b=SXY43cKCyydTGAZMfkG9qFSUnyyvDy9QVd/Ao2NZy1nJX8+mvLoSPl1FMPWp2oySqb0kG8w7ICprVw0kDE5MIyWuYXHpDal2MW7uYW4qKjiRO18WyKQQWpgSNQJWtp2BOfwvqGMMjFjs8aY1pQkluRgq35DWt6mgbbCmI+Yfyio= Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=wdc.com; Received: from washi.fujisawa.hgst.com (199.255.44.173) by CY1PR04MB1980.namprd04.prod.outlook.com (10.166.191.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1047.13; Mon, 24 Apr 2017 07:51:26 +0000 From: damien.lemoal@wdc.com To: linux-scsi@vger.kernel.org, "Martin K . Petersen" Cc: Bart Van Assche , Hannes Reinecke , Christoph Hellwig , Damien Le Moal Subject: [PATCH v2 1/7] sd: Fix functions description Date: Mon, 24 Apr 2017 16:51:09 +0900 Message-Id: <20170424075115.30337-2-damien.lemoal@wdc.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170424075115.30337-1-damien.lemoal@wdc.com> References: <20170424075115.30337-1-damien.lemoal@wdc.com> MIME-Version: 1.0 X-Originating-IP: [199.255.44.173] X-ClientProxiedBy: BN6PR1401CA0004.namprd14.prod.outlook.com (10.174.237.142) To CY1PR04MB1980.namprd04.prod.outlook.com (10.166.191.16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a12b6bda-57fd-4b34-1e98-08d48ae6b76b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:CY1PR04MB1980; X-Microsoft-Exchange-Diagnostics: 1; CY1PR04MB1980; 3:9oIFXAIVuUUEVnfaBTQKHKUIi6ku2KdpJMs+/HKRS6t3d0gs1ez34V097jNv7LzE8GPI+YGQVob2XaGDXdnjTtyy7bcQ9c+Sh5TCM/ZKGSu795IURZakyaG2i/IlNiuYNs5UapIhzhjif/rvRfi3O+UxwPWT09eoHpcNbKthjeQwQj+U80mQ+3ld1cVsXVS8dqwnUogL0LaXyzEuRUGHzuR+AMWWEgFaHfjf7q19+5epBtjlcUe2m06HuDxwQcqlM9C4tH+cvB7naiVSc3p5un3K/9ld6elK52jTmjnFEf+H1Inw6eZaAAQaxDO97vOfETcyUZ4r1kVRUh1hIJjJMx1bJ/PDYg9lk1r88ZtGRP8=; 25:3iyCQB00VvzRAC6/2jJl1DztXHf26eeHeX4fU1OAAoaWiA3EuPJBbzrmcW0+vgIZYmcvbM7N3QTrP79AfKyHGykQZk/Nfu/0hd1mGDYHdd1wg29cca7VPZgAOnyRDSpJVbCe+P0DYggKD0lOqYH9rAk9gwHm5Pesmh9IaOFCtvahQq27zUZr7EC42G1aqOlUEp48ylZ33OBbBspiflQgLlNskodEvChwpHQKK/L9plPPRuDxt319cq2pDaJ2N3b29p/keRLJNd96Dxc30UPxwM4poCL9GcPtB3ZQTnYGtyZ0yn4Rb+QPsNFqx3Nm5RIZGVfTnqJj9eO4KdKlD+wPN38V9SGNVf5JWDPYPUuOl0muOisklerwCfe+jAHvgwktbZV9NT01w+p7t5omGPpImmTys6LaNpYxDnrsqRHgbCN1k89Dbp/itM49x7fDkm5zbIzBYwiGjPwOxPZpL2XJtg== X-Microsoft-Exchange-Diagnostics: 1; CY1PR04MB1980; 31:sveKa8fWMhWNcQcmdANLt1C0McaNMhir1LFoOLw6YuCbxJdI0bdp/1JOqUdit6eWt2igelPCfBUo8nhQIy8wL8joTafmre+kiB9rJS5CqV7WNLfvToalsXDc/X/wPr2jdw2IiL9f3FfNyiAALdvyigLO29chOmeuov2woy44hZ2SX3DzjwOTjGe+zx5teOZBvjvGd1sXKr08vHBE8xIB06Fd9bihr046UamPAmdJem2aIsnmqxdlfmx/GvtGTUTD; 20:4f2y9sTn5GYLNvHRXiDmjYvMd7NFYVGV3JvtZu8xqP4cDVrzH/nPozd5gMzvIRNrH05TzQG+oOLONAQpUxmiAKKKcbJJwTdB7tn4HYYSMcYz8dVJ/YRFYVYP9G3V4O3SGgUgqdYvrAg1wRw3mbdoUjzlbPYAahlZCJ95P3QqeVsgG0iZh5mOEgYYx+erfceyKNk/c5fFgwN+i6FnqoXS37e2Tc+FWRGCKvuJIqEEr8DouQrMLdxm2bJi3FHIjR8RieO7uhqFmYcWTxivJJvp1AqKsNkmXXKaxH0wMbLEMNtcXDidjHll23qHnea0rNDAYtLRfMT9OyZP5WQJgRBy17lJNmK52hS7Kujymbjx8iwAqMIDq0a1xtsKB4R2ldrPml3qr6sJa4Te/B3zYGvvA8UZF0h6OIff5tUJ4TNB7M6DmR/r6UVQ5Sr318Uh+slpBzp9KluOGoHKBdC94P3cR/1i4q6ts923aUwYJCuVexV6WeSXXyZTRurEtqT0LK+3 WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:CY1PR04MB1980; BCL:0; PCL:0; RULEID:; SRVR:CY1PR04MB1980; X-Microsoft-Exchange-Diagnostics: 1; CY1PR04MB1980; 4:kF1KbicPpG29pf4xfcqhlbnSYzC4Fskm8yB63MqWjiIrbxM1+01dc5bLAsKG8BxQgVoTIwzUBiK3fo+QCkIYzslmbf9lrTTeB8sdCL4sXo2CpSGYRbqFKC1cNvKnix61wmDTbxqFxvzUy5YMN0Hpv8oM5fdXH2ch+RT8SRgF1GeT/23W1pqKkMhOHCE3BygkdneI7ytr4mhA4HNUy6FVqVcuq/pwII3H/YLAf10JEj9+8Q/pV76WF5S+nme5UXmwOfzL5BleprzjZuVKHjTZY2ohWr7/G3vWA4KVRu0wEIVsoUcjVDqEEls1QsN/1zCg9RCAthggSRunLDbEusTiohVRHN3+QGPU13q8DIWTbhiJNU8ui47OQlP1wmeB/tG4Ila5FcPaQX5vmUK12ZNP76R/dKM7LzY2l3yawyO+bwSdO3opF6vJSKl7c7A3pof/2DK8HVsi+S44X8BCgtl4Nsl8tGJDtIixnCjvWs2TiLY2HY4n8q1RXNi/tXhNveSeDQK/lj2gmkJ5sBNgr+IjQ/f+Ji3JicK73CBFPz//2xe5shzbvN5ZxvmF/nSi8n2ZjxM4TeB4k5UxmJZ76QM9bEqtO96yIwivaTZ5lzeGI6eBpKAcXzB0MT9y/7weZi+xRQzAe02edWIVb2usOmkj7UaU9Yb5Yj2WYOcCOpAKeK1g6HxjAMxRmtVs9YhyrjOis+xGZRI9f5akpZGSbEBM6SVeFfRZlSkL2R4OOopMc54= X-Forefront-PRVS: 0287BBA78D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39450400003)(39840400002)(39410400002)(39850400002)(39400400002)(39860400002)(33646002)(6512007)(9686003)(6666003)(81166006)(66066001)(8676002)(76176999)(7736002)(50986999)(305945005)(189998001)(50466002)(42186005)(6486002)(2950100002)(6916009)(47776003)(48376002)(54906002)(4326008)(2906002)(38730400002)(110136004)(5003940100001)(53936002)(25786009)(36756003)(86362001)(50226002)(1076002)(6116002)(3846002)(5660300001)(85782001)(85772001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR04MB1980; H:washi.fujisawa.hgst.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR04MB1980; 23:RW/tzyHET8P70xeIa9n/y8YGBOfNEL2fj+TMZYHxG?= =?us-ascii?Q?sQ4oDsE8mCev7zAdQ3Vq2+R063h6WS34QKRipwfZfr6reTuWZMHo+jBwe80U?= =?us-ascii?Q?nJ0AB5t146MwplXB0OzsxL2ZIDAMxvHJbivl+iK3AwFKpTGcmO3KSA5sagWV?= =?us-ascii?Q?rpCvDINe6cs5OheukGOrQJhBNxh9+OnSY6ARNdgypiCIPk0XX/gDbhqRORA/?= =?us-ascii?Q?+4RZY8pNMiLpomod2cJWE4qbdTWWSuu77XtJaXtuj2g4VWBnI2xSYc7bOm1W?= =?us-ascii?Q?J+12BZp+b7/LP+QkEwaSKEbMPL75G5xyyA5XUfMexp+QSdOtiW/IJD4tfYRB?= =?us-ascii?Q?vAFDqBemkm1Ti1a7jmcNlFRyuZeCINO4Ztu8XT7HLlaONCAUsSwge4KPv/Ap?= =?us-ascii?Q?5DqzbJfeyEJ9TnjxYpi/thyx9tXjHyExpvjQzinANMUBWoF9nyeRZfk/sZgs?= =?us-ascii?Q?NEG6J1vD2O+BXiHGpTvjG2OmCHv3FLE+5VxtwTcThPASvkrYAsnDiZveFvI2?= =?us-ascii?Q?ewClOb1IL90MwlMlYOaQ49p5mtWhaAlbJX5DoMpoty8Q17EhEwUSxe6gkP/1?= =?us-ascii?Q?PGk4tv/+DytLnsv1W7ZY9QAn4DK4ECXVFu4BjwgrxdrQKAlQMp0cVSljd1Wk?= =?us-ascii?Q?JG//0Z2mSifxgyjSW4gqPS4liAPEff+z9xsWvsD6oKj5RrcLUDOY3FtJXcgw?= =?us-ascii?Q?fR2ffR8Ykr47O2nFLe0dSnVQcabPenvcStyLKV372Cb2yF0FWbaZR+04XMgh?= =?us-ascii?Q?w8gnEIWmVqZYXtm3ukr9KRzAElULxUrxbl3LlXFhm9FoUyQ1/rDfkDK3nIrw?= =?us-ascii?Q?5OKL2xaN3F7tC8ehmyzzsewXMEWHjGXMwhCI5SIOMQ+CUDn3vZOXnfhWC2KR?= =?us-ascii?Q?ASZXXfYdNEiKLnjWLqs/2F6aRdJjmKKwqZ99WfhB1UGx29f/R/WXIClAYWaD?= =?us-ascii?Q?4MQ8PWXemAVLZssnkv8ATGwExG1HiG8cFI/pCiVaYtxZ5hgauYi3wHsf7DcJ?= =?us-ascii?Q?7Cuy0iEXrK4chBF1mHDG1ME+KgXF9sSjadzsdOfL5+R8BxWIEN8psebV7gI9?= =?us-ascii?Q?q3DLUDJKQ1VCDPVhk8TAVmvTTecZfOHhAHPi7D1KePADNMV1TrVTtYrd9PG1?= =?us-ascii?Q?VhN/7mWrNc=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR04MB1980; 6:mpt7+4R2UIA9Yx/1dAE/v7PPay6t5XBHAX+9zmk6Dv71cGm1sN1HFe0nsaAPAOwn8pKkrreiGJVa8iB5pEc/XRwr1cnW/wZgzJ2wlCi37dVQU59oRXSfvwD0DQPGVJqJMaIHVvrNN1ZSDgpOXbvr2cTs8LNpzm1Piay2KYW8I0lTgVLlS0mj6W8D/kaiuz6YI2aP2oRLTLFsEKVbQ/cgz60qF08vbtbAuCArwwwIBrFe5fNG0VXhk0u7ilFwNPXYikN3kVZpAhwEOpLo5USzlvKwzbnOJeQc8Crv4d3KOx2H1KnWrIGqLYzNznu3yvZWnoN8cA96Pw9hGP5u6q0y/ryirRZGv2shVbRatsRPgk0hAfHwV5XNnOb/T1jLCkDJ+tsZs4tj1GYVczm9eaISKp/IDcuzX90iFVh25Rk57OQoLhj33tATljkr9j9/YKEDjHpDuFe/Tr2TaEnOilJqAuQEcHLJELEdLIw6a2HL4rXHDmnsyGgJmS4lOlRAlyvkTuB4b0FTKaoMZe6xG341wAyJoiD3pKHFg3dyPztkuGI=; 5:odHwsHHZgsOH2Mq+KzFBaOyDdpANIqMAsBlR8iOJ3xg/6hlM4pfO+ziPfTkvAv8NEfz48uVC1GpRZZefKGIOn1Dz5fmg8iJCclklcp+gJLjh8fb61YFmSlyf+q9kvcMp/im61J+VSJDgQzpD5mbkpA==; 24:4Mk62rhSsnMauPq4Mu8tf/EPu25OZdOWxMB6/pR7I3GYPXcgbQ28TVgbi2uWcsUi5zPFincc+TwOGtBVMmnXyF8hLR/fe86/9u80PRsSK/w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR04MB1980; 7:4UvVxtHj8xY7bp5lm0F8T0dTWqVkk9Uec/gF3/b4tzzKU6D4pAEIHUSKmfdELRZ05C1JS+DP9GEgx3zYMrUpiU7QjyJs3+ar4NevUWeqrSs+uKnV9Sidrvi1OTj1IOJBNIOUnVv7QkF+ufntimascb2cygcVg1gcVuVuXtCJtcymhjoWym8Fo7gvHBFSraROgpdI3QUadWA87Uw31jlufeCSMXhqt38D1loL7I4KxjbiWRLyeFWuaXEZCtDD8CqlW0jyK2Qss+lbnWxCipYeQhfVf5HxG3akGz9d+3tZfMLOasl2+m1QPW2MjzxTJRmTp/0bss0fQYY+rXWvIC20xA==; 20:e2I+hn/KblklLCvWf5miojGtwMzOOoC1zl0FToU1k30zQvrVhDGjJZ7Cp3rDIGUE5WFoI33th3xU7RAhiv7n2s/6lEE455rf8r3QMwWQKZChqip51qjODdBi41GU1kSAuGwH8vcNbmF2lanZGjGOZxwKdpEu/Ok74Ax5VyyHWxE= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2017 07:51:26.9167 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR04MB1980 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Damien Le Moal Fix argument names and description of functions documentation comments. No functional change is introduced by this patch. Signed-off-by: Damien Le Moal Reviewed-by: Christoph Hellwig --- drivers/scsi/sd.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 00b168b..ce62d2c 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -705,11 +705,10 @@ static void sd_config_discard(struct scsi_disk *sdkp, unsigned int mode) /** * sd_setup_discard_cmnd - unmap blocks on thinly provisioned device - * @sdp: scsi device to operate on - * @rq: Request to prepare + * @cmd: command to prepare * - * Will issue either UNMAP or WRITE SAME(16) depending on preference - * indicated by target device. + * Will setup either UNMAP, WRITE SAME(16) or WRITE SAME(10) depending + * on the provisioning mode of the target device. **/ static int sd_setup_discard_cmnd(struct scsi_cmnd *cmd) { @@ -827,8 +826,8 @@ static void sd_config_write_same(struct scsi_disk *sdkp) * sd_setup_write_same_cmnd - write the same data to multiple blocks * @cmd: command to prepare * - * Will issue either WRITE SAME(10) or WRITE SAME(16) depending on - * preference indicated by target device. + * Will setup either WRITE SAME(10) or WRITE SAME(16) depending on + * the preference indicated by the target device. **/ static int sd_setup_write_same_cmnd(struct scsi_cmnd *cmd) { @@ -1190,8 +1189,8 @@ static void sd_uninit_command(struct scsi_cmnd *SCpnt) /** * sd_open - open a scsi disk device - * @inode: only i_rdev member may be used - * @filp: only f_mode and f_flags may be used + * @bdev: Block device of the scsi disk to open + * @mode: FMODE_* mask * * Returns 0 if successful. Returns a negated errno value in case * of error. @@ -1267,8 +1266,8 @@ static int sd_open(struct block_device *bdev, fmode_t mode) /** * sd_release - invoked when the (last) close(2) is called on this * scsi disk. - * @inode: only i_rdev member may be used - * @filp: only f_mode and f_flags may be used + * @disk: disk to release + * @mode: FMODE_* mask * * Returns 0. * @@ -1324,8 +1323,8 @@ static int sd_getgeo(struct block_device *bdev, struct hd_geometry *geo) /** * sd_ioctl - process an ioctl - * @inode: only i_rdev/i_bdev members may be used - * @filp: only f_mode and f_flags may be used + * @bdev: target block device + * @mode: FMODE_* mask * @cmd: ioctl command number * @arg: this is third argument given to ioctl(2) system call. * Often contains a pointer. @@ -2713,7 +2712,7 @@ static void sd_read_app_tag_own(struct scsi_disk *sdkp, unsigned char *buffer) /** * sd_read_block_limits - Query disk device for preferred I/O sizes. - * @disk: disk to query + * @sdkp: disk to query */ static void sd_read_block_limits(struct scsi_disk *sdkp) { @@ -2779,7 +2778,7 @@ static void sd_read_block_limits(struct scsi_disk *sdkp) /** * sd_read_block_characteristics - Query block dev. characteristics - * @disk: disk to query + * @sdkp: disk to query */ static void sd_read_block_characteristics(struct scsi_disk *sdkp) { @@ -2827,7 +2826,7 @@ static void sd_read_block_characteristics(struct scsi_disk *sdkp) /** * sd_read_block_provisioning - Query provisioning VPD page - * @disk: disk to query + * @sdkp: disk to query */ static void sd_read_block_provisioning(struct scsi_disk *sdkp) {