diff mbox

scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static

Message ID 20170424170418.9625-1-colin.king@canonical.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Colin King April 24, 2017, 5:04 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

These module parameter variables don't need global scope, make them static

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/fcoe/fcoe.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Johannes Thumshirn April 25, 2017, 7:07 a.m. UTC | #1 
On Mon, Apr 24, 2017 at 06:04:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> These module parameter variables don't need global scope, make them static
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Looks good,
Acked-by: Johannes Thumshirn <jth@kernel.org>
Martin K. Petersen April 25, 2017, 4:51 p.m. UTC | #2 
Colin,

> These module parameter variables don't need global scope, make them
> static

Applied to 4.12/scsi-queue. Thanks!
diff mbox

Patch

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index ab7bc1505e0b..90939f66bc0d 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -63,11 +63,11 @@  unsigned int fcoe_debug_logging;
 module_param_named(debug_logging, fcoe_debug_logging, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(debug_logging, "a bit mask of logging levels");
 
-unsigned int fcoe_e_d_tov = 2 * 1000;
+static unsigned int fcoe_e_d_tov = 2 * 1000;
 module_param_named(e_d_tov, fcoe_e_d_tov, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(e_d_tov, "E_D_TOV in ms, default 2000");
 
-unsigned int fcoe_r_a_tov = 2 * 2 * 1000;
+static unsigned int fcoe_r_a_tov = 2 * 2 * 1000;
 module_param_named(r_a_tov, fcoe_r_a_tov, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(r_a_tov, "R_A_TOV in ms, default 4000");