From patchwork Fri May 19 21:53:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9738261 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 272D96034C for ; Fri, 19 May 2017 21:54:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1505E28562 for ; Fri, 19 May 2017 21:54:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 09C2928573; Fri, 19 May 2017 21:54:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 94A9028562 for ; Fri, 19 May 2017 21:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756672AbdESVyV (ORCPT ); Fri, 19 May 2017 17:54:21 -0400 Received: from mail-by2nam03on0061.outbound.protection.outlook.com ([104.47.42.61]:21162 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756731AbdESVyN (ORCPT ); Fri, 19 May 2017 17:54:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UDhO2OUGBBI/c6UQXPrGxgzI6wnZgDBzHeqcnEiF5Ak=; b=MQofr8aJ7os7LW9RU/6B292h/wdsje2wxzl2aWSQotuuPYhW7Gj/Y+JaykE+8Nqm/KZn7lXPLshai+JQVvD5nrHriPU8gV5EGaN9d9zzd6vOmJ5xBsoZpRlubiVtwwAI3HQB0wFedL1qdXtc7LiSpi3a5bI9fxg4S62oCD1GYtc= Received: from SN1PR07CA0033.namprd07.prod.outlook.com (10.162.170.171) by BLUPR07MB419.namprd07.prod.outlook.com (10.141.28.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Fri, 19 May 2017 21:54:11 +0000 Received: from BY2FFO11FD023.protection.gbl (2a01:111:f400:7c0c::103) by SN1PR07CA0033.outlook.office365.com (2a01:111:e400:3000::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14 via Frontend Transport; Fri, 19 May 2017 21:54:11 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11FD023.mail.protection.outlook.com (10.1.15.212) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1075.5 via Frontend Transport; Fri, 19 May 2017 21:54:10 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Fri, 19 May 2017 14:53:52 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v4JLrqAv002267; Fri, 19 May 2017 14:53:52 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v4JLrqfR002260; Fri, 19 May 2017 14:53:52 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 14/25] qla2xxx: Use flag PFLG_DISCONNECTED. Date: Fri, 19 May 2017 14:53:33 -0700 Message-ID: <20170519215344.2168-15-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170519215344.2168-1-himanshu.madhani@cavium.com> References: <20170519215344.2168-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39450400003)(39840400002)(39400400002)(39410400002)(2980300002)(428002)(189002)(199003)(9170700003)(6666003)(80596001)(5660300001)(5003940100001)(76176999)(50986999)(86362001)(2950100002)(54906002)(50226002)(1076002)(575784001)(72206003)(2906002)(478600001)(38730400002)(33646002)(36756003)(50466002)(87636003)(48376002)(305945005)(81166006)(8676002)(356003)(47776003)(8936002)(189998001)(105586002)(101416001)(106466001)(42186005)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR07MB419; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD023; 1:H/fSXbnZbKI0xRNhtiEeQVwl/PN6GPGOlMyHk9bhHkfhJYPTCu8bt3t8JhQfhpDG0MYTV+xGjk593dBVDgyD0LkyNLOFmkLdLaHXx3ERR0mbpUPuzuD3sJ3s7e6c1gcYBKP142T/3jOqNHmnNTWz/6uDHaUBDTZHA2siybPlzJWJYESGqEwDQtaxNDkEt42TdOIjhkEXelwKLC8pwN5Yn4NZ6kpx1FugHmS3p64f3/H/fqmTT4rH5Gwbx5SKlq7JUBW6uuYWhKhXVUZ4B3TFFGKZgjdGF2+Q2zjMUl5Os5i83vpC6pqPkcRblfHWYVpwcC/GsUf3EhMngoAQM3jASl0wzDpf8spQaHqfkAUQ7Wq1J1Es5uzSPCavPoRLIwAQ21beR4RXxWkVhaEoBHXPGzv4FxynRm802ckyVmdF5xrqMLIs2nYmH3YsB9HesmCMl2tCxDsvlWHblSOD4XenVDeW8tJcJPH6pDKc5TWh+x6Ct3p9ktzYPh+DVOAPgx++pwxVlnybi66jbKWb5yhfjho7WM6pypI0KiUhbR5CzshvsSJvlTRxZSbeA8wR6g2BZERaTPz0y6lRxDH/PHow1A== X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db23add7-e7c1-4650-a9b6-08d49f01951e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BLUPR07MB419; X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB419; 3:lFpgTx+zC+JQt1u4xTKRHrE4vMXcBxx+WfDCWrfk9eUfiUeMOyAADhdGnYr8ML2txPN2wuaJNUrpQDPau5hnCuMcUAMEpai6H7GS744fwcGZ5INc6OFR24E9nqtburKu0yzFoso/ofBMAk50RRYeT+zD6w2TKEYsNfJU47ObYhIMbz4+4YjWSVgWpqTRqbatTstnfcsljk2sykMGL7YQA12x40ZSa6navbTjZwL3oRt70glka4NpD58oVZgOVenBg16Ri9c0kdKxXAx6ycRhvRpj4zWQaUuZe0ZdwIEW53e5qNvpNMajnhXg9kT5R8cxTmQkEvLdSk1T2badCrJVQf3oebTubwbfgL5Vl8LcOVgvB0L+U26asL67LVatJP2tojCh2CKQDYoumvL8Cy8RHoFYireKu/7fkCF0Knu/oB74ab0mRohtQCszJmQYNRCFuhx+5IxNl6enYbx5UchBCRCX68oqODFtCZQlSRw+ovcl3ng0AFWTvdAAyVlT+/O/ X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB419; 25:5MmOxbzTpKdvhOlCMedOU5wOnMqEJQbGzQU9ZRFsUMssmKqPeW//0jr+lVN4J4r3ICcrhcMqUupO1uuCGotfrV0rPP/Wf35o5b6AYhRPSf3RM1RQ9Z6x66u0iNhpSW5PYRV2BYCpRHi8qAcWzPIOXf61S3YKnnGf6Qtsl43RB4GLoL3W8fVAjNXsAQofy16j27u0nwynNLKgrumXZkROkEBHlu5DLQ6ZvQkcIesHgtvLbniGnMoTYejHWxg4RGOuGBrwkpJy7Qjt2uKPCPQV/2HeRI4AxzGvNwE8sVAn5yHf1hshvhq087G/K/uwEcE0YXwbCp3NDifFQOEsH4vJP0+faAR5BdQj9oJwOguSYvd+ZPjrMcNkLChX2fFTfQi5EG4fUzih9swNCV/tiEbyyBrbHL5oYmctXnJ3UG9cN3x55Z34U1BNmCHaVg127gLfxtGzgIRCWaA1bdJLvBnCkIXSs+eEIaKDCAXsYdlOf/0=; 31:Zr/lFudFIJVLqmtE2BUsR6Tz4lLjDiTF537+IkzvzdJudH/cO27+eD5ol6MRpQ3P1mCiIK1x5RvB81aamGfDVI+boWtuZf4O65TD8ErIERCslu/GuidjvJm82GXt/FX6y1qjl3LEvDNPJ8B88a39y8ZbHZroeersfiHdkOTH4iymM+ttWj59v7nYTCLMf2Htc7JeQXkBxEIWr+soN7Jybx5qfZq45iD0ZB4XRbmkRXPQ5KcHDxavN/4KTy88MC/9Ukgy09jULUF35hmud0Oo/A== X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB419; 20:ReX3OtuRhMIaBrtv9p5lIhE4S89tXOYk8RDBcHr02gBdjVR1QlXFKeGDbBM1st2LMfwB7Wx5M8d6zjqsOwysOdRjbo6dj8y2zNTLhrh/7It5t5hZ6w6pxSNIZhRC5NpUmSKyXCGos46eLm3710GceVCu7gjC9iF7wOZH8mRwNepxv/ugrRmdK+ubTiXRLB0SIVm/zJEuuSCLcUjNFIwob95Cu73R/K+8sBR86fK4lHnRw2SFKrkRi7G5RxZ7HrEXICkOm0a517Q12qQpkWt1Y1hzFp0+oD4A6h+m50X5jfwSeKvqUT7IeecsXvhBXWHJcoCL7XkP+v9yZqLI2dS/PAS5f4Ak8XRu9NPjIs3t4o5tfsE8GaqwhbWZGW/BVYT4XeUPN6owFEo5mYZE6VyoUel8FvDLHH+ioTC85U1WMESznLdhkpAZDJPPiL4TuL09/u+vgrL7Xr1zQJlocmofMsi4Efdqdb/h5Bke3o/cM1bRfG/hCoBf2Pkhv5lBoryW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(13015025)(13017025)(13024025)(13023025)(13018025)(8121501046)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123558100)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148); SRVR:BLUPR07MB419; BCL:0; PCL:0; RULEID:; SRVR:BLUPR07MB419; X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB419; 4:O85NZhePh74lFwYcbSRj5v2aN6jE/dxOnBH/EIn+W84wC6JMbfMuoA6xnn0SK6XGFDlRDnaBK8ID2XpjRmVjtZWHp7nMnawOQzheO8OpSUtcaYr7k4DE0fNGDY0l+/qUu2dF8/eRMbvdauLkcwoEqR2K9p4Q2i8SCPEc6ndLUebOvKAgEf2Bkn5LVR3G7ivxgoi/L1GcWMbghyPGUnsO9nBlQhwKn39SoGWbIgNoHTxBx/Md9ZHfGQI3SCmfwxSSmOty5CueVUcMSMDSNy828BxupgizSvBDTXF/Vp9v/WcpwUC6eWGJ3k7fYGTnH7ShBzSoJT2pF6a4lvKgvPsj3lVbMgb87YwonCsn/Xhil8WEvPpnKBUMmmMMxQLTIBcFlrcSl8T+97u01Pr6NIQVYvwKK4ua/mk/5Lp6TUtaUVjIfWvVOr1cNPwYmsEBoqw0Iu//TmEB2xpkujJksbjik/bnr+wkEByT06QYT7TIiRloSLaFBt5B2+OO4FkjoNm4TQwGkZ/Z/0B3+aKSK/3VGF+SsvC0yzPdR2ZQcQnQy0p+iWgAvURpECaIkTEjPcplljBCfH9YWRD8RHCn5s4NZCFJa8CA0WbVJJhsv4d4RYCl+6bw6qsnCztFY1Qd7mw2/xtGAP8e0/8JpHvSQMlIPI051OnTdPwoqiooHX4E1YDp6B4p4ejIq2IC7WIN3/7z0/qQm0o0BT5SqKL8Tr5p8NmQ28Afhexp7rVp8fKwf4U8LNFgdMrvVqtih0YX5QLus7r2J7X53SnSxbqtp1uVgXWPUU+38pb2wRH+naFNRcXuAQy+isZG+LZDfbB263OF7ZXqh8UgB6Mii62ReGfMw/uDWHgZgiPPt+tD8EsqDIMnOyBEpaTvbs0M/IvpemqsWzfFPeguhtJDrFPW7iZdv9H69b+oxI0V4o7YY3HiDZ8 = X-Forefront-PRVS: 031257FE13 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR07MB419; 23:+X4OWQ9L/yx9wUV1qtp5qTNASOGyW019Dg2CkEVIPP?= =?us-ascii?Q?GyJDVYf4brT7CWoA85nT2UYUpHDivlqKK8re1GzSe49VVmLx+LAnhm0DmdQ8?= =?us-ascii?Q?bIs+KxI3zbfD3KKKqwMx0wd70aJW5o70tRqK8o0rQHdinEmfkowGZR6nyfVo?= =?us-ascii?Q?KvdbMrnC1KWgD8e929egziHSV1PZpH2hKi3WcyW0f854kXYLZaMjaSLGwVnf?= =?us-ascii?Q?38UrwmVZZNh6MGv4PsHeXtWhqqSz22U75WRM3gIRbScRxSPoNcBn9WmQa/ZG?= =?us-ascii?Q?VDfw13+HwxFcv/mLxRPCROrOVeDZu2ye7Haja+bDIcWTWH8DQ5v+VMvWVpym?= =?us-ascii?Q?95zOExQVX4tsLrmYN3fgQJBnZSROdTZ2Vr+dQqvpiIrdDNcD3Y87Nx5nKgpN?= =?us-ascii?Q?n4sGbNGJFEnAFOsooZ1LJi70V0w+N9IRpoqX0plC3A2QgkQvpG3VRS9cms9w?= =?us-ascii?Q?bfuRpZDVdwwWlYUND/D9XEtR5pxvrB6I9x+ugZAjrCd8piMsDm9KuYL4Kp5v?= =?us-ascii?Q?ru68couXU03d0hGiH4fUarC056lh6nPeqwwNNYnpDAJpLtVjxXTieCg4qKf9?= =?us-ascii?Q?Ww03R+XbRgxQIoL/y63oWzUPYgLPlE31mc//1f31gK3v15RS6PZxegPT5qup?= =?us-ascii?Q?JHbNk41k6ktaHxc9GPf2JLBTsCXMTpI0YajJer68PlTAvN8RbgExFHDP7cEr?= =?us-ascii?Q?gHEdsdXbkISf4HNGFA//OKz01HkMocAOlZHiUgv7+JH50cWHQcslkhdg1UVg?= =?us-ascii?Q?1SKQm/8dimhvk8uAjSm1VN4k5cJytHC4WaPtb/a44QfKLUzq1uVCUTIiWqbF?= =?us-ascii?Q?xZns6tsM30i/tenqkdc0C+eJOk7+YKQpq+3yat0mdC+2iNqftJsD9s5MOgl4?= =?us-ascii?Q?p+KiJD+0HEV6i9dnVviMwSaZ0hWeCFz13KyITv69ePblMATQNl0c5EMxlI09?= =?us-ascii?Q?cTMwwR/I4sDvhMfz3Y3SS0nDuM5NEP8cuLIVVd2spDVO2hKXCqYaKjDntF4x?= =?us-ascii?Q?xTQmv+6rGXmjXIZGh2t3Vgwdj/D3QbNHgr60w+CQM3nwzgpFcSKoIgfa4sMA?= =?us-ascii?Q?n60wGhpiPYf5bE+1L5irOClkuNx57afXSKR8ChM9uMHB86tjUWOmj+k161Qt?= =?us-ascii?Q?Ft0mkesfM=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB419; 6:lKFfChuBBSiy5cxiEIUjLGfttMAp7q6+3SHPDYy9zbeYF/hx/2PZcTVoUOdTzU+6t0P5luo1gqs4+wUT0rdFCGW0K8grmn0ytxphD8uzWWzh+cfH6ZoT414s2gwIIGaVF8glzYhkroARkC9Fg3jDGrSWJd2ltPHWMw8JqB76ukoWKpEG60Q0tn/hHHKhplqBARI/kpjilXmRBH1HvYlFIbIr9IDqo9JLnMrinZ7Nd33FjXaKpHlXkp9sdNgqxsnOsIlg119WcAtsJWG8iPIeePFf/g1rIr5YonLbw05zbg4qbdYE9l8RdHJmosNMfEuYaqGXvqx42eWi2OikPgm0TDWpOBkfNuFePkjOY0JBAdxICjbdNalT80+zzEh4Bm42jmJMJXtTTY2w+95kz4pibLAfFYxeIFthmueZvFmRTWLMJ/7pCCl2U1eX5/TCqDw2nh+w9GkTJ7IfYIX680gC/pMD9dZeDEfbIMsPnPAS7qNuyLPYV4mDR+pO08cHJ0gulgdZAqewNPoE37NI3jBMDQ==; 5:7qJnTcwY2RvBpDc4xoTOq5bTkCyDCgqpuPQ7tzAdKqwfcDZplRLEB4XUE51wszFLSF7GWaNgqEDEiRTmNSvMHRAVuCXGXHq+kbVWHRjXgaTX5DPMKomD3hxHw8R+6asvepTKdOGEHcvFVJdVlqIxSw==; 24:RI2ESElyCr1exfNMjNYmhsVbsg82ublOo4PLQE306hxskaGprDlOb4G5wmNFiTUO8du3ohpdwsCg54lQ9PvSjFljAU8tPLy24K4DHfW2uY4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR07MB419; 7:Goc5+mt1ROpaVBpjJZv5RCU6vgag+UUCfLuMQKOvWxiBJFnR/Taa5SLZKIHFAKqP80S1Qb/G8TBf9aH008EuvSiHf/kZ0DGZFGLrUlM8+GjVpkkgYaMfJ0kdOMy24BCCeWi3FOrolb23vBV8TJN8TvvbTp0vaiypzBfMlPA5jB71hNbT9t91SRjLPl+dWRVULpVarA004YoriUIt2kQsXjkz/R4TPvjZmq4LzuxAWw9g8CzStmHMUcA4z4qqkRH9OApHreo1AoNRF4sN2kctEarpW6I04A0JpBXpzogH7w+BiyE8q4sSlAHVgTdfYlK9kBytu0eXki4Ron/Vr4csbg== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 21:54:10.9496 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR07MB419 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sawan Chandak There is already flag defined PFLG_DISCONNECTED, which is set for PCI or register disconnect error condition. There is no need to have flag PCI_ERR, which has same purpose. Remove use of PCI_ERR flag and use PFLG_DISCONNECTED flag during error condition. Cc: Fixes: 783e0dc4f66a ("qla2xxx: Check for device state before unloading the driver.") Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_mbx.c | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index eddbc1218a39..4127f35b669c 100644 --- a/drivers/scsi/qla2xxx/qla_def.h +++ b/drivers/scsi/qla2xxx/qla_def.h @@ -4017,7 +4017,6 @@ typedef struct scsi_qla_host { #define PFLG_DISCONNECTED 0 /* PCI device removed */ #define PFLG_DRIVER_REMOVING 1 /* PCI driver .remove */ #define PFLG_DRIVER_PROBING 2 /* PCI driver .probe */ -#define PCI_ERR 30 uint32_t device_flags; #define SWITCH_FOUND BIT_0 diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index cba1fc5e8be9..fffa1f7cd8d2 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -124,7 +124,8 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) } /* if PCI error, then avoid mbx processing.*/ - if (test_bit(PCI_ERR, &base_vha->dpc_flags)) { + if (test_bit(PFLG_DISCONNECTED, &base_vha->dpc_flags) && + test_bit(UNLOADING, &base_vha->dpc_flags)) { ql_log(ql_log_warn, vha, 0x1191, "PCI error, exiting.\n"); return QLA_FUNCTION_TIMEOUT; @@ -384,8 +385,6 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) * then only PCI ERR flag would be set. * we will do premature exit for above case. */ - if (test_bit(UNLOADING, &base_vha->dpc_flags)) - set_bit(PCI_ERR, &base_vha->dpc_flags); ha->flags.mbox_busy = 0; rval = QLA_FUNCTION_TIMEOUT; goto premature_exit;