From patchwork Fri May 19 21:53:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9738239 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C27786020B for ; Fri, 19 May 2017 21:54:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE13428562 for ; Fri, 19 May 2017 21:54:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A0F6428573; Fri, 19 May 2017 21:54:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3132A28562 for ; Fri, 19 May 2017 21:54:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756746AbdESVx7 (ORCPT ); Fri, 19 May 2017 17:53:59 -0400 Received: from mail-bn3nam01on0054.outbound.protection.outlook.com ([104.47.33.54]:46912 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756703AbdESVx6 (ORCPT ); Fri, 19 May 2017 17:53:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oy8RtVFcXoMuup3BSSlZg0dhLx1j+HNVUM5eiOC20D0=; b=ejVzKg8LuANTO3EoU1kb4uiajed5WPeRIlr+D3617r1Y7kOjcIrwTVLQeCFgG6xI3BleYDXASr4xgGBK+NjCWrmGsdN8t0HeNmMQtSX0QEgGtGmXAUr0WvT51prpeMg8LvNFYwgIO8/QfCaZbYl/V8fY5VaRR3KE8EjU+GvzQTg= Received: from SN1PR07CA0031.namprd07.prod.outlook.com (10.162.170.169) by BN3PR0701MB1573.namprd07.prod.outlook.com (10.163.38.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Fri, 19 May 2017 21:53:55 +0000 Received: from BY2FFO11FD023.protection.gbl (2a01:111:f400:7c0c::169) by SN1PR07CA0031.outlook.office365.com (2a01:111:e400:3000::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14 via Frontend Transport; Fri, 19 May 2017 21:53:55 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BY2FFO11FD023.mail.protection.outlook.com (10.1.15.212) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1075.5 via Frontend Transport; Fri, 19 May 2017 21:53:54 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Fri, 19 May 2017 14:53:45 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v4JLrjpe002211; Fri, 19 May 2017 14:53:45 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v4JLrjDk002210; Fri, 19 May 2017 14:53:45 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH 02/25] qla2xxx: Remove redundant fc_host_port_name call Date: Fri, 19 May 2017 14:53:21 -0700 Message-ID: <20170519215344.2168-3-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170519215344.2168-1-himanshu.madhani@cavium.com> References: <20170519215344.2168-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39450400003)(39410400002)(39840400002)(39400400002)(2980300002)(428002)(189002)(199003)(9170700003)(356003)(54906002)(2906002)(2950100002)(4326008)(50466002)(48376002)(47776003)(5003940100001)(6666003)(86362001)(38730400002)(5660300001)(105586002)(106466001)(80596001)(189998001)(42186005)(81166006)(101416001)(87636003)(305945005)(33646002)(72206003)(1076002)(50986999)(76176999)(478600001)(50226002)(8936002)(8676002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1573; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD023; 1:OMw7UCW2ttMQw80Gg2YOoP6qTEykpAD79pp00DMS1r9uTAQmlS7lgYvQJk222fAkKXeRid9GkrHKV6IRi4Mfh+ADqfQGqG8prjZblfIjYkI4Fq3n6VUotKz59b9zPRJqNSdpNEAW/MyS8CCe5/degXkdHYpZOEtNlStk86gZ0F6SBER5nvKo4dKZJc9dwVzhL8hC7qRZmZa0QSxEB9CXsrZGpUBctudelqBGnYKtFX/Qap2NYPET4GE2vbGHJ/c36alvqCMMRS5ZqVA3mi2XgEysaE/UU3mEKoiLD4Tp++/OiJMoTJ1JLLG7AOUGUPy1j8KlHsSbQYBBW/bxvlxxtOJZEd4HT83fDiAPkX3DHN+rDufjrVhaF8u0loRsGPJ0dgdh+rPbGJZfZJd9zA7x7WSU+x/xtoGlZibQAQERVBhaYdMdfS82g2t/vYMsde6K4r/ykpmVWLUPZQlhEdEOXnv3q2BTZuvhTutSHcpa08W2DH2WC9IK6QXg53utuCOdcYnp9hOroktTU1hclBKiQHdFcfuZZpk6x15RtG0jHytAoO9N/vd2gV+cII3/Ixug0IETSi0qTaKtWyWYqQztaA== X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PR0701MB1573: X-MS-Office365-Filtering-Correlation-Id: f3ad84d4-682b-4858-07a9-08d49f018b2e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081); SRVR:BN3PR0701MB1573; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1573; 3:OD7GAHScgJNDduDrTKYMW1VOak7Rw/l/elA85oM96UckwTVIWqgsiKcs3SbmJpRe7GqHbHOqrkLJDxQiuxYw+g0CorCcwYhYAGs5od49xJpsiYWsgT3WjIM5yg/pVeRcDfB3j9yKqiR6rlmPBUaS3b8hDTcg4qUX0s+PaxZns7Uydjm3aVXKJuMSug84HDAos/af/fnVVtUmpD/Dsz0ppQW6dDfStv7nHNDyErC0u5xh/2cWfi4Acms3TwFnoWbf36BXJe4GUC002o003u/fUD4qFTmnhtQzON2MiqQjZM1mg4KNrU/C5tq3awFAJqUnlbQrMitfi72Q0eKXzomObo3HF6V8q+ytDbTU7RymCtd0kvdkg9KZPTDKVWiSa5/t91aDq/kInQh4hoWykqDQMqQBImy2C0o0/ZJC6NRgYtUr2YzwXYkKMNidlkfC5ueOT9P/irQ/3UWNs9r/+Ciuaw== X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1573; 25:KcAdswxaPLON2mRTsXLUSe1E0rGj3ygKCsTMe/eJy3z7cFJBTqHk/91LLGS4kDs2nr9+nyAHZ7iD/Pe6rW30KW3qzBi8h4V7YqixMjf7ajoZbORukbdFNaajmb+6WnVljf9xAd/yWZsKbU/7fJSt2qApzSHAb9fRloqR7kuUXHnz2p32Qv+u+3NUUcHYBMuNUrUaxf23wj+ARPuvMHIisCk9HwlC3z2An98No0o1Uj3/UUTNtqc24g3e02E08xF0eNIYTok0Fg4bn54+ghYpNKkPbFCOaO9tEqW6BmwycTIR6yvdxCdCfhgKRAMPoBaDxNPUstN8NC8skkwb+fPEKDgqfWeQ+vTmReHEyHlA/KoE3hMB95MUa5eYhV8wXjTKywsoCGwwvQaSWt0X44ZeAf3vHFoAGk96FCvrXwr05onVKF01ZrJxTWBB281QgC10NX5sf6v+/szclIHF6T+2z8iE8BpnkD/5SF8pwWskMpU=; 31:0nQyxLqc66iH9IeaG0d+qzoqhWkPkdrD8NLjXXt6/9w+WFNOL4JRIM557ME6ezA5aq6/icK2hxKRY1ZJmjqQQ+7nPg3VQFUIPHrQQqkkek+9pwAvHDiv2NmF809DpFq0l9jxCorGALatF/KqcxqdUn2IqkA7gBK0VGp0BWcjFaUeMdb831yaMS9ps0FP3FnSsCXUqWHkTvYPu48VAofW0FgTcepfZp116MBvBqv4vb/j6qh8YgaKr55yIV0YrQG7XRgsAhV2ZyuZwqcfsIEikQ== X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1573; 20:zN4c29/UdVmxcOTE3oKCBGfoDGb4TeYFvKL1pr6CpBvtLz3GhK7m4Np+Ic10ab1ucUMZvGMlKtdKWdJrZHipy2+SPR8aWhmP6/BMPZxacF3uM3zZ13MK84hbjDS3pViLlu5/BWKAAA/R/fWvFyM3IZEaxM+QVAuMCmu9DjyltwK//RpLdC6cdJYFyrYkwUv6yxmylfNnAW8iU3/zHHLpCm+ORrqnIP6/dZBMmnd2skb38cpkqeKokRkhGqOAFvmmAeZtkhrZ/FR2aBCOTF5qVRbFSjt5rBhXNg2+jNNNPJCbe6LqO0zrr3i3Hwuyrzeg6burkPa53UVj8i4XHyYexv0qF/j7pnO8Bg90aPB03H5+KOzWlbOZ06vKxCCksr/zw78ndwhiUWq2ugAKwpQQnRE07IIAC6rHTpCyg6yFjMe8VE0+znENi+GDvniVrtKHicdLocDgk5pOUAFGMk6xnzxU0Eyl1B/URX3S7ZFOVuzDbySxisp0MRP5evPCJcWW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(13017025)(13015025)(13024025)(13023025)(8121501046)(13018025)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148); SRVR:BN3PR0701MB1573; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1573; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1573; 4:jJMx2QZwok2AB50nIqtdzFYyB9vEF9zfBlBT3aDafPMPDSe29YmhljUgP+dIMF6oit8P5FF7tNqJcCk0wiZMp52JQiitUi1CEc1HwPUysyUD8ua2lnriaIuXRpGjmcHfyBbGA4Z0n6J/XdsLUH7ajfwI39QhYg2HTa4HZUwN3Hsrs5Y+bKlsZczAE+k6gsgtbjLO3qJUrdudXtPSZt9ECIEgJWM4NmXjk2m/sPp2hRLZXDs842bdC1Xdp5fqUBOowI1sZ4Lpximj+I+zvi0oP0lhqG09IwyGbUaaMTICzQrBo9O3SqlCBpPCgfeJj5sMgIdWl4J+5jG7HhvrmZk+oFwrrG1wcRNqCdxbl1XteJB2Ldrzdw9uaOEMwSu+0ZiCAdPbekp8gXGqPd5q6JtYSBiLBRZX3ryGrIGeGL6GiyuLaId/I0jCCg/B1tQ0WNHFlI74AVEQbo6cDUXppYB2cABSaT5kbMqdRv7krKCT0qNJBU/cvgsCIRur2cqeottuExDkF7pyvFM3iKAiPYxA1CWRjkDo7gAK7+7js60wjkRADjg/QbpNi9BLQPbZ0RxL1wGpW98Iyi/qtx1DCRiKNumf6QEgeN28h1QwZY1zrjbbxPeXqCBTPTz90xYAKEPqOD2Ye3wzpo3ltDgAyw/YnTehMpKwvXykUv+/PIpch6lvpWlTvTAyXGoZDXIehMKS4WPZgRAYcNDmEprH3NBozuPhfFAPyuRbc2vEesm8tPRkEXTHObpy1kIUqSBKvr5gytKBsj/0rlUdPkp8rn+ajF1myOaF0SQGt/3bqe4qnA5xmgX69Kr0S2boUhZeqjExsYgqCyhrhHNhd0SnkqnuhqBuccq9DzBeTfDyCVPcQy++Txf5WMQ6LYegtqukcGQEiHjXvX6uDEQ3j2AFd5n8HG5A6aWziDj+T5gqjLT0 3hk= X-Forefront-PRVS: 031257FE13 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1573; 23:yckreelNklTwLEJ6LtbyoyxDA9PHz/OrDWu0d1+?= =?us-ascii?Q?frxXlaSVPTxunvN+x2ncAHRgbjhLB4JGXzVffdx/peLI7u6bAoJAyO3ru5Gt?= =?us-ascii?Q?BDP3eXHRo1vmGa58zrEqXkRlslIXEO2PZBT8g2QUW4lhhdKu7BMbqQU0C14+?= =?us-ascii?Q?Z5sdr73qWUw3l2ODgF9g6PdeTizGsROV8AROyeb4ObsjnyCILJ+m3c62/B42?= =?us-ascii?Q?goerjmbWv0HaS0LQig1e5dHvFP1ttlDms9OgRZnHojkZ3g4qu0aOhNO6TnSR?= =?us-ascii?Q?FZ/XdKmPtVa70eFczQS80mKyOXbnurRfuu/SZOP3x7D9F+JdMYaOf2VOamfI?= =?us-ascii?Q?4RNrKQuIz3AbrdH12OlmYSv0Inxk9FwgBzFmXknTBIv/yxlQbwVXEZ7RO9By?= =?us-ascii?Q?OrThX+Xi5loRl56/J3x+OEUwD73DncQ+kB+1qsENQHuCJ+0b9AGTPfPgmyEC?= =?us-ascii?Q?eaVDmKU+fjsf37oHSaaViuxxzhRI5CnyCxlkWm/P8pBql1y+payaznyku+DS?= =?us-ascii?Q?efkocItUCyI6Wewz4v8R54HJUCBT1ml/Rel3s07JUbA0x9BWDC8rT41sYjxq?= =?us-ascii?Q?q5z81jFJkIw8Inae9EJVZcam3syMGrLaaKzbHThSQ6oNTFcagZWaj5vWJSWM?= =?us-ascii?Q?BCgFrvCkcNBzP5AlE2cCiKCh7U2EwzsNjNKBsSYWA6irRHJ7G81q1uelJNq8?= =?us-ascii?Q?UpXTrYISKi4w0/FR9F6i02yrOc8OUf262Sbnv/PMAjtl/xV8Yvkm6xLOYzVF?= =?us-ascii?Q?gEUZBELMipjhANpshygd1EAQBRLvX5G8oOUBZz9S8fvC9CiZeOu9Lxrtkho1?= =?us-ascii?Q?6RRjMzGaPpA+pfZRi2l33FLr/qTARvWWc4NhF1zohZBM9g5rAEqsBtU2Epd8?= =?us-ascii?Q?feDAnXppt8RhIsZQ7rdje2cjNcLRLVVyYC6uPlpGXfsQ4onY7rXy7FaNAyMe?= =?us-ascii?Q?JfQDgcyJUFyPcd8WkPLUrjrAWjqSAcwMUER909sIQDla3OukALwHOs1IN+VK?= =?us-ascii?Q?NgEUOQY/JqidiwZOqMReNQAGwiylCAgGdZ5FaKLhNScbgb/t6ioixTmpyEod?= =?us-ascii?Q?ubHg61bJKI5wg0p63HWob1pS3nRmP?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1573; 6:2htNP+vr1w1I1kM2P5Ep/sZYNqDsGlztaHRgeAA8Gv75kbbMw3lyjR9KgCceyFm7YcrAzJo6kh1WD08dg9QOs8shZlFALXpBQXgmGi+c/w9Ljd6QM1MKji4N2qDpCmigmHkDTuAKj5Zp1QkK0bAEJX1c1eWg2VZdF8j+sTEmLxXyih3jBpRRkp23132tf90oONRbG58ee5f0+8n5s9wZiqKI/IE3dkL1mO7eQlk9l0tefLpVpfr3ecT5Gykzj3xt3ODceumkF4NFCIYqTGCXCNmpSp5JmFT4d9p5LwtHWMiazYez352AfNfZafJxfSFxYKbRrQp5iTLXWbTUSN8nTtxxEqezxeipzddd6oYhgmFSu/UYTIM1VGBpg8t92w+sUKqnm1qDnjMJCSbU1QsJ1I0L92lV+wj0AfqgluVNq/XRXr2WScIDIjTVaxoeFUlDQN54jVA9DkCikUQ1/cbO1s53uALMjJQOYjR/Ufl3kLm2cZ8iRGspPEREEDm9JUul+HSHYg6Fmqa11CDVjGbngA==; 5:t7LO1ga7FEMFHr/N0jf+iYiMCvItL2iB020MfTGo9Oz5yub3KbPlx6xqbtAcKacYlUt80iGNblufXsT4yVSUe8LMA6IoaYLc5kAZJzBoGZHMCBN81Gfo4Sllle8QY8vsVJ585xC7NBhOFIJVT4V7AA==; 24:wxoliBvvabTzE2dOLeOWUnKVZPHS42lMG0/wSY6d80JZ8OoY7bEaEE0v0uE80r5FTXXLBQVb3DFaUMibRXKT9POA6EZTHvaODq9sI6LLxZY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1573; 7:KBbkOIXI17trl2I4XWoUA8dj84zSD1iLLGffQrHsnWsVQrifNWAGaSg+1hiLofZNBxnS8s+yEbV/aVTkTP7ri4Ic9Jx8Q3sVmp/mO6EsAQfQXsytE750vXBrlEM8NpRj9M/gRkl1NmUHJZ+3DpmhcWOdAFsBmHDo8obUt1jeC741WzjGToE97b7Pern1wr+02F3N/cn7ed4gW1yDc8aAEW/eJqEekBK1ueie5yKn6X6L05NlWK4PaF0dSv8FnfC3H7E/1qYP/x/WIwqBda+H7Kh95gD93edO3SxiXXmtTU7Dz4tjYKe/Yc1xhPdMkMns1ycTJ6IrnuaehzraoW0HyA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2017 21:53:54.2731 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1573 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Quinn Tran Remove redundant fc_host_port_name calls to prevent early access of scsi_host->shost_data buffer. This prevent null pointer access. Cc: Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index a113ab3592a7..12fea77e31c6 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c @@ -3676,15 +3676,6 @@ qla24xx_report_id_acquisition(scsi_qla_host_t *vha, qlt_update_host_map(vha, id); } - fc_host_port_name(vha->host) = - wwn_to_u64(vha->port_name); - - if (qla_ini_mode_enabled(vha)) - ql_dbg(ql_dbg_mbx, vha, 0x1018, - "FA-WWN portname %016llx (%x)\n", - fc_host_port_name(vha->host), - rptid_entry->vp_status); - set_bit(REGISTER_FC4_NEEDED, &vha->dpc_flags); set_bit(REGISTER_FDMI_NEEDED, &vha->dpc_flags); } else {