From patchwork Wed May 24 00:33:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9744713 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2F568602A7 for ; Wed, 24 May 2017 00:35:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2365728867 for ; Wed, 24 May 2017 00:35:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 185E02886A; Wed, 24 May 2017 00:35:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A2C2428867 for ; Wed, 24 May 2017 00:35:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763466AbdEXAfE (ORCPT ); Tue, 23 May 2017 20:35:04 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:11374 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760621AbdEXAeb (ORCPT ); Tue, 23 May 2017 20:34:31 -0400 X-IronPort-AV: E=Sophos;i="5.38,383,1491235200"; d="scan'208";a="21105003" Received: from mail-co1nam03lp0019.outbound.protection.outlook.com (HELO NAM03-CO1-obe.outbound.protection.outlook.com) ([216.32.181.19]) by ob1.hgst.iphmx.com with ESMTP; 24 May 2017 08:34:30 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=aDUhqQRmY6GG5XfCQWQ/AxY56gg7lexQ0QPzFeO9SJk=; b=Y8/NQ84HXJRdEAtuuHBodlFSlkQq3HoLEDdaHWKPg7NAi1uBhEKOS+cOAzYmAp0OCI6+MJvmvFpEfRnXk+fSGW0Ei0Vq6QoJUY+0Xsoeq8VyitRxYXgn+dZcrBls6K3OZ8i1l9ttEyVFgOjxkJlfguF8ueYmGhk4A699t2C9Vwk= Received: from CY4PR04CA0030.namprd04.prod.outlook.com (10.172.133.16) by BN6PR04MB0501.namprd04.prod.outlook.com (10.173.201.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1084.16; Wed, 24 May 2017 00:34:27 +0000 Received: from CO1NAM04FT042.eop-NAM04.prod.protection.outlook.com (2a01:111:f400:7e4d::204) by CY4PR04CA0030.outlook.office365.com (2603:10b6:903:c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14 via Frontend Transport; Wed, 24 May 2017 00:34:27 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by CO1NAM04FT042.mail.protection.outlook.com (10.152.91.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1075.5 via Frontend Transport; Wed, 24 May 2017 00:34:26 +0000 Received: from MILHUBIP04.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 46.43.45291.115D4295; Tue, 23 May 2017 17:34:25 -0700 (PDT) Received: from milsmgip12.sandisk.com (10.177.8.100) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.319.2; Tue, 23 May 2017 17:34:23 -0700 X-AuditID: 0ac94369-166ac9800001b0eb-f2-5924d511f743 Received: from exp-402881.sdcorp.global.sandisk.com ( [10.177.9.6]) by (Symantec Messaging Gateway) with SMTP id 60.A3.18148.E05D4295; Tue, 23 May 2017 17:34:22 -0700 (PDT) From: Bart Van Assche To: "Martin K . Petersen" , James Bottomley CC: , , "Bart Van Assche" , Christoph Hellwig , "Hannes Reinecke" , Johannes Thumshirn Subject: [PATCH 08/31] sd, sr: Convert two assignments into warning statements Date: Tue, 23 May 2017 17:33:57 -0700 Message-ID: <20170524003420.5381-9-bart.vanassche@sandisk.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170524003420.5381-1-bart.vanassche@sandisk.com> References: <20170524003420.5381-1-bart.vanassche@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsXCddJ5ka7gVZVIg54uUYsFb/ayWaxcfZTJ YmM/h8XjrhmsFntvaVt0X9/BZrH8+D8mB3aPaZNOsXnsvtnA5vHx6S0Wj/VbrrJ4bD5d7fF5 k1wAWxSXTUpqTmZZapG+XQJXxtXHQQUvuSvOTqlvYHzE2cXIySEhYCKxbvpPpi5GLg4hgaVM EqvnLmGDcHYwSrzvnMEOU7Vy0RSoqo2MEkvuglRxcrAJGEl8ez+TBcQWESiUuLStgxGkiFng NqPEvrXtTCAJYQE/ib133oDZLAKqEsca/oLZvAJ2Encbz7BAbJCXOLtlJzOIzSlgL9H1agLQ Zg6gbXYSi7ZXgMyUEFjEKtHa+pINoldQ4uTMJ2C9zAISEgdfvADrFRJQlzi5ZD7TBEahWUjK ZiEpW8DItIpRLDczpzg3PbXA0FSvODEvJbM4Wy85P3cTIyQKMncw3n3ifYhRgINRiYc3wUEl Uog1say4MvcQowQHs5II7/INQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK852SmRggJpCeWpGan phakFsFkmTg4pRoYJ++5l7Te06BSd71Z+En2Y8cMCn8rbHt8vEysoy78+CbJiS+VZrVICWS+ qquWaLj+8n7NleNad/Mym9irH96UvORXXZws2WtyOuAZ9y3trJ/rp053KE6IsPm2RYJ9M9dU A4fr7xYs3KjNf1Hn45aNLEX75a7bn1y/NfpmR+I661V1X7j45vS0KLEUZyQaajEXFScCANsZ 4Vd+AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJJMWRmVeSWpSXmKPExsXCtZGTTZfvqkqkwbcGW4uDP9sYLRa82ctm sXL1USaLjf0cFo+7ZrBa7L2lbdF9fQebxfLj/5gcODymTTrF5rH7ZgObx8ent1g8pq05z+Sx fstVFo/Np6s9Pm+SC2CP4rJJSc3JLEst0rdL4Mq4+jio4CV3xdkp9Q2Mjzi7GDk5JARMJFYu msIEYgsJrGeUmLidB8RmEzCS+PZ+JguILSJQKHH/9Gm2LkYuDmaBu4wSU5/uYwdJCAv4Sey9 8wasmUVAVeJYw18wm1fATuLCsbmMEAvkJc5u2ckMYnMK2Et0vZoA1MsBtMxOYtH2igmM3AsY GVYxiuVm5hTnpmcWGBrpFSfmpWQWZ+sl5+duYoQETtQOxusTzQ8xMnFwSjUwTuo9O2XLwnqD u38bFH8IxEUbvvtYYrysxyHfxkbzx7alxRz95gfNN+yTfCfUcjngtVX6/Yg8oamSh3OlVntJ hbLoVefM6LKS3T1l78+TP5t+eCbJXaj8e6Nh/QL7g896OtN7ItxcpYNennpat/vr4S8evmnT HWzljaW7ebN1OrksH7osY+NWYinOSDTUYi4qTgQAZA0pEcwBAAA= MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(39860400002)(39400400002)(39450400003)(39840400002)(39410400002)(39850400002)(2980300002)(438002)(199003)(189002)(9170700003)(54906002)(1076002)(6666003)(478600001)(81166006)(8676002)(53936002)(356003)(8936002)(38730400002)(50226002)(47776003)(106466001)(77096006)(76176999)(189998001)(2950100002)(50986999)(48376002)(36756003)(5003940100001)(50466002)(72206003)(4326008)(33646002)(2906002)(5660300001)(86362001)(305945005); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR04MB0501; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CO1NAM04FT042; 1:lAUyNeweFd5AwNNttJi3JgAnDVlDrdmG54dc/1gqK9W9CPjHZWzB/ThWfVwE6GSJ/GXRlM0MPuaOXCx/AEbP2i5se/0YMRK6bSITkzJGPZ2ks4iGJl1y1lO2fh/zyZM8FMlLlN4vAF0lj3yZX2bKSulklYGY+nJi1ptJ6pcm056JGkj047vJqw8g6G4TJrnCOyFpSrmtyx1N9vWKAMCD+omV+QpxRkJKtMrDP0/AUHl84dzdDEXngW802ZmLw7wIqwHxVoszYB9bwDG6gtSbZGJAbyRjc+LcSqCeii5Tohz1l5HxDA53J74bYkiOu8Wdr+3B/ehQSm8XTJfcIjd0XngFlC/7SujA28EdsXwuriF3c4XkF6H88QznKVZ2XjzNvisNLd9nYL75Uz2B0F7HDTr683+AWKZngtL2LqoITK99e6AhdpoB/f36YXmXbGjCFJfWC/wqkOZ43jsMhsmj3eGS0qJkJoAEJbh5UhUVygIuvLy1Ba3QeopFwU0GYx1wEUCcjJYJXeMensQKnMT3ZnDhYRJY+aRz7sEB0s7d0fs= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6d43b4f7-1228-419a-5089-08d4a23ca231 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081); SRVR:BN6PR04MB0501; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0501; 3:fbREm590biSEZ32dngxyE2AbaMk0ipfWZpAU16znzhliIzh+wiX1J0F8KV92SqnU1YQgoesd3k0sbWBTbrmLy8VJHBkFhGQBKeWkKa6LUctfKdbogDhFq9Hi7mn8zcF8eMM9lv0wkt85RgZueniTLMYsN7eOT/VUZagl54c/oAJIch+plYRWvKYxHhkyJsSIvnDAi/on9Plyy/UFtTkO9kiMDK4ACuIq6C3IcnIXHaUHVxxLTymRUdXsVAsvHf8SWpJM9xiGgxQzag14aX4W7WmBwi5b6cO0K0PzQY2/yEyVmCcqUaseMh6Pt2DqoWuv85mYrG3VNtOzREUsZ2HUOHaiQis7G2HBD3PL2BVU9Dewj7k/L+USGz7VHE+8U7CvO0hysYnHIdkQoyC52NPbswNustNkhPha0VLNLQkuJMruNNElpugVD6ofKPS5J5uTrWipR0YjqKfQG4uyEoxFaoa9Z/qUp6IpCiVGfRuylGxSgmaXtDkv7SYNoqf/I2Do X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0501; 25:51wSssaPOPuJpmoKlG6+xNLRoUAT9OCM/CYMBeydUehmEh0QRd4OLLRDgAs/tq+LVEX9JVfV1Uasy9rrMORLoi+gSazxShoCALTcpTZ/QY6U42HJVG/mbHWrjYLcewiR5T1yeF+w0JToYBe85VkxdmSYV79ocHMiPMc+EyvJNUj4BcHu621RZe12XnsDHyzYkY0UoJlNg6BxMeF0hO5iWyLLzE0FDnvIdDG2YghMGRJcQ9sGkx1QZGAxrYCUeE2q2ZzTSZ17NDVksi1/eSMyG6ZvBc8LL9O9iCDbxWW2y1DDaNRPZHpqDFEcvq9xSJgWqIPD/E5ecaxPjM7OdfHNiUi7FErh02HZGrH/bg01VRxkoF4MeLRdM0VLLPGtOpNnBAHok+u80mnCulifpcOSLqBrrBuLNK2Q9+cT/EiEnuBCOw74kJJET/rfoqx6sm+ito8FhNkAexeWX395Zgx6l2+AeGuzGJZPl9XkVK1qDkM=; 31:7HGxKSklJQtjo9DXdcXCv5ukwuLEI1NwspkizRSE6EmqlsV6AHu/BzyDUKjkWZ58Pbp5oOAKq7kCxUXLqpV8YdPX7O6wrxob3TmxvrJVelviZqzpKiT0YGM5zPkycX1Opt8gaa9Bl/gk6Hn2vz5w9CKVEM/TeZz0SX0HoXZ9eUuNKH147M8RINhK41urnQv+I414AuM9I8NqwkJYrlbMhodKA/S0NOnAoyRpIaI6ILtxfxIwh9JUDyHgJJ8+P+Tq WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0501; 20:1jCTh6m2zcKSWsPK5ZWYH+Baktq8Zo8Cz9oxhHTHA5qqp/9iPPOsHR5P/a210WJESeNj3JmBFhVWae2s3eVboczZ1rHj5go8otCaZKmIDeJlTxFL2VkjkBjgJhPEoYtq2acrIDO6reNf8KZhF7SNDNIkPARSvflpuHydma2n+FcaC1BMe/fJSyTq/vKnDK5Fsz0UC8jpRnRYuGh2B8lDKL1XpUn9JbUzoEqTReWLSAm38jiXVZOG4IlCsh3BlpbtNfqnrB0bR4FB7NJFOsfkZJei71iEdjGM+BRULsMkGT4C5JZnrL3i0CGJ1lCAZdEb4ax+9tIdtEdQNAp55Ekpdd6qgiiqRixXv3hVR+ElcZKHCYoTMwcvHoQhSZTSJzzYLMb28spH7/4gAiNqTREYL+ZurahqyAwHFlgZdM7YwpsITCylMCPNJX2YBEyf1jfYrTJuTviuhcAPADjTRiPYpnvs0atFkdoiFf/2KPtArR5DybGPbqH/MSYzKVSabj8o X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13016025)(5005006)(13018025)(8121501046)(3002001)(93006095)(93004095)(10201501046)(6055026)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123558100)(6072148); SRVR:BN6PR04MB0501; BCL:0; PCL:0; RULEID:; SRVR:BN6PR04MB0501; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0501; 4:QZlQmxiEuIJkYIaxeEXceyv5X0U0Ns7w1NyAwdcXvp+Z1/o0DJXq4Lrr3aGqfoeZv6Wdp+aqfV4Eg7yGI8WHIdwo9IpEGhQj51gcsxdq/zgKcY0AC7MywbFeVBoaopHTvj1958tkDzxUuuejuYBbrK4lYTmHKLgcYFOqhGxxHvslI2IqcupZv4M+MB+9FlcDtIZ+ACdeSSiXKS2vV9H3RhzunPRdB5bMP1KWwFjuWRUeVJNySgfvetFC8ke+btPMJDpB72g+QdMD/I0FvNn9Ftpkjq6bbrQo05VQB17RlHsRgHbJsz9suEcH/VZEXYpvxLpLilZ+/IDRIphw5uom1z9Fqueq0+YKeOB9xwBaRF6FNbRzmcWkpKgu5bHNIVrCgbm2tJoySeT8xsm8Ju98x96JwLX3JeyXFn7DlGypwYmYI8/hmIUbAVzcVvdtQQH4V25pSbNKBcFOPRdWaGpfLervH1+s/dK/SMLG7vF0geh1amSSQ0f/dtAEDlaPeJDJHC7vpLjDmCbNQKkjgPHd6eIl0ZDPsqKYZHVznqw3EP42dMDTawqStfEgSFYpVFdn5uBAWrPwVRUHJG9ewYEU/l3IYSOIMozpMP7lI5Ej6VIqWkaMAonJQecqsHVs8JBOIU1fkW4bDtS8Vt/r4K/tMPkLGf/z3t6lwFFqNVyWORKdM4DSJpSk9Vi123E1CYCOUo9sNOSycMp58LWnxmW0DwRl3AiZdxZRTdlrLPCgKkB7xVDmp1bJwhB5zSYpW4VJywGmjhCNd1PsQRxcbk6bMFYX+dYKVTChB5JeGBiA70pzJ+BZLuwKl92TE9H0R1u/pyvHy2V5YAaUDQsQrXMlwGIEDPZ7aOeJr8LaO7+0Ykr3vQPWsu4uGtxNdzRoU2vl X-Forefront-PRVS: 031763BCAF X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR04MB0501; 23:nZALIFEclK3HGMs/OkF6dYajb0fC4a4bLhu3QSpJz?= =?us-ascii?Q?phMvo8S4NICt7jfx/y0ElKPM1QFUuE4PV6EOlPYGYvAA13P26Z0YfPcYtmoQ?= =?us-ascii?Q?HlbzGvMUg03/RKP3ofDXAvlqIm0Z8m/bY4akrCRu81n+QwRfP68Xc7fbjv+Y?= =?us-ascii?Q?lbDAh9ssx9RSs5KEFWSwsqWBquwx8/1wK6GM4pEuqK5vntl/ya1KRUvK1sIJ?= =?us-ascii?Q?r1YoOor277g/5miZiRUqp8Ajm9viWda2aL3nfow6Z9Euc6PJ5n7BR1EOTost?= =?us-ascii?Q?fFuRibKKHZzlM+9ErobzK2UJuH00QiKnE63JVhJ13hEVi+24K0EtdBjsfZde?= =?us-ascii?Q?Mg8uECXk2tQV568R2KK9dHWuZARMS5zOt99BhMnmIimSIZG2f+KfFLjNtCl4?= =?us-ascii?Q?VD5WoSr0fmUyeCFKin9cfoznuSkyVsNjSDZG4ihwvDKIkSpICrS3hwjJ4DZ+?= =?us-ascii?Q?4AqYHZxj4YjTVXujUHe7SmFPCnwS/eDIGiy3Xg3S+oCkWFIBtJE65IyBbUEd?= =?us-ascii?Q?yuBHb/ULFtxZOTg4u1PQYBZLzUCFFzuXDsaJuuvLqDL9aTNUWiZGhDBgEHCi?= =?us-ascii?Q?3xkMJqrr0o3lu3DxJsXmKkz4mFCKluZoNc7R1wrOP7Mp3/WhcNLoA+oxGmX3?= =?us-ascii?Q?Shq/d1xpu4FGOSUMfn/B3QvsU8JeeOhoi5/OryMepcWy8o5gQYYjoqj5AYuo?= =?us-ascii?Q?6ILtRdztMx9MUo0gRZg2oFDnQzMMXlWwhgXeFM534VDAZ23pAfqrr1Nbkq4k?= =?us-ascii?Q?Q4ExVVxkTu7gQsr33QJCrjrmOihKnCjHZA9QXYpuYKkLJ5aFfi+pP8FViNKV?= =?us-ascii?Q?MLA0dGiOEZBogAo3K4YnP1WdNz4U095UfQfL29Lu3RaFaAt0ks4eomMJZojE?= =?us-ascii?Q?ZSGhp15nfBkVDJl9oVtbOwZHtHBaC1TibOf8rFCrI7i+Au+8Me/UIOs4ZL/n?= =?us-ascii?Q?4sYbfr1Jx0T570ConkiuNlMPyer8NwBEkP+r/VgneA1MpnvsD6agURvcg3Ao?= =?us-ascii?Q?+8vvXFBNtqxmjgxFp4M+1ZilaPUzdC+W8yd2pBBHWw7UWBlChuUeNGytQEde?= =?us-ascii?Q?uIDBSU=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0501; 6:z6SyzGYpGKHgedaWbADttZXRbH2WkvoFqU07o8ZJm4yCIe0o/tV1xF0L7jhuVlZTFHQHp3911EBjE9reKnYMZz9IOYrQ7XrxEw1xUH4iax/ecsKev/VLbFt+fVZPtPSeVHanCezL2KYFx04LOl//UoAMc4GKjfEcWRpWzDGsU6v51a6dGeOh/ZQw6an1MMYjNNe4Bt6QK4AhlG3a+0kd7lwc3AJli/xcMKon+ht/6ONgxsBOCi0woNwE4AxnjOgKBclEc6pomlg0mu/2xXb92isQvshE1Shv2JjfAy/vgWH1SMKhindsPVS4aoOdBQLiOkVXkPS4CYDmrOCskJ4Xhc6GW+Tua+aGFSbjvlCElhlDjVgS7O4QHyGuIZw0vu7wuV9keIQfM8hrmePUCW1I0pSuKTeUdxyHSrSSgTXBN35V9Ve4SPXgjBUPNiQEML3NaEsMhp0bY+Yh97ZM4eeSunUFUFWABASfEN6CpxFniCxFjbGDriNoW0NNBdvv9M7V39c7I6BBd1VwXK/QNozG1B4aln+8lZBRgTqSLKLCnUc=; 5:xNMxCkWRWIucmXjtaDotGX55UGmfICbPXGejVRbwgZ9aLPocAT/M2DroExA1O0RMoHB+oOtuTKUCJRKfUoTQkI5AqZTO3FI5H+o3iJ7xy2bG6V1IOrS+RsTGkeUE1CdDcaxlclany/+WjbLKTwriSQ==; 24:R3JEl5pCxg+ku4BNpQ9GFy0VLFilcFcvt6AEF9O349oH0HC9x1BGpHXRavfc/MF6gGIPAnV7UdXBYIt/5MHUOZOeWIlW8wg9xChQTOCW4ms= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0501; 7:shkyuHVYVjnzdBwBwzEo7NIqZH4Q8U2p4DIX8GN9hVMNO8xVTTJwjU1zXtRGSTrBq5rB2BT4B8rI9zMBuoOKR6+hhJ5edijPkyQt5/lFiUDy1MeU9h3mI6tpWaOOeHJuJ3BjCV986RN5jYOInVv5qWW8W0rvOz8REcpD99++xeYjHmgEfh2cmEtxzCV2r/352Q567NoDmDgNhDnB43FJuK2ATuEDLbI/jFZ4AVrHMjFP07hOwf8obPNuwC4tnN5mnxI/mzreGDMWpIjSr/mWvCHf02R5morONeeuQ50np67fmaUCEsNYKK7sHxYhCUIBFsMhfR5m3+Fjyt+qSgBuxQ==; 20:aMqD1OwFpsPKpTI897NyEz3knZJdjz/+cnbHdKRgKJx45dlqsSNTYCdIQns/X0eCC/ouspcUpnxHODRg0lDkVZW+PloUc5Qbn1dv34zO8Mq1ACIX8Sd/BnPPHrrVkN7axYZWTmODOlI1oTCgK4Ipvt8WpPObOy4Xu7ld6uWZikw= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2017 00:34:26.4742 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0501 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Before scsi_prep_fn() calls the ULP .init_command() callback function it stores the SCSI command pointer in request.special. This means that the SCpnt = rq->special assignments in the sd and sr drivers assign a pointer to itself. Hence convert these two assignment statements into warning statements. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Johannes Thumshirn Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/sd.c | 2 +- drivers/scsi/sr.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index aea55f5afed0..916f6e9dac18 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -990,7 +990,7 @@ static int sd_setup_read_write_cmnd(struct scsi_cmnd *SCpnt) ret = scsi_init_io(SCpnt); if (ret != BLKPREP_OK) goto out; - SCpnt = rq->special; + WARN_ON_ONCE(SCpnt != rq->special); /* from here on until we're complete, any goto out * is used for a killable error condition */ diff --git a/drivers/scsi/sr.c b/drivers/scsi/sr.c index a8f630213a1a..9be34d37c356 100644 --- a/drivers/scsi/sr.c +++ b/drivers/scsi/sr.c @@ -393,7 +393,7 @@ static int sr_init_command(struct scsi_cmnd *SCpnt) ret = scsi_init_io(SCpnt); if (ret != BLKPREP_OK) goto out; - SCpnt = rq->special; + WARN_ON_ONCE(SCpnt != rq->special); cd = scsi_cd(rq->rq_disk); /* from here on until we're complete, any goto out