From patchwork Thu May 25 01:06:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9747463 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3B67C60224 for ; Thu, 25 May 2017 01:06:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DDE826C9B for ; Thu, 25 May 2017 01:06:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2262626E97; Thu, 25 May 2017 01:06:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 81C5126E69 for ; Thu, 25 May 2017 01:06:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162176AbdEYBGd (ORCPT ); Wed, 24 May 2017 21:06:33 -0400 Received: from mail-sn1nam02on0071.outbound.protection.outlook.com ([104.47.36.71]:16096 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1162163AbdEYBGb (ORCPT ); Wed, 24 May 2017 21:06:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pZsbsWocc6RZyceUyTY0pQjJDwk9D2XpG6yr0QDTEn0=; b=Cf6HgRC2F4IbWdBXu6aXAN4dmOgT05Fst7uiVbuvMRuVesyAEJUq5j0zFAkmGo3Jv1gQgbmK8DTPm6zezr0zN7bg5DNl4d8RctBeb9a0xCnSt9B7ldxe3EmUizM12E2aViY+nZHguV49RfDFAJLcxptAhfmE7Hk2CcpJLktdHMc= Received: from DM5PR07CA0047.namprd07.prod.outlook.com (2603:10b6:3:16::33) by DM2PR0701MB1018.namprd07.prod.outlook.com (2a01:111:e400:246f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Thu, 25 May 2017 01:06:29 +0000 Received: from BL2FFO11FD026.protection.gbl (2a01:111:f400:7c09::148) by DM5PR07CA0047.outlook.office365.com (2603:10b6:3:16::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9 via Frontend Transport; Thu, 25 May 2017 01:06:29 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD026.mail.protection.outlook.com (10.173.161.105) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1075.5 via Frontend Transport; Thu, 25 May 2017 01:06:28 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 24 May 2017 18:06:24 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v4P16O12008925; Wed, 24 May 2017 18:06:24 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v4P16O8B008924; Wed, 24 May 2017 18:06:24 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH v2 1/7] qla2xxx: Fix recursive loop during target mode configuration for ISP25XX leaving system unresponsive. Date: Wed, 24 May 2017 18:06:18 -0700 Message-ID: <20170525010624.8886-2-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170525010624.8886-1-himanshu.madhani@cavium.com> References: <20170525010624.8886-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(39840400002)(39410400002)(39400400002)(39850400002)(2980300002)(428002)(189002)(199003)(9170700003)(50226002)(8936002)(1076002)(6306002)(54906002)(5660300001)(87636003)(38730400002)(478600001)(8676002)(86362001)(305945005)(356003)(5003940100001)(81166006)(189998001)(2906002)(4326008)(966005)(80596001)(42186005)(36756003)(72206003)(2950100002)(105586002)(50986999)(76176999)(101416001)(47776003)(33646002)(6666003)(50466002)(48376002)(106466001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM2PR0701MB1018; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD026; 1:4Rwi0GRmVW4BvOs9XGYnPHBdTD38trpdPGZR2EBrX4qVvmnQ6kwa0VbD+Xj6UMVi35yjr9z8ihzeHip4SNIvP1PkZ+dhKqc5CPNzbP+iT+bV55O0UFSv62ArFHvkaKVgoyyDHmEQdwS2bImt2eC00b/3d2REYzDXAy5tnUUCMkR7YtKTTFYrsAGCIcusYPsJk/nQ9BN89woWdsG92H1hn748OlR6sMDGlHCge9NnSXpRL6QO/yd0u+ZsT03ViYo5MWFC3LM/I1eZsMAYQRDstvudf40bpUgV+uT4I1XO/k9irIaQk47KMoWxMYG4Glut4lRRyPvMv//GxA6+Oscpm5xXx+ma147DzhyKIoE9nNXj6aLOqfLHrUn8aKMeVG20V6ouoTbz6YK2pgOmeeH4Vo2iokhuSeBwofg3maTZ1AjFpvUEo75TrJjsKAzu1ZULQ83MJksFqnWdglvcQYA925uRV451vSTFWQO8SJrRLPRGYWAziyJ1L6FziFB7uCFq X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM2PR0701MB1018: X-MS-Office365-Filtering-Correlation-Id: 39a473ee-4df0-4956-7209-08d4a30a4674 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:DM2PR0701MB1018; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1018; 3:Z9GxLKefM9BVBdcWcxZhe3qHQkHymgU3/qEzQtz+EStDBw2GuV7xP9fS58+Vv1f4T9GfbnwY/XlYTAXxLsH6Ig3Oeh6DHf85L1GMe4BZR+9VLYrIu7Py8Dgi7OOKoqbgCOy7tW2L+Lkwqfh8i4l0qctcJ3r8zw9iZqSB1QxjgQzlcp/dbuFb6Kz2l8KN2yu2Ydc0dt00Wv6lhxpStxf1FSSi7PLB2QSilHUih3uqzj+Pvy66PnjAQlmkcGdYZJTq36H5KjR/cnDMDdEe6/huj8moneAndDbJWhLDbL3OwTwoLMcpM3VL6zt5G/uIAnfs/ossg4fyexjGqP6B6lvnNwbMpCABmhQj4X9lE1DiuDnovnVlDvrgKdKWLIy/7ohhCOUrw9K9RN0MzbIUHyiNL5FWOozrDhnz4DeSwn0OMt4BTtpb0LlSIJc4m5d7l7UrRXnJ80QQacEX7nEwrkxKEFiv3MRGQANfEQxVe3utqMXnsM2v6i7+0pD97G8u0N98 X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1018; 25:uLIV6MUKEzD6VtxAjex2QHjo98VBJK4t2kC1/Tl5SsluA5FqVzx1ygaRXvfGmkQbKwvVG5F9TY2S1aLz5ZRa//R7H/XOUQ5M7fbPQqWDDEzWKb2IL2yBdLGtFa37MLmgW0lUlnHHJUuhGDu1UBj86LYuG0TZ1rF4m2KWLI46R17HIEtmf4qR6l67iB0Uw7/tihZ21h9ni/NVsyz+61WrjG+uzAszXAQTJR+BOSM0aL9F7+GFhYYC0FzgfHw8qD5FSUc17PpidmW0G3xAJ0IFQlkX4MrUowgo3X+4airmeqY0aQ8wBNaCeoWYA287Xhy0gtq68ZaVCHT00LONaGrfq5hnhUmtLmcz/OJTiVpy8QtQQwVx1Seb+P4j2L8H6FwIU8r5SMty3llRVPiIsXemjZFD3ypXZjqRKAm/Ys3yjimO2NxfgNhXJNJd+hQNwQneBEAw9Rbf4lwBV8vfTeYdywq9vBslTtOqBFktMECQpQc=; 31:1Y7We32C+NoV7f4lpUAmYG8fSCXwTeqgGDmz663eAnvnAk0Dg6/k7MBGK5f6rK3k1SyEDDVuMop5V9aDdOYvzgSHbVtyudIo/uPq8gbi93ki57QV806JEFqT823Ol1E+snsC49Yzdkz8sxue82eFoxppv+mwLDn8gc6B1Pcx6OCvrV/Y/LyPj/vVCn7bzMy6m0ux0NjJljEaHZ3wzlhiB2b7FxuCeHmdHjOM3uZ2+u9r9coMjJ01AzL9+xCJ2BRpBXAXH6wrPqt2gcHN5Mg/iw== X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1018; 20:81uamETmRaEeKutZf6APgW0mceE7r5/WCmN3R1jtwyF3KDuRD0SJm4a0FgR/eC1InGuS30YFI1DP6/HfssULWlOwlSZH7PfQd+sg6fqdWvIBIQk4nO6c4n5bvIux74yECdHcjBgx2NsKUr+tQxCSAsmGR4LIvQY/6IvKtybMMqS9JQxzf8eyYDUT7uWwfXlN+e9w7ODDk0OoKGOmCBgFdlSuwXQv9+XZcmtzcqQwWOYAFlqw+n1hsS91EyeeF6qD5M1g1MSDns5exHgrDg7X8F46mRbtT92xNiZXHWOeB6xNo0d7LUyJR6l/4zhb9tSaT/CmtC/IOhw9BxH14K1VwrqbuBeIhsQ1uWNC5fMKiOWyPwnilYcuDizHpa1i8teqpiua+6DDtxzkgpm4s/2hozZuLsoP3/q3xfk+nvhcTWSxsUpa4GVMVXv8Q99K8b8STjMjT28Fg+7lcx6c7/Eq0R6+BMMZ0om3umshYPVLxyy03huruyViPm3rjjakVIad X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13018025)(8121501046)(13016025)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123560025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(6072148); SRVR:DM2PR0701MB1018; BCL:0; PCL:0; RULEID:; SRVR:DM2PR0701MB1018; X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1018; 4:WLBwmqcRnMoeQBINk8CevrmzKNyuFjYnqpOau3hjjqa0GXihXAwcvlhixBVQxKWf/s534yD9oxeSlDShqB0gdOXoWHUhvY11mmM5TqIy6VN3Ff+XiGlomw9Yw8nua/I4jpSE7L3RtFAM/X8xZfeh2tF7wCFizX1hW4tckskKvERzptZVH02UyjR05GIoC9btL0R/C0ABIk4YM+EQmiwcyHGn/XvBxR5eDNfWtTNeVvzrjmDNuZPm0o2gIFrhpMf4NG5Bfxl/N699ImeUaTxk8bQ59AHNk0UYKeohRMCb1w3vALNOlBUQ3sQznuvKuq2TWU/rOxLEnaXDI7Ed9oskdNYgNpQdNCf1AvZWY8V4LeYjGiMqLqKa+DvZ+nBjJVfFiUkrgaJSJ0E0zYQjW0itSf1ZADCRH/CvyLqfieDTFiffG4JQSCYPfRbKlVQA7D0ntT3NhtffXz1MWt2X5zunJG4cZbtUzKVw6/GmrpYosYj8byPV6J12+2e7v9Ttvsr6fS4LpMJs455Ag3nwOThrhbi06TmIVHs/dB7yBHXtpc9HJnRQ/ODinFLQIOgOxefNbaDC2jUUDyRSoF5W7z8XT0iXrAdenoYnOMJTAo4GScC87mYqX3dOFZVD5efCnGSpJ+wrTtp+1j6gjTz6thMF1CGip447dw8ZJJXBcXGMVeBBlLtKgPxnYwTkE2EYnIbImCpTtKtkycp/gp8IG8Gj5veihDpk3zBckOWD+MxARCYkybiFbsY4ZuCYnBdHzTlAzevR2LZNdeTpzpLj1KNxeDq5oTCpRGubXM1xqqP3g//jcMiFj408adzxO7uAtS34CZTvsZHq7ZnwqeUNtUPoTfGo/0jLtMGLD0waGejJZdg= X-Forefront-PRVS: 0318501FAE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR0701MB1018; 23:NV5e6qn3KVXQJWXapkSFHLyNNGmhyRwgHLkBCOo?= =?us-ascii?Q?VMC5I+IrwiIYOhG77ZqxE5ZXT0/gfLDNDIP9duHXNL7tUGHgD0+z5Zeqvo0Y?= =?us-ascii?Q?tVBhpAAqpAKo/YqQaANOAlH8t0DmY9GDVpOmcWzvPiLwJNPJxZqHOeycTDJI?= =?us-ascii?Q?GjQV9FwEbqAShB0l2XLxM/i5c640j01sCkwApE14AJgqxql/XyCT54GRzv3o?= =?us-ascii?Q?nFi3IAamEX+o5/7W688zY8T21bUFYc/pEA+OD2nAXLLg/J5pALYs4opXfzrQ?= =?us-ascii?Q?Ahr+nJVvOBRD/r6TSlCNDbcxOezO28F1LP0STYPBO3UEIY+TYsePVaFqsaq3?= =?us-ascii?Q?QyPini3MXCoAgHJ1bGM6bcFSzUaG4Kzv58PJrFhMnxWdogkVcALVOOKrbSP0?= =?us-ascii?Q?Jumz2C97WGOKTAEC/GMa489cwkk3Pn98p/0JoYnczKffCtYL6+DWlapPzbaN?= =?us-ascii?Q?ec5KgB0bVslyXFiJZDzx/7C8hHPKUjywyI6ZIpw/2qJn/5W/SArdOj/xpnCY?= =?us-ascii?Q?Ur3pyxLeAIjCMJeub0pttDpOKEPANAPlnx1dC10FL1a14mCn5J1/Zymca+bv?= =?us-ascii?Q?EclgWKPuluIaMrpL7sgCHVtoV0jIzNX7x/XzEbSIHciwwLcYxdWPvT9HQIwL?= =?us-ascii?Q?wLPKY+1NkuaqeHOhB9EHlu1MGZoBMLLnTL23nAW/o0cK4MO96gNKCE76taQm?= =?us-ascii?Q?iLgyhmpOOeGOMjHRJVfCmOB/VeXLsmxuViBZWYYvn2F/1ksX9v8ST5sEXlL+?= =?us-ascii?Q?Q/K7ww1AlGRD5qk/9Cw8/X9eqNeG12knUW6nS8qqnAoRDU5s4JiGpKEfkq4I?= =?us-ascii?Q?WFPguJEnvtvx83SJM7UnOTOapYRvppkG6ZNE6AiSZEy/fpntTvll5C8tAu3b?= =?us-ascii?Q?SEapVSzTArH9ulPlTK+hKh9neungsIfWX4eDr3ujXk1jUI9QLOOwKQgTj3Xl?= =?us-ascii?Q?KO5n2G0Kja6vwsEvcI6X0vaXVE6qTPqyvmEX9fQRfSigu/26GDWMkniWOCTV?= =?us-ascii?Q?UArwLBekXuxfI7Cg/Ex8cl+/N4tTgGCzYAnZ57zUsCdvQIqhlxzWW2r5Eluf?= =?us-ascii?Q?jdLRMdqRplBKF6v9E53Jtj+UmsiZ7TFVC29fFWlc/gSU15FgISzeMGvSAiAT?= =?us-ascii?Q?dBdYWHoHymxw=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1018; 6:bIQmcCc9N6Nbdo0fgcDZHZWX9pfKrALTdfbNjAP2jaC9KXU15Cwr8bN8bgA5A/UrLtFHoI+s3NrHQD4d3VPD4evtdNjfv7/0v/A4OBg2KsbfI4OpfMvJCPPL7TZfSrwlGXCt0NVSSRQblMddJPV1NdINFKuTQknOPhIPm1LKzzOjmBt+8bC/qtGWtjKHWUGVdp8kbMf/d6/Ef0cv/jeDtscu5RR+/Zmr8w43a1FbVOPaGylF1dMvcYSNVel9CZxtbdIWgo6k7QIX+UKzi7gYErq26RolwlDPqT85TyjBvgCMNwfC+ih/KY3LVFHlLctX65oIea0BdERGPSPlYvRYjUnF2VGYRykjnurSwMETIAOhIfpqhtPjJZarymkxaOy2chrrUNchtGLiKXp8dz3IWkVUu48MH0aONfkhtRwIqam+zKpiSlWPnssf/5O9yS7YwXrAkhWP5wjfwgOtmeY3ZxvuZ3U2mr3tELVnPVIX5gPpyZDUc93w5G08eyVDTAdYbwizk968R3uYOkOdcIpe2Q==; 5:29gGaZuHeNwOIFQlHZhmN7LY+DhVUM/LcmBquQJoAyR+36H4He+fJpWlyWata4+WvtEVAcqTMg9BXWghV/QesWyJq05FrhPFntzbEoy8L2LEm80kmcG1TD0XQxjI4ACUO6mtgaIDeBuRiF9rBqTUZw==; 24:uJi+rZhq0N7r+r/Z8Ee37+mvy6UvSrKbdKtZ44nZcBdmbVGVhSHJyCs4yh5CklsWyXq1JVYaU3FNemQ9X7/BtdCzg/7B/DOX77arFgIpAoc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM2PR0701MB1018; 7:uFmOjoPg9heujq86gIxakk9Ji9Li/SojRqvXyISL8e4gHcEgcSh52apSE2Gz+E08GSMmsFpq1p6rJ6bAT6p8DOfJ5gJveRmQCyPRd32WVVNfPnlrePxzP+IzfNAGgf56RcGjEH89IkPXd9hlDpsJjWPXkkV1ufLEXrpJdw1JYo5b6zpy6fd5Xm9a6bWJ+PlDxdAvylC9NDACzPC03vVp5ddhxBF7Yfwd9kO58h49jsJGucE3c10k23+Ukup9mOmCeYKD9uvcLF+GzqbwOq7JUe3O4oSTC8h4KsCDYsMVtqCvQDRcGEzvBMFchrDSYxB8dEXpXTbHiekvmuhk3jlJqQ== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2017 01:06:28.9687 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0701MB1018 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Following messages are seen into system logs qla2xxx [0000:09:00.0]-00af:9: Performing ISP error recovery - ha=ffff98315ee30000. qla2xxx [0000:09:00.0]-504b:9: RISC paused -- HCCR=40, Dumping firmware. qla2xxx [0000:09:00.0]-d009:9: Firmware has been previously dumped (ffffba488c001000) -- ignoring request. qla2xxx [0000:09:00.0]-504b:9: RISC paused -- HCCR=40, Dumping firmware. See Bugzilla for details https://bugzilla.kernel.org/show_bug.cgi?id=195285 Fixes: d74595278f4ab ("scsi: qla2xxx: Add multiple queue pair functionality.") Cc: # 4.10 Reported-by: Laurence Oberman Reported-by: Anthony Bloodoff Tested-by: Laurence Oberman Tested-by: Anthony Bloodoff Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index aac03504d9a3..2572121b765b 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -3282,7 +3282,7 @@ qla24xx_enable_msix(struct qla_hw_data *ha, struct rsp_que *rsp) } /* Enable MSI-X vector for response queue update for queue 0 */ - if (IS_QLA83XX(ha) || IS_QLA27XX(ha)) { + if (IS_QLA25XX(ha) || IS_QLA83XX(ha) || IS_QLA27XX(ha)) { if (ha->msixbase && ha->mqiobase && (ha->max_rsp_queues > 1 || ha->max_req_queues > 1 || ql2xmqsupport))