From patchwork Thu May 25 01:06:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Madhani, Himanshu" X-Patchwork-Id: 9747469 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8F85360224 for ; Thu, 25 May 2017 01:06:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8125826C9B for ; Thu, 25 May 2017 01:06:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7616426E98; Thu, 25 May 2017 01:06:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D7B0126C9B for ; Thu, 25 May 2017 01:06:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162338AbdEYBGm (ORCPT ); Wed, 24 May 2017 21:06:42 -0400 Received: from mail-by2nam03on0045.outbound.protection.outlook.com ([104.47.42.45]:17662 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1162190AbdEYBGi (ORCPT ); Wed, 24 May 2017 21:06:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zdS5VSwMUWr7iORf6w2673cQichKDgXB9UkYriFjQYE=; b=goM/VWVDD9cADeFxbyXtZnFL5vMgjkWc+5bbnPJIuGj+qj/p0KeBteBUXo2uNF2OKHAwZtxKrDJV48CCqaaB5bvcp9Zdf6qzbxb+S1Oz7H78JO+wwut3xg+hIZszx+KcGTHXid6gKLd8vG/wGbNrWdcNRYo/+xny3L+eda3LWcM= Received: from DM5PR07CA0046.namprd07.prod.outlook.com (10.168.109.32) by SN2PR0701MB1023.namprd07.prod.outlook.com (10.160.57.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Thu, 25 May 2017 01:06:37 +0000 Received: from BL2FFO11FD026.protection.gbl (2a01:111:f400:7c09::137) by DM5PR07CA0046.outlook.office365.com (2603:10b6:3:16::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9 via Frontend Transport; Thu, 25 May 2017 01:06:36 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11FD026.mail.protection.outlook.com (10.173.161.105) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1075.5 via Frontend Transport; Thu, 25 May 2017 01:06:36 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 24 May 2017 18:06:25 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v4P16OUM008933; Wed, 24 May 2017 18:06:25 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v4P16OqO008932; Wed, 24 May 2017 18:06:24 -0700 From: Himanshu Madhani To: , CC: , Subject: [PATCH v2 3/7] qla2xxx: Fix crash due to mismatch mumber of Q-pair creation for Multi queue Date: Wed, 24 May 2017 18:06:20 -0700 Message-ID: <20170525010624.8886-4-himanshu.madhani@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170525010624.8886-1-himanshu.madhani@cavium.com> References: <20170525010624.8886-1-himanshu.madhani@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39400400002)(39410400002)(39840400002)(39850400002)(39450400003)(2980300002)(428002)(189002)(199003)(9170700003)(33646002)(76176999)(47776003)(106466001)(50986999)(5890100001)(101416001)(42186005)(105586002)(86362001)(5003940100001)(54906002)(4326008)(80596001)(1076002)(38730400002)(72206003)(48376002)(50466002)(189998001)(6666003)(305945005)(2906002)(8676002)(81166006)(50226002)(356003)(8936002)(36756003)(478600001)(5660300001)(87636003)(2950100002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR0701MB1023; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD026; 1:DtXVdV1oDttllZg32TvFY95V+iFx6b86fbC3ePSeVAL8Fu0C2KtRctBj64n5C4a0+5T6tDWRsJnOaQsmP5z/cHnTJp2cY25wVbWE5HYo/2rOrfLn7HW5n4+O77DDRuh6bh01zbXZxjsgcs2voLxy9lj7hKeh9gwSCz6l2w7KuV5eJWbA7x/xexaA5QTQnunT4IgTfZumN4aVTXNgxO6yG+KG4Vp5nfpUZp5CcMKMHr8ShhUhKHr35FO2g1cMMo/Sxx7pmB943KR26F7fga2hVOWMzgYd5EFrARxR6UEAIVIHvJT4qUir6fM7SCjY8ts7InCm+VzAtM5/jHHZh2j9VaXEKTQcuv0CfeUd0SvYn0IhB56eYjvTXEyj/YdZqMeRT1wc6upHzamh5LwoEdAcY7vgoFmzFew1p27jvDRh/711U6uou8vWQEqtK4ACFrw5js/1kNsgWDFfygesBBTAshUM8JoEo4wXcqCRuWNVOf+cllIaUk4nXK7BDHDZieoW X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN2PR0701MB1023: X-MS-Office365-Filtering-Correlation-Id: 7232f5df-d2b4-44ef-694a-08d4a30a4aed X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081); SRVR:SN2PR0701MB1023; X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1023; 3:K89Tqy/Ser/Tbiw5z1VXnzmwkIdKMJx1+hFg7rAYRXHhd8NwAs5q/27Op8HILZWmWdJj3FK0g6UmB+3WlEI7/i9rnqURLWTTBUt2tRAE5ooRBEpiBHRiwTMAQ1nW9d9eKse9nHCEREPd8AUAEYCrFVb29Qp7w2GAyNDKZXL0uBpzj00yNiI4Ftu3x+lg6vj4CLb5IgZ5A9+ABGur5W1GBlQXO2v4cJ/ZmVpHnppZ0apfBqv1slqjOdz4Vhr93b4E8ltJp9VNJaHNQzhxQLd8R/XA9ap28tubYsNS7LKRx4TXpw2N8vM6RgyjY3ceRF5DbbkMJ3v1Pay9jSITl6IXKTAEQsDUz42x3aiyRyfLo/9kB4782+oY0BYaYFMuB3mSD+1+jgjsw7o/d1wt+E2Rk+TZ4130yu0N04w5CXLGpb+qpXQBWUW0A42umBTrnHaeasWvYsi6EFLJrgrCTBXAtQ== X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1023; 25:CTlzzj1HcFTPqIj7LRiKYDVee8PPJ8OEzA5KCFO2ip0aXn02ZSq1Smk7WMGpu24TixuXl/J3MDIlxZ0WdDjmfu/xvNvP4jfk5mCBxwlHkFhYZJReHa+RQbznfZyOm/O3BazdMEeFZcB4JJdO5L4uScjmzZExYeoGR+PnAYBW2cDQvwhsaUjN7TmUGHBrtZEkfA3OrIjtkZKsyieTJMmjSiCpItnY5hLBd9ANzjURcCExtpI7NTfAf+WMjj9ixwQh1Xw4NTggriiH2jK1uU17JOkzl3wFpCVac89T4+/RJtShXw1WwYrHnwll5uErXoyqbDWgvzmnx1BVJut42mmNWXXSRXtsZTkYEjirHPNtjhnubcGtBPzyj0RK+aym9jENHhdFK0VpwkPpvH6clN/fB5YU4xUrZCHaT0mfstzGqTNVVfdptCxEMD9rhwpBbPi0QV62VIuV1jWPOD90TIHaglwmCAFzFsKh2GW4R08ZnVQ=; 31:rLMbfqqi71cw5QPxn7C4Chilq8vMdF6aAkj3UZMic5b+a6r5fjIBcsfc/psEjqa3rhbR8mQ8GK3LNIs+oyg/Lqz4/QWsmoBTRMRLEvhy63ka05GtMlovVWoCxfr7DaxZ6S/fGl6Z1R/uG6APL03AW72Oq6DKb5Ylry72quiAgFtjLiC8+3XssF7QYtifgdeZCQnHTFAUlLttF0Hmux7ZXQY7yoyAabNmOQEQNtB4/I4RXpkaudfF5Jv7RU+h9+NNZeV8/f+c2yuntL3mWvhm0g== X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1023; 20:Jj0BLT6M8Z2KwWJBN/Rz3U5+C3+K9Rpq8aEFQMt7OHM5d7kvcXsidf5GlpuQMpLLHh81HuGINtv3uLzs4jCSdX+35CVXjY1e08Nrb0QvkheI9o1cSV6S6Dmvkil3zmjBbbLz3HMGhYhesdIQTd78XMIPhuMPfYNhR9LSzwLJY1EGOFU7Ya6ZUyemrHlKernBI4uh5CbVc/RE5+j/h6AAmqoP8h1Nr3KCU5MUDB0I//U+selPKQbmf4I0256CecaiNlIyiTRWPAcbPXThlua5bNjRzlnCTk2WPq9M9AmZk5/ZkRkSBmTHFKiox+awvRc9bnMiTgP1ua0iYdPBDXBvoomGb3kB2rNfAHskVhIjYVKew5Pp39xU+d6HfpA62leD6oNRV54ZSqu5FcEGPNY26K6m7PyfE8OpY6hyGgbfd9PPc1cu/PNmwZuHDFcRaLo8wQdotMBxugYjEVOAjVyVigbCadApThGtkcpPXz2LrfBvkivIh7nm7LiJAZXQ+c86 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700054)(100105000095)(100000701054)(100105300095)(100000702054)(100105100095)(6040450)(601004)(2401047)(13018025)(8121501046)(5005006)(13016025)(100000703054)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704054)(100105200095)(100000705054)(100105500095); SRVR:SN2PR0701MB1023; BCL:0; PCL:0; RULEID:(100000800054)(100110000095)(100000801054)(100110300095)(100000802054)(100110100095)(100000803054)(100110400095)(100000804054)(100110200095)(100000805047)(100110500095); SRVR:SN2PR0701MB1023; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR0701MB1023; 4:nBgIDzaA64yWb8csgmO8VZvWaAe/9sJ37MHjGqZt?= =?us-ascii?Q?V5tB+RqUEfRrAqF+ekRAf3XHSDPZqh7xzNOqYCWPeGWqJAwXbg8BHnTrGAAG?= =?us-ascii?Q?2ExquTP6Xy8XSfu6kdtYuKYFbnmD1Wmt1MXoHT4AEaYstK4DAPA5udhcU40+?= =?us-ascii?Q?PYYrA4O5GwbNkw/ucYaD5NEkwKkU1Z6P/UE+R2FXpChjZKc5O9qgAoJT3Ipf?= =?us-ascii?Q?mn62hkGStrU7ZHYKURH89p90RXaOSfTbby7h0dg7Sr1jcyV0y8JkV1BZoiz+?= =?us-ascii?Q?nNyHdFvrPZGUVD2FptmAsWMdT2NTtQEWcaiVwHDE4BolQWjJXr4pqD62sN3g?= =?us-ascii?Q?/Yq2A1IczF1HK1r3GzHaiGQwHnu+M9o3mmtcU/cJ0XW8WCBfrQrrwkPraJBk?= =?us-ascii?Q?np7BONz/b/Rh41W4Z8S/a8t9jOIGIAd321lELkgcod0GotsmBfW0RZ5czRUd?= =?us-ascii?Q?QNX3rEkfYGrkS1n0M1bR/e7+jYv+ViFXGW2txweLPv/m7jXczd8/V9P6Z3ma?= =?us-ascii?Q?sVY9JI6SnbwIQBNCxaVg6V/IjlUGmbqgUbnfkAKTkQu+HLEwV+2jJ715jDr8?= =?us-ascii?Q?OLhaH7DiJ7d/X5WXYGSE/qLzWdW52tvZioc5HOvWlMqSGC9OTd/iKcl17rQh?= =?us-ascii?Q?li30jTJh6MaLEoHxt2UWqk1hHKHhkoznHlUZ9hoQNP2ZUQefPQ1eCqwEEMgm?= =?us-ascii?Q?GRjO98UARtoMRGPVEVxit8sS5qNlFBSjw69VgYpQINoafS1u7Zkpg8E+/6FA?= =?us-ascii?Q?sll3u7HpfGRd4qU+DeNcNv2PcGt6pXhgAydfzpUJ43p0GKunUCD0L/CB2hup?= =?us-ascii?Q?I31X3JAN/6dAa6BtI4BauKsH3+HFS+NErsj443z/aZTpKRJkpaGJtxP3VipO?= =?us-ascii?Q?ZO4iQ58ISSunn7aKORThInckpekeIxux7TFJagoGdQSjBzi9GHbhHWcKLPWT?= =?us-ascii?Q?v5O9Je5h3RGhXJkwiuPIn2G08bdxtnSa21i3GRcnKewNXUpUe4ssSiioHhLz?= =?us-ascii?Q?f+ciSIHZ+iPLKBSEZtq1vetxhqPjO3IxN96wz46JviqSGxrANsW5hrEFCOUR?= =?us-ascii?Q?9eUua8lNH7wtyiSfZLrIDeniI6oGLtF0814Q0TkEK7jtXVogNJyYbUvgXnWl?= =?us-ascii?Q?Di9MmBTf5r2TOX8DajxCwObbVAYCIEw1A7p5k1DxDe1HoK+ehCPX0KJex8sg?= =?us-ascii?Q?mjGReGeI/u+Ct6h2gfgKgBhLgaHydGd7ppkeXNr4cKiLb7yAvJgW5tGj7A?= =?us-ascii?Q?=3D=3D?= X-Forefront-PRVS: 0318501FAE X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR0701MB1023; 23:lMx3IUY12GAqGzw8CB9y9jJwiZYBjXqOV8zPSS4?= =?us-ascii?Q?WwjLyA6l8MBh5fjL+1dZwd9S1YwXd+H366DvKeNgOOsQ0eiYgsIop4VLM5MS?= =?us-ascii?Q?bi2NOtBCbMdhQ0f5mGSsqNb8d36dWozhTt0dS8g398Gmztj62qq/oFfK1kut?= =?us-ascii?Q?PcgVpV9qy+tWu9rL9KMr6vCPBGe19yK8rpClhKaC56IQgg4RWb5Ud1N/eErg?= =?us-ascii?Q?wglPfAX5FuuMndc5RaGueIHf3Va1FP3xflvOdAUx/ztjmZ4BtIyTil+YXkGu?= =?us-ascii?Q?/Orr7E4vVivMECZCfisdosqvXEOLLn0Wv5n93NhTiL51VADq4+TflscBkthb?= =?us-ascii?Q?uLt+WJP3XT5jEbH2cdYDvPixrymbV6119jPFOwjcFDYxfKleNj+62fC3S2i6?= =?us-ascii?Q?Kl99pv86Ykn5sUUXEeoKcENGsj3C/cNeSZIS7YEpcnabXAYx9C6c81Y9kHDa?= =?us-ascii?Q?vC+lbwMoCyGrovozi69w+jJA7ZpkLwNmkmpB2ylBHfecJkhSyrktXPbKxzSe?= =?us-ascii?Q?Fg6OhcBVPqIvGdm23VAM1IAnGrw/ptn4aAVY/jifW1u/qJH/0LfCnge5vT78?= =?us-ascii?Q?MNPnC07kXHOTmofqfkdUXhNB6Suf9VIaZguCtnHKb5o3/xbLKFuF4VTsmGjC?= =?us-ascii?Q?mP3fGLq2tS526O683J6y7u1+4XCwGZ+VGJMSo2nOY7/rjB8PT+be40XpuOBC?= =?us-ascii?Q?ECrhzd7OJaNt3cayr/EFmPx2zkhhSLkxchzMLIDwHQTsvtltfb0MIyjRsqSu?= =?us-ascii?Q?TovNPQb1BrvVLiS1PzEVaclFhwBUOGq02JKh0OVIUghROhmqOwPEybC5vgmZ?= =?us-ascii?Q?sqRuIGQ2lPb3grJtlBQ2MayCnUUpG5YwJeT/4I0+r7vZGlerP0aUqaWgQCEp?= =?us-ascii?Q?R0Z+YNakX1l4YOVaHJXp6FpX5e6XfJZIvB0CzAi/RnunrTyDhtWxf/Vik1de?= =?us-ascii?Q?zY4+RMVHATJ3t0bgf5i2vh+YMdH/nDfpJYGXZ7aMFka2aIHaiLweDly8bW9M?= =?us-ascii?Q?iWNdKUEoUvDnMtBfLQi01PbaTX53lrYg1gkwrXR4Fg3nVpSqIZh/CJfDe+rg?= =?us-ascii?Q?xKiT7EU+cY2HhWl0utF8NDE3i+dM5EvnlfzN4AKqQerdOAtG9iZKUtArGVpP?= =?us-ascii?Q?jKvj4dyHMn+c=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1023; 6:gEpbuzTllPRaRlU6ZbCU7rowAPwgyJ3DkCgKHTJ29fRkbaKLBHHKv+NQ3BZjfnC2uCv+Xb90uAYbGGXjwew5NrB1cwE949RMGuKJYhaMG2VpBGCthMoQ+TiHsfiLcwuH4g0a2hNx9YOaci7zWXIb178SWYzF6yblaDpykskY2pbEomlMJbvHWhfOx9Qms/RealJg5YIo9kxr82DhXPvfX4aXzPRlzUoZAkkzPjP1QmUA1/zkspb8jmz1hbjPWyQZgiPioiJwqwIuC+tt1GElvpGAegP3V74e1fi+N8dKvykPBEOhv2xew/9YDczRWTQOMjs6eLCeX+mHKf/fjd4SDBDTiPDdsLCWbe/gNzqKVua8l4C91Iz+HagkPzLR4JaHYs8kiJY0o4V1a/wPMfUbbVvm7Ve/Uq2iNfki+cvimX8PkZgtKbxe3JDbL9ZMSMJ9iS1MNx5Et2OjgAPdxGykBjTRwfWsRioGLoW6capXwyBARNYo3unRekEBOLxweTrzH6bM9vNTzw8+2divVeP0Xg== X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1023; 5:ntD7cRLyP3psHeaO29JxhawRgqbW0q1jOw1qmk8WrRqTlTD8XThk+xsOVftkgZkGatlFm0CMgw/uQ91MGppgidnP0PWyKLzzUjkfxNrcRjKWlTAI2bf4xtBP/fP1107LMmqFiSjWKUbfBAGAYICFuxwenZMAQ/ueElWadAsOUJ2jkPWGHcVI0BDCAXL/oaiOzKKC87GwqELx2EfkBMIo0U+cbuUnE9mWA0nft9tazahKKTRGCC6yFRxvNTdSRseM7bOXqzKAJZ1yfiVuMwNe+9eq+DS9RMWojw1zV0SsMHLFO99kJz4RP8fkE7kdoWkVtK0UNg0VJWLgklmXmm+fK6wWV+ZEKL5zAlYfQ9sS+hAJwZJLy4F7GzCmQOLcnMgfrKci1vQnz/Cgrkd021AH9xVKUT/axp4sIHkE8mdDEterE8j9KgyKhqtagS4/1LySmAYKdUck5K0M03X24CKiu7WBVUTQQyZ0Qv0quOs+nXjWnNSOXnM8a8qBMxWoFtP9; 24:3K9scMd0wWXwD1x8Yf5oMNhXLzxzNHnEtszO5SkcE+Hpci5cQezTMWlzoRsZoxAR49qzu4GnAmAo89FsVce3p58q647UoAtNLZykaGikMus= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1023; 7:W23NgAU/yTN7zeqVkmHD/Oz2BGS6x0rnupI7sIrZydnccrZlyy/+bl+9zLGa8+VmNKEltWIbHM1ZGtptjJi/OzTp+B5eFU++zhceoKhBuxe8UC27saBa7QVjkyDPhXxsblMG2MGYKqOQgvhjGAKVOZopRew0r9fH4iG79weZeey9OqLOcafnFS8wEKiHq+6Gsws0i76H/R9BwsbnNbcvYycdcwYvBrblGMeU8fsiwBVj+8XVn+rI5gQUAcc76hKYd1YKNABnrqe8YR6W2Cwj5g6Xk/TwtvQ3P9GBZAdonJRiVOQsX3rYuYA9kUl8js8p+LBVsPdmxmNUKqm3Yl2Lyw== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 May 2017 01:06:36.3943 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0701MB1023 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sawan Chandak when driver is loaded with Multi Queue enabled, it was noticed that there was one less queue pair created. Following message would indicate this "No resources to create additional q pair." The result of one less queue pair means that system can crash, if the block mq layer thinks there is an extra hardware queue available, and the driver will use a NULL ptr qpair in that instance. Following stack trace is seen in one of the crash irq_create_affinity_masks+0x98/0x530 irq_create_affinity_masks+0x98/0x530 __pci_enable_msix+0x321/0x4e0 mutex_lock+0x12/0x40 pci_alloc_irq_vectors_affinity+0xb5/0x140 qla24xx_enable_msix+0x79/0x530 [qla2xxx] qla2x00_request_irqs+0x61/0x2d0 [qla2xxx] qla2x00_probe_one+0xc73/0x2390 [qla2xxx] ida_simple_get+0x98/0x100 kernfs_next_descendant_post+0x40/0x50 local_pci_probe+0x45/0xa0 pci_device_probe+0xfc/0x140 driver_probe_device+0x2c5/0x470 __driver_attach+0xdd/0xe0 driver_probe_device+0x470/0x470 bus_for_each_dev+0x6c/0xc0 driver_attach+0x1e/0x20 bus_add_driver+0x45/0x270 driver_register+0x60/0xe0 __pci_register_driver+0x4c/0x50 qla2x00_module_init+0x1ce/0x21e [qla2xxx] Cc: # 4.10 Signed-off-by: Sawan Chandak Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 + drivers/scsi/qla2xxx/qla_init.c | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h index ae119018dfaa..eddbc1218a39 100644 --- a/drivers/scsi/qla2xxx/qla_def.h +++ b/drivers/scsi/qla2xxx/qla_def.h @@ -3425,6 +3425,7 @@ struct qla_hw_data { uint8_t max_req_queues; uint8_t max_rsp_queues; uint8_t max_qpairs; + uint8_t num_qpairs; struct qla_qpair *base_qpair; struct qla_npiv_entry *npiv_info; uint16_t nvram_npiv_size; diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 034743309ada..0391fc317003 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -7543,12 +7543,13 @@ struct qla_qpair *qla2xxx_create_qpair(struct scsi_qla_host *vha, int qos, int v /* Assign available que pair id */ mutex_lock(&ha->mq_lock); qpair_id = find_first_zero_bit(ha->qpair_qid_map, ha->max_qpairs); - if (qpair_id >= ha->max_qpairs) { + if (ha->num_qpairs >= ha->max_qpairs) { mutex_unlock(&ha->mq_lock); ql_log(ql_log_warn, vha, 0x0183, "No resources to create additional q pair.\n"); goto fail_qid_map; } + ha->num_qpairs++; set_bit(qpair_id, ha->qpair_qid_map); ha->queue_pair_map[qpair_id] = qpair; qpair->id = qpair_id; @@ -7635,6 +7636,7 @@ struct qla_qpair *qla2xxx_create_qpair(struct scsi_qla_host *vha, int qos, int v fail_msix: ha->queue_pair_map[qpair_id] = NULL; clear_bit(qpair_id, ha->qpair_qid_map); + ha->num_qpairs--; mutex_unlock(&ha->mq_lock); fail_qid_map: kfree(qpair); @@ -7660,6 +7662,7 @@ int qla2xxx_delete_qpair(struct scsi_qla_host *vha, struct qla_qpair *qpair) mutex_lock(&ha->mq_lock); ha->queue_pair_map[qpair->id] = NULL; clear_bit(qpair->id, ha->qpair_qid_map); + ha->num_qpairs--; list_del(&qpair->qp_list_elem); if (list_empty(&vha->qp_list)) vha->flags.qpairs_available = 0;