From patchwork Wed May 31 13:33:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dupuis, Chad" X-Patchwork-Id: 9757059 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0C45760390 for ; Wed, 31 May 2017 13:34:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0700B20952 for ; Wed, 31 May 2017 13:34:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF797281F9; Wed, 31 May 2017 13:34:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E7FA20952 for ; Wed, 31 May 2017 13:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751201AbdEaNeq (ORCPT ); Wed, 31 May 2017 09:34:46 -0400 Received: from mail-cys01nam02on0089.outbound.protection.outlook.com ([104.47.37.89]:41385 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751164AbdEaNem (ORCPT ); Wed, 31 May 2017 09:34:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=z2HmGY0vpWnfCktmpAMXMuseDg/pv/9LBgsaM41x2xs=; b=YxZ06yX4cjW8ooYtqXjTAQq4hpCEstXA5KeEUc/TNkzzhfUs5PUzPppl1YFcGKB7KMs5554yIYUVr0/o7vY3KRfz02gvziwLnXoaeitoZfUnKTazzUWh6Q6jcq0bzPsExNaeQD9TgYlcz7myB+4W5Va8OQwzzf/dUpDMxfWQai0= Received: from DM5PR07CA0033.namprd07.prod.outlook.com (10.168.109.19) by BN1PR07MB423.namprd07.prod.outlook.com (10.141.59.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Wed, 31 May 2017 13:34:19 +0000 Received: from BL2FFO11OLC005.protection.gbl (2a01:111:f400:7c09::116) by DM5PR07CA0033.outlook.office365.com (2603:10b6:3:16::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9 via Frontend Transport; Wed, 31 May 2017 13:34:19 +0000 Authentication-Results: spf=none (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; oracle.com; dkim=none (message not signed) header.d=none; oracle.com; dmarc=none action=none header.from=cavium.com; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BL2FFO11OLC005.mail.protection.outlook.com (10.173.160.91) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.1101.12 via Frontend Transport; Wed, 31 May 2017 13:34:17 +0000 Received: from dut1171.mv.qlogic.com (172.29.51.171) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 31 May 2017 06:34:03 -0700 Received: from dut1171.mv.qlogic.com (localhost [127.0.0.1]) by dut1171.mv.qlogic.com (8.14.7/8.14.7) with ESMTP id v4VDY3QL016684; Wed, 31 May 2017 06:34:03 -0700 Received: (from root@localhost) by dut1171.mv.qlogic.com (8.14.7/8.14.7/Submit) id v4VDY3ZV016683; Wed, 31 May 2017 06:34:03 -0700 From: "Dupuis, Chad" To: CC: , , Subject: [PATCH V2 05/15] qedf: Check that fcport is offloaded before dereferencing pointers in initiate_abts|cleanup. Date: Wed, 31 May 2017 06:33:52 -0700 Message-ID: <20170531133402.16629-6-chad.dupuis@cavium.com> X-Mailer: git-send-email 2.12.0 In-Reply-To: <20170531133402.16629-1-chad.dupuis@cavium.com> References: <20170531133402.16629-1-chad.dupuis@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39450400003)(39850400002)(39400400002)(39410400002)(2980300002)(428002)(199003)(189002)(9170700003)(33646002)(50986999)(54906002)(478600001)(76176999)(36756003)(6666003)(110136004)(38730400002)(86362001)(2906002)(107886003)(80596001)(2950100002)(50466002)(6916009)(5660300001)(101416001)(4326008)(48376002)(2351001)(8936002)(1076002)(87636003)(42186005)(305945005)(105586002)(106466001)(189998001)(8676002)(47776003)(356003)(81166006)(50226002)(5003940100001)(72206003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR07MB423; H:CAEXCH02.caveonetworks.com; FPR:; SPF:None; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC005; 1:M6T0zJbMGJAzkhxdKFXqlyLKhvyfA3SXETWA9kdIKDBpmkzzHy3EmalnkqnXU/L6DB7imEpJ/hw9vseIkKpCP3S+3/+CSj5q9tBOSj6eiB/TABijUkJVs044IQ3LyyRBuL1p4aYeJbjt3d/jK6n56WOlpAOphqfjNnsSRFliVvom4ilhri34i9nQb+qpc1+s6+q+z+EGY5HVtdYm7yY4h8VpXWIhtiF+baBKdro8CCuIF5yd0Sxu52rlMIX3h8bajWTuzeUVTuqRHxzDD20BsxNlnWzF74zL7ybBS3eA0AqASje8PXrt1z/e52jyRKljq+uh3QyOSYK7PIOtAr6BNlSLdtZ75Kan3ECMzx47cV6qiz8fGPUeiz1ZtSv9De1f9S8dCmEbavEKurFTIoBvTRR4wcraQlEgoQwXhMSA1blHT52cRUZOiI//qWrQaA3hEXBiW6Uga8/T4WaYC5ipAg== X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PR07MB423: X-MS-Office365-Filtering-Correlation-Id: 50b97baa-49c3-44f9-7c45-08d4a829bce9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BN1PR07MB423; X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB423; 3:WnNKEeQkrY4bt07pEvM1vuL/zBEa4af6R0DKFz6T+jjK8eIDh04ZTb3rnMHmhYujkz9xUxdRyb+BP238Az0s/5gwVJDqWPBEQDErZAXX5wi5AbilbE9D5HHFq5yvV4ZLqI4pQGPZF+p5AiagbC09eRLu4qJVvq4EVDrYkMzgzxhYcJ/iUH2Dq87gcjX1YvrK0m4wJ1d/CZD2qC8oMIb9zrWJc+AbiA66PaK3cZqadFuaN5w1HeuBBAJpDsy9WjpKOUYmV8S9+nehwScKMyl89/EK20VI/e2QS5jaogbLl11pbimAaraRx2hEK7YEhZYFCeSx29UXbZW8xkHg5glwYqs+ry1VH6aoqJEC/kX7G/6g8XbCLnItTpOWiO9JaecvaUDX2ljjIWWkk2Gezv8CcfrN0dKYnpyhBwdNMJULwNyTw535l+VhocmwTu1Sr/HCD1XCEcCQ/VK8zjke57OZsX8IpVu3vLk8NsczFp+xfFZSgaVG6BD5wP53sbnSNk3d X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB423; 25:mYwt+/400wkAD5T1MGq4CG4sSvMeIdWiDtiBlj1o4tWVDmp6I9UFDtr4oPXbfeeGUOn84u1IHc/7FuhLfihFrAugVtqVcs0m0dk0A/kMeVvYQoJ7VnegCVKO0ibma1kSvOlEk0hGYeI4CZ6qzBJ3uFg7ZyXVxnAnk+VrI7x6Fh1aoaJjkq1CDjDpqvbKkzHgCImboh3X2ngPF2ixd4lLZ08uSTTjpZPwSj4xH6h1NH9xt4Rwq3b8cmS2dXJHcsUyQVkoicaidtUq9rlZ0q6rT84C3OAn95VeJxdcBy9cNvUMuPpbn9tYh34DDRBfwFK2kyb1NmrfUV4QCGQBEWJphYAuSZsw0VqkzIdAZmwUi4e5AUOOWp9Zal0W3AAloXbFWwHsKMK8q5gAlUIj8/DYp0shmbBes/KqlO25Za8kZsJSEM9sYgHn+57dMheKVJ5oZyjOpzlYfpf6JyAJmCE3jK5Ul3/L2+43n0wfcRWwz6A=; 31:xhsZFyjjRmb4L0WQvBLpHGitTNDpJrOC8hNDaeHfZPxXF8dF6m4mjXYCCTcaAbwB4a9RtcW/0t0b2O9FoW41h+ZMXYYm8oAp2arC3wNnJ1wHHWDJJczhS9Iv+VPFSQRMBUbvWsZ+RcTbRpVvmM6yAGuE5hNBrTm0hciG2AhaA2ulV17bxZ8gyGvee7NDyXFCi/Il5hdQ6ebLNsat7FZdljLdr3h8Sg4GZsR07gnPSPnml6iPX++khKI0TGSOI8ao X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB423; 20:jv72UjXGN9ejy0Oa1qD1swasruRvGeVuWTFi0CBPP9DoO5DvtaBdI2T/1f9OIZiS9g7O8ux8CsKORCDQ2S2AJ4oeuk6XPV3REabfHE1HBucX50ZU5o6ZM4OMXxlNZLWwSGQ40mWWTw7HAZRf+LvV9WsmUwkEbNRGMnGYpddWL4l+0zWiZqyI/8pIgu91B8lK0nkRUQJZPuPLx+hfs6UDOxkTXKxySmsARGmk4crIQzyVw14IrnNdjJEMH2s1hDDXC2UxZzGYJQVVfisuKh+05hhTi4bFxhmqETrY/yeffR2331R08Vwoioiy84Z8iDYF0D72RKeNw2RI+8ieZITVl2r6lFbv1B+qOk8FcKxRYNf3sgMqt1zaegEsdGSboSFuD4PTi34jxnvCAvOBNHVT4R/pGc8TJAjcAmZOnPzRXEDFTgB9Lgd0+nioGOofBrEjkIgqJTaH/HRyCzjL6BEH0747ROqiYBdlygjqdyDoybRLVh+D7e6mBzEIfRmv9TuF X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700073)(100105000095)(100000701073)(100105300095)(100000702073)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(13018025)(13016025)(93006095)(93001095)(100000703073)(100105400095)(10201501046)(3002001)(6041248)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123560025)(6072148)(100000704073)(100105200095)(100000705073)(100105500095); SRVR:BN1PR07MB423; BCL:0; PCL:0; RULEID:(100000800073)(100110000095)(100000801073)(100110300095)(100000802073)(100110100095)(100000803073)(100110400095)(100000804073)(100110200095)(100000805073)(100110500095); SRVR:BN1PR07MB423; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1PR07MB423; 4:y2kl2oAihOUTCiCrereO59ZW4AfU6A8qV7wo9g7ZJSU?= =?us-ascii?Q?uAx19WryWmEJrlCEifq19qjX0CxfocjdZRAeE5J3n8d0Vb/omkufy2OPSwiP?= =?us-ascii?Q?j7DC49Ntg/O4ZakJFCSlK55l797VnsrYPOje8B6t2nrQAhBU+U6ov3SCzwbl?= =?us-ascii?Q?1Dvj6OHCpLWuZ4+aRGHTzmfL7+C7KHlSt1VVE0SCJO5sXyGeikj50uBDjYvW?= =?us-ascii?Q?Y0e0rPUM74VZOjEM7sgw4YRtnBWJGMl8i/BlaopsVw7oI68WokVQAfYmO8vk?= =?us-ascii?Q?dQBI/M5vObDle74b+4qyfqx/f23m4yMrDmIEzqk5pckQk5TVQ5O5+1ZEwSTk?= =?us-ascii?Q?YG/YQrBG2nqUBEFkapw+sNElJJwq3QcOSbOR65PjmejIaoRAocIGs7K2JAdF?= =?us-ascii?Q?iuL41SrC0rPyjeS1DcOEl5uWpdb3UTvaciXpOOY6CmLeWc1P5BfJNaeeNV00?= =?us-ascii?Q?PLQ6neN7zHG8M/MsaOZ01LT8MvEsddvMovWz0ju2ro55SOWDEU+iFtOw4SJ0?= =?us-ascii?Q?BMjwG+qHu6u+x4X8pdJE+Cvho4JsxXH4FZEUkeVyYeo9KhrhuZUu0hr03fTB?= =?us-ascii?Q?0Ub8gx7uYePyb/ooBQRUfdQDjc+8LujKSGwRe7xe7YmnGNYsBcZNDPw26Bqf?= =?us-ascii?Q?FABXG9KbgzU/M23JExeJc/rslWft/p9PiWDBMXVqSCLHIEIJGpqB+6XAtKnS?= =?us-ascii?Q?o9Y6inise5s40miMMcTJEYyLeOpwreGHfzNMe3dqgarEd0L1BVIdZ0BMbasL?= =?us-ascii?Q?WVlfsu08zEHNjcF0N56oNa+28UUVFQ7tR5yMSaDSNdmrHnb3VPRiUM/bj+85?= =?us-ascii?Q?X3fDzFD8HURabFn8ZAz5MwEdKhcnqzN0unR/ANT3WkyRQvlsELtO9kWNZTNK?= =?us-ascii?Q?LTDxUrwmu8IxKB3JgfpbMwid1xp6K0NLwETwYtJpmA5Vj1O3ETUMUaFKfWIb?= =?us-ascii?Q?bRD8LR+GN/glndEII+6n0Ue59prY/4EMXg/zJNng1aS1kV10uYr5uJ3Eoif2?= =?us-ascii?Q?+C5HGYqH2ut+ZVjrDeV2DY8k/IciqWaBqI+I0Wn/dwl//sNvXEMcepc9kA4F?= =?us-ascii?Q?FSscIJbvfqnU8F+qRcDc0C6GZanRetItvjnf/evf4IZW/OclzQXTBuzAR81l?= =?us-ascii?Q?rJBVDIhDHDRFfVuELfRJDdOWsEgrPHNp3rIm/CwCQKGqNST457wGvpuJKnC4?= =?us-ascii?Q?W7KJTAXSUtYQ=3D?= X-Forefront-PRVS: 0324C2C0E2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN1PR07MB423; 23:2viIItvPnL0zsUsz635eb+IBhlGJlcFQhMC9+yptYJ?= =?us-ascii?Q?hrPfqusa3xdpX3n1DWjWHUKaHuSJJg5PDPA+ZV4kb9Pv5D+fGC3kBm+1Y955?= =?us-ascii?Q?SyBzT2GKOYoyfRrrjsNR1SsQlj02IIKYeg7pgoUmVvcaHHg/udYgALsQ5nIP?= =?us-ascii?Q?pyNl3bev75ghFV+5mS/sCNVjr0rf3tDPI0d13rcKcuxKIf5XRsOrZRFRHHko?= =?us-ascii?Q?JlTUD4DpAw23Zf+7RFjw7ezg2Zq06ais5FliaDt8TS5XZCpE36kOtiyaFa2u?= =?us-ascii?Q?xp7VGIOaP8H+yVqA2rJRLQRLnq7EGjnv9N7tG1V/C9PBcBcG3XtMCw85Iv4y?= =?us-ascii?Q?hB/wopCSSVRW/SRja9EhKjNlorUw9t6BZS4EYsrxZyEX9+Xbbd6zqLc9rw5S?= =?us-ascii?Q?2uc19gMKCOzb5/QpcKwMKLI5Rryi5b9zBgM4Y4G37nV0nZTzNzG3aweVbkqU?= =?us-ascii?Q?g//p7jJvlJQXV5yBOfW22dcmcpuTSVF4ZMvwstpa7m3b/DSyJAW2wmoD/pWv?= =?us-ascii?Q?gKvoxnjQX7cT0Ay8xMw8m5noclCcDSctxjmIXOEXdaSiulP+PLhwDZdzQxcP?= =?us-ascii?Q?aSwNyFMq+mSZxjeKS8zNa7LnFGPNDbEw8OBa2y5Li+DSLjj9u9HgWiNzGI8K?= =?us-ascii?Q?8botrCSLs35K2F9WYx3AgsBVuwZ4PKyb/SIqoNwuj0HH0EzavlF6AdL+Cp0K?= =?us-ascii?Q?9/Pl2+zPze7xBzl/xSfu6g7Uw1tPZVBQSA3qvAz8CsbUOTCqPy0Xiq3Qdn6b?= =?us-ascii?Q?LfMBufN4Z/YqTRpvryIfGKABQG1Z8EvZudqrDH28+AxPVt0KEL24wF3odAhI?= =?us-ascii?Q?7WLkj24/r830NN+R4nWibpXZmm1zWzDCnBZwJA7kMHQdFtZQsb8r/ajM303i?= =?us-ascii?Q?WwRJY2B4kijdUESj5w/xxuvjIUSQ93R0xNW9zAcsqDuUzN0K17TBZfM8H/VW?= =?us-ascii?Q?aXw5+dLXOe1KFuAbWZswf45FNdj6YVnkX1gTdgGJiTSIv4SleIKczf1Vaxho?= =?us-ascii?Q?Rp9oMGLoTQeXKmUMPy9VX3he5kJkjC8jGkzyMpUy2mn1/RxQG3PPzbT981UD?= =?us-ascii?Q?XCmSuXRM6m2pq2uTdujBGc8HfLSGCuUj9xAqrhYhZ6oK1AulYYmatNFwVfNO?= =?us-ascii?Q?ONs9UXkJfnSumNRtXjqbUXRHeqEZ1bKuCH6JYIbDQcM4JofaM4sg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB423; 6:UG6gPWE3v2bRJ4IFs+lhFxOR7x21GtJ0m+cut4lBXguAVXptxlS+xBSZEk/7OFwS7Zo4NqbteosCIdgVVVkmxkVx7LBySx6VneTzaCLL5DZBD3jXNNythos01967WoSuKEw7obHcDndN2DGLAp4I/9BpjsJjdGDog0UNFdbQh0WDfXwHREv2CWhKeQFm1I+UC49vzg5S+v5qd1YHBQMz816LFZMujV+IKYR0Tm04l6zgdHhoctHR201Czl11/yhgOgj0AzORVO7QcJolfsaQsxVO9y8ScOP/gTzgpncPITBANeHYWRiWseyNjSeDfxQMNxCLrAwo0y8G9hU9iYTaAtSiPzA96Hbheu/cl78JlfZE1gd2MWBh0z41ZKrfBCzeHzIyGYLdcwfmiNv+/Rrj8mentxxCi8Rn3RwdjY9drKab1v80SnNEKkfwrW9jhsktVIZuwR+zpA57XJlju3BtwrBkOdL4vRZkO7Ppy4yTl+5m3BOLCY5w97N+63Rt/xLstkpCka4PrvZ46QO7IomNlw== X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB423; 5:qzHxlppBRnGQe7XSisCUk9SMSpyqKmBAvo6cgrtpZYY8FogSVAZQN8uJkECvHG8V5ueSZ+DEv+K0SPaFnq9KiRL3340G/GKdCpiAb+YJF7chsH70LbBZXxsoi4gYdrYolQxrkIn0s1kXv6gnPZLWHJHIPgJmU99Q0oHLT63ZTOzf4DxiTLUsJx9gNwDxyQ7hC+6nafacQQXjVMTqrEzSQb6aMCQSRtau83sxOrkr4N6AbS6WMQFnR4nWVflXRxoHGQSy2s3Y+ITzTP8FKDNet/fBXHXeGOVgePCvxs3SIB1BaDuX5bXUIIOC+kEzMAMZJ8Vn5WdQ1DAYLePZheGXfib4bXUxHY6mSY6mvgR9mual0Wk0Sx/GQs1LFwBNdwCwWELFhj4meHr159y3G5R5vio5jydcCaZfeGZGdHAlpOwREmApe2kwJEUtrBaioD5b9lIZ+PvXku5CKgwtYM2lkPRvTuodFpPOylCQ3lLT+Bg33bZekIGcPPUSD7u83P3j; 24:3/scb5pugbe+RHoLLPYVkcOuNsglluRWAXR2w+FwbrKI9YzsmuzYvKVsaHXT3mTD5LscQxeHSGJH8mQKzF0m4awaAC9YrHtAwSI0K2+K30A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN1PR07MB423; 7:G+Sm6TnX3gBYtMe77OZxTo17uxc29qcQXy3pQa3ziNwgyFGkNIeKVj1nZIAKZVUBr3wyUz5gcpdHQ7xB6LVlwLnrN6yu6vcQ+KW8yPF1i6W4IRdVz+eTNUUwkthRmBu4Ps87DRPhJ3IsuR1WMWJZdjEk2njXCA8ckQ2e/o7umDAEVdL/5Bg76bHPQjYXvP5RDK2+wrgO+JrX5r0bkW7mFwq8Ws/rR86xKreIqXxu5S1PtC8VbuyzhRM36C2hOcj7zNqNQBKocK8BlchXo6Ue+LeCXfr0X6vmummkbMnK8Rn9StclWBwEQqp0rYdLtHSVT15DfwvaQu0tjBxfWAnmsQ== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2017 13:34:17.8414 (UTC) X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR07MB423 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If an fcport is not offloaded then the members of the qedf_rport struct are undefined which may cause a system crash. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index ca9097b..db16004 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -1476,8 +1476,8 @@ int qedf_initiate_abts(struct qedf_ioreq *io_req, bool return_scsi_cmd_on_abts) { struct fc_lport *lport; struct qedf_rport *fcport = io_req->fcport; - struct fc_rport_priv *rdata = fcport->rdata; - struct qedf_ctx *qedf = fcport->qedf; + struct fc_rport_priv *rdata; + struct qedf_ctx *qedf; u16 xid; u32 r_a_tov = 0; int rc = 0; @@ -1485,15 +1485,18 @@ int qedf_initiate_abts(struct qedf_ioreq *io_req, bool return_scsi_cmd_on_abts) struct fcoe_wqe *sqe; u16 sqe_idx; - r_a_tov = rdata->r_a_tov; - lport = qedf->lport; - + /* Sanity check qedf_rport before dereferencing any pointers */ if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) { - QEDF_ERR(&(qedf->dbg_ctx), "tgt not offloaded\n"); + QEDF_ERR(NULL, "tgt not offloaded\n"); rc = 1; goto abts_err; } + rdata = fcport->rdata; + r_a_tov = rdata->r_a_tov; + qedf = fcport->qedf; + lport = qedf->lport; + if (lport->state != LPORT_ST_READY || !(lport->link_up)) { QEDF_ERR(&(qedf->dbg_ctx), "link is not ready\n"); rc = 1; @@ -1729,6 +1732,13 @@ int qedf_initiate_cleanup(struct qedf_ioreq *io_req, return SUCCESS; } + /* Sanity check qedf_rport before dereferencing any pointers */ + if (!test_bit(QEDF_RPORT_SESSION_READY, &fcport->flags)) { + QEDF_ERR(NULL, "tgt not offloaded\n"); + rc = 1; + return SUCCESS; + } + qedf = fcport->qedf; if (!qedf) { QEDF_ERR(NULL, "qedf is NULL.\n");